Mysterious use of string-as-multibyte

Mysterious use of string-as-multibyte

[Stefan Monnier]

Hi,

Do you remember why you added the call to string-as-multibyte in the
patch below?


        Stefan


commit 83af570eae8668c9308050c1bb56b7bd10c0e4e7
Author: Kenichi Handa <handa@m17n.org>
Date:   Tue May 25 11:12:17 1999 +0000

    (smtpmail-send-it): Bind smtpmail-code-conv-from properly.
    (smtpmail-send-data-1): If DATA is a multibyte string, encode it
    by smtpmail-code-conv-from.

diff --git a/lisp/mail/smtpmail.el b/lisp/mail/smtpmail.el
index 4778ded17b..192235a242 100644
--- a/lisp/mail/smtpmail.el
+++ b/lisp/mail/smtpmail.el
@@ -122,7 +122,11 @@ smtpmail-send-it
        (tembuf (generate-new-buffer " smtpmail temp"))
        (case-fold-search nil)
        delimline
-       (mailbuf (current-buffer)))
+       (mailbuf (current-buffer))
+       (smtpmail-code-conv-from
+        (if enable-multibyte-characters
+            (let ((sendmail-coding-system smtpmail-code-conv-from))
+              (select-message-coding-system)))))
     (unwind-protect
        (save-excursion
          (set-buffer tembuf)
@@ -564,8 +568,10 @@ smtpmail-send-command
 (defun smtpmail-send-data-1 (process data)
   (goto-char (point-max))
 
-  (when smtpmail-code-conv-from
-    (setq data (encode-coding-string data *internal* smtpmail-code-conv-from)))
+  (if (and (multibyte-string-p data)
+           smtpmail-code-conv-from)
+      (setq data (string-as-multibyte
+                  (encode-coding-string data smtpmail-code-conv-from))))
        
   (if smtpmail-debug-info
       (insert data "\r\n"))

Re: Mysterious use of string-as-multibyte

[handa]

In article <jwv373c5qqh.fsf-monnier+emacs@gnu.org>, Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> Do you remember why you added the call to string-as-multibyte in the
> patch below?
[...]
> -  (when smtpmail-code-conv-from
> -    (setq data (encode-coding-string data *internal* smtpmail-code-conv-from)))
> +  (if (and (multibyte-string-p data)
> +           smtpmail-code-conv-from)
> +      (setq data (string-as-multibyte
> +                  (encode-coding-string data smtpmail-code-conv-from))))
        
>    (if smtpmail-debug-info
>        (insert data "\r\n"))

I don't remember, sorry.  By guessing from the code, that change is to
make DATA a multibyte string so that the encoding done by the following
process-send-string produces the correct byte sequence.  Perhaps, the
change was done before the introduction of string-to-multibyte which is
more suitable for that purpose.

---
K. Handa
handa@gnu.org

Re: Mysterious use of string-as-multibyte

[Stefan Monnier]

> I don't remember, sorry.  By guessing from the code, that change is to
> make DATA a multibyte string so that the encoding done by the following
> process-send-string produces the correct byte sequence.  Perhaps, the
> change was done before the introduction of string-to-multibyte which is
> more suitable for that purpose.

Thanks.  After verification, process-send-string will nowadays handle
both kinds of strings in the same way, so I dropped the
string-as-multibyte.

        Stefan

Re: Mysterious use of string-as-multibyte

[handa]

In article <jwv8tcykdjw.fsf-monnier+emacs@gnu.org>, Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> > I don't remember, sorry.  By guessing from the code, that change is to
> > make DATA a multibyte string so that the encoding done by the following
> > process-send-string produces the correct byte sequence.  Perhaps, the
> > change was done before the introduction of string-to-multibyte which is
> > more suitable for that purpose.

> Thanks.  After verification, process-send-string will nowadays handle
> both kinds of strings in the same way,

Ah, that's good.

> so I dropped the string-as-multibyte.

Thank you.

---
K. Handa
handa@gnu.org