From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: handa@gnu.org (K. Handa) Newsgroups: gmane.emacs.devel Subject: Re: Issues with quail.el Date: Sat, 12 May 2018 21:24:54 +0900 Message-ID: <87po21f4dl.fsf@gnu.org> References: <20180510141234.tpj4vagod6bejmta@isis.luna> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1526127796 14520 195.159.176.226 (12 May 2018 12:23:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 12 May 2018 12:23:16 +0000 (UTC) Cc: emacs-devel@gnu.org To: Amit Ramon Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 12 14:23:12 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHTYM-0003ei-Qi for ged-emacs-devel@m.gmane.org; Sat, 12 May 2018 14:23:11 +0200 Original-Received: from localhost ([::1]:42027 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHTaT-0006UA-Mw for ged-emacs-devel@m.gmane.org; Sat, 12 May 2018 08:25:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHTaJ-0006NO-SR for emacs-devel@gnu.org; Sat, 12 May 2018 08:25:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHTaG-0004yB-MW for emacs-devel@gnu.org; Sat, 12 May 2018 08:25:11 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHTa6-0004xN-Eh; Sat, 12 May 2018 08:24:58 -0400 Original-Received: from fl1-119-240-85-224.iba.mesh.ad.jp ([119.240.85.224]:33974 helo=mongkok) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fHTa5-0002MX-V1; Sat, 12 May 2018 08:24:58 -0400 Original-Received: from handa by mongkok with local (Exim 4.90_1) (envelope-from ) id 1fHTa2-0004et-6D; Sat, 12 May 2018 21:24:54 +0900 In-Reply-To: <20180510141234.tpj4vagod6bejmta@isis.luna> (message from Amit Ramon on Thu, 10 May 2018 17:12:34 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225266 Archived-At: Very sorry for the late response. In article <20180510141234.tpj4vagod6bejmta@isis.luna>, Amit Ramon writes: > > When I try to recreate what you are showing, I get the following. > > Does this match? > > > > +----------------------------------------------------------------+ > > | 1! | 2" | 3=C2=A7 | 4$ | 5% | 6& | 7/ | 8( | 9) | 0( | =C3=9F? | = '` | ;^ | > > +----------------------------------------------------------------+ > > | qQ | 'W | =D7=A7=E2=80=8EE | =D7=A8=E2=80=8ER | =D7=90=E2=80=8E= T | =D7=98=E2=80=8EZ | =D7=95=E2=80=8EU | =D7=9F=E2=80=8EI | =D7=9D=E2=80= =8EO | =D7=A4=E2=80=8EP | ]} | [{ | > > +------------------------------------------------------------+ > > | =D7=A9=E2=80=8EA | =D7=93=E2=80=8ES | =D7=92=E2=80=8ED | =D7= =9B=E2=80=8EF | =D7=A2=E2=80=8EG | =D7=99=E2=80=8EH | =D7=97=E2=80=8EJ | = =D7=9C=E2=80=8EK | =D7=9A=E2=80=8EL | =D7=A3=E2=80=8E=C3=96 | ,=C3=84 | ~| | > > +--------------------------------------------------------------+ > > | >< | =D7=96=E2=80=8EY | =D7=A1=E2=80=8EX | =D7=91=E2=80=8EC | =D7= =94=E2=80=8EV | =D7=A0=E2=80=8EB | =D7=9E=E2=80=8EN | =D7=A6=E2=80=8EM | = =D7=AA=E2=80=8E> | =D7=A5=E2=80=8E< | ._ | > > +------------------------------------------------------+ [...] > This is what it should look like: > +----------------------------------------------------------------+ > | 1! | 2@ | 3# | 4$ | 5% | 6^ | 7& | 8* | 9) | 0( | -_ | =3D+ | `~ | > +----------------------------------------------------------------+ > | /Q | 'W | =D7=A7=E2=80=8EE | =D7=A8=E2=80=8ER | =D7=90=E2=80=8ET= | =D7=98=E2=80=8EY | =D7=95=E2=80=8EU | =D7=9F=E2=80=8EI | =D7=9D=E2=80=8E= O | =D7=A4=E2=80=8EP | ]} | [{ | > +------------------------------------------------------------+ > | =D7=A9=E2=80=8EA | =D7=93=E2=80=8ES | =D7=92=E2=80=8ED | =D7=9B= =E2=80=8EF | =D7=A2=E2=80=8EG | =D7=99=E2=80=8EH | =D7=97=E2=80=8EJ | =D7= =9C=E2=80=8EK | =D7=9A=E2=80=8EL | =D7=A3=E2=80=8E: | ," | \| | > +-----------------------------------------------------------+ > | =D7=96=E2=80=8EZ | =D7=A1=E2=80=8EX | =D7=91=E2=80=8EC | =D7= =94=E2=80=8EV | =D7=A0=E2=80=8EB | =D7=9E=E2=80=8EN | =D7=A6=E2=80=8EM | = =D7=AA=E2=80=8E> | =D7=A5=E2=80=8E< | .? | > +-------------------------------------------------+ [...] > Note, for example, the location of the "Y" and "Z", and the two keys > right of the "L". This layout is the standard for a Hebrew keyboard > layout (the Israeli standard, at least), and this is what a Hebrew > writer would expect when Hebrew input method is set. (you can get it > simply if you don't change your keyboard layout -- assuming it is the > standard one -- and then set input method to Hebrew, and do C-h I.) It seems that the difference is at such a key that is different from the standard layout and that is not mapped to Hebrew. So, I suspect that the code (in quail-insert-kbd-layout) handling such a key should be fixed. Could you please try the attached patch? [...] > What I get for the second letter (TET, =D7=98) is: > =D7=98 can't be input by the current input method I confimed this bug, but it seems that fixing take more time. Please wait. > (add-to-list 'quail-keyboard-layout-alist > `("dvorak" . ,(concat " " > " 1!2@3#4$5%6^7&8*9(0)[{]}`~ " > " '\",<.>pPyYfFgGcCrRlL/?=3D+ " > " aAoOeEuUiIdDhHtTnNsS-_\\| " > " ;:qQjJkKxXbBmMwWvVzZ " > " "))) > (quail-set-keyboard-layout "dvorak") > If you actually evaluate this elisp code, you could call > "quail-set-keyboard-layout" once with "dvorak" and once with > "standard" and compare the results of C-h I (and for that you don't > have to change the actual layout of the keyboard). > * Emacs has (see quail.el) definitions for sun-type3, atari-german, > pc102-de, jp106 and pc105-uk keyboard layouts only, but not Dvorak > (anyone has an idea why? perhaps it is time to add it?) I agree. > [2] The definitions for the standard Hebrew input method ("hebrew" and > "hebrew-new") do not explicitly define the first shift level. Perhap > the author of it trusted quail to take this from the English standard > layout (the first shift level is identical, at least most of > it). However, perhaps it would be safer to completly define the Hebrew > layout, including the first shift level. For that, I don't have a strong opinion. But, I think it is not good to add extra code for hiding a bug of quail. --- K. Handa handa@gnu.org diff --git a/lisp/international/quail.el b/lisp/international/quail.el index eece836354..a81244a1db 100644 --- a/lisp/international/quail.el +++ b/lisp/international/quail.el @@ -815,7 +815,7 @@ quail-insert-kbd-layout (aref (cdr translation) 0) " "))) (setq done-list (cons translation done-list))) - (setq translation (aref kbd-layout i))) + (setq translation ch)) (aset layout i translation)) (setq i (1+ i))) =20