From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: Using the GNU GMP Library for Bignums in Emacs Date: Fri, 06 Jul 2018 22:27:25 -0600 Message-ID: <87pnzzoeky.fsf@tromey.com> References: <29f933ac-a6bf-8742-66a7-0a9d6d3e5a88@disroot.org> <83bmecy6fx.fsf@gnu.org> <0d3175d8-d996-651e-b221-71978bde3a65@cs.ucla.edu> <87tvpdnzgy.fsf@tromey.com> <4c2a814f-c254-29e5-39cf-11b5f2e5c9c8@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1530937580 19407 195.159.176.226 (7 Jul 2018 04:26:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 7 Jul 2018 04:26:20 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) Cc: Tom Tromey , Stefan Monnier , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 07 06:26:16 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbenX-0004sp-F6 for ged-emacs-devel@m.gmane.org; Sat, 07 Jul 2018 06:26:15 +0200 Original-Received: from localhost ([::1]:60522 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbepc-00040t-Si for ged-emacs-devel@m.gmane.org; Sat, 07 Jul 2018 00:28:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbeow-00040n-8a for emacs-devel@gnu.org; Sat, 07 Jul 2018 00:27:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fbeot-0004vW-55 for emacs-devel@gnu.org; Sat, 07 Jul 2018 00:27:42 -0400 Original-Received: from gateway30.websitewelcome.com ([192.185.194.16]:35958) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fbeos-0004rf-Rb for emacs-devel@gnu.org; Sat, 07 Jul 2018 00:27:39 -0400 Original-Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 942772C33 for ; Fri, 6 Jul 2018 23:27:26 -0500 (CDT) Original-Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id beogfqhfdPvAdbeogfxvuT; Fri, 06 Jul 2018 23:27:26 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zoox1E6qoEa2Qos7Whj5pMTTuMXUx1JnPB6ivSlJUG4=; b=vGgqj2h6tbNxaN4DTZx6/Z6zGB 8BrBH8vQ4pUgU1wF6f/psqOK2JS3V5rTSaTnW/uxG+n9UEbZq33x27qohGuL0GAb4hgwbL8T4tXf3 bLlmCwKMOaY22H7yVHjcsI55c; Original-Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:38900 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fbeog-003nZp-4B; Fri, 06 Jul 2018 23:27:26 -0500 X-Attribution: Tom In-Reply-To: <4c2a814f-c254-29e5-39cf-11b5f2e5c9c8@cs.ucla.edu> (Paul Eggert's message of "Fri, 6 Jul 2018 14:00:40 -0700") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.85.72 X-Source-L: No X-Exim-ID: 1fbeog-003nZp-4B X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-85-72.hlrn.qwest.net (bapiya) [75.166.85.72]:38900 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 192.185.194.16 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227028 Archived-At: Tom> 1. Should the C core change the names of things like NUMBERP to FIXNUMP? Tom> Similarly should make_number -> make_fixnum? Paul> Yes, we should keep things clear in the C core, and this would Paul> definitely be clearer. Please do it as a separate commit, though. Yes, definitely. I ran this and got a big patch: sed -i 's/INTEGERP/FIXNUMP/g' *.[ch] sed -i 's/make_number/make_fixnum/g' *.[ch] sed -i 's/CHECK_NUMBER/CHECK_FIXNUM/g' *.[ch] I wasn't sure if I should try to rename NUMBERP or NATNUMP. On the one hand they are really checking only for fixnums. On the other hand, the logical names seem like they'd be unwieldy. Also I was not sure what to do with calls like: #define lisp_h_CHECK_FIXNUM(x) CHECK_TYPE (FIXNUMP (x), Qintegerp, x) Here it is using 'integerp, but that will be a bit false. Also I found the bug with arith_driver and now the branch can bootstrap again. Tom