From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: module documentation draft Date: Sun, 14 Oct 2018 16:47:25 +0100 Message-ID: <87pnwcfs36.fsf@tcd.ie> References: <83k20h78sb.fsf@gnu.org> <83a81d5iay.fsf@gnu.org> <83zhvkwees.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1539531970 398 195.159.176.226 (14 Oct 2018 15:46:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 14 Oct 2018 15:46:10 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: phst@google.com, Philipp Stephani , aurelien.aptel@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 14 17:46:05 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBiaj-0008RQ-Ag for ged-emacs-devel@m.gmane.org; Sun, 14 Oct 2018 17:46:05 +0200 Original-Received: from localhost ([::1]:48755 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gBicp-0001lF-QQ for ged-emacs-devel@m.gmane.org; Sun, 14 Oct 2018 11:48:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38257) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gBicD-0001l6-AF for emacs-devel@gnu.org; Sun, 14 Oct 2018 11:47:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gBicA-0002nI-0o for emacs-devel@gnu.org; Sun, 14 Oct 2018 11:47:37 -0400 Original-Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]:45964) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gBic9-0002l7-Nr for emacs-devel@gnu.org; Sun, 14 Oct 2018 11:47:33 -0400 Original-Received: by mail-ed1-x530.google.com with SMTP id v18-v6so15560660edq.12 for ; Sun, 14 Oct 2018 08:47:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=R4SQMZrp4EIPNxnKMp4pSBFALgEBLUioQy6EcHOe9sU=; b=VCz7FekCQwfUkLj8fc8ZuclQAYLFK4EnrOnZZ7/i6xe4UXJdyREKZ19nRSS4TkUs7e TCaAXfKEv/EHEcKsF0iBm7r7LGnz9BSTnsr9qfSLiFXjm8vm+uvdkE5+jlpRv5HWlg7d XaKCXLyMe7tkv5zmXHmGkMEJwgvyIC+d49XVHMdgpVDsQgqETyu4vGDmQIYly9mm37Im lAmVaXwBbXVvQSxhQmDqVb6Se2CR3u/x8xc09hbjZ6zsCodCxcMkAHaosMJFE4ei3ZtP YMagOmRYfqLwaQrlRgN0183KPkQjzcPgPzkTn/kMpKg6XFXO7GeM8+9YwXAnKsF1RlIe Um7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=R4SQMZrp4EIPNxnKMp4pSBFALgEBLUioQy6EcHOe9sU=; b=SguFq4ccrQ0Wd2c+V/7ZkA/dgRRn3eD5R/QYf3zh1kLpFkBeNttynnKMg9TnEzbH7m kJjZ1ZRTdRXyNz5QiTCW4oSxinwFrf3R4kifntfY+QOLP/OsegQZBmJWZTO+X9V9sxmT ooe7uvfuhgGYk1mJqbValcDwby6HsTV4h68aNZ/z/RrnVy9GPsNk0Egcsic81mFhJBHO McsmsoumG83hAa0NYHdy3B7Kbztnm7EnM2se2hk+7h0h4rxbeIcFpK0uaUShSYoGLdb0 GwydAsxbGY84ypdaJzZyFz0Nqa9ogptZSnjSMEiyvgbGn9ZrAqsBjQL22HbeHiBcVAQM pGng== X-Gm-Message-State: ABuFfoiAhnoKUKrD6rcv8LkcdimA4c25QBMPYNZbnNCyTWIssZgkAseg /sty1vpyEdaoqHK+zoGczGb7Fw== X-Google-Smtp-Source: ACcGV62UUA2a9laqvJ5mgfW78Gufn5DpXPdneo/lh7F1/eH6qTjLasbwpUd0WmcHnyDsdMEvOgEzuw== X-Received: by 2002:a17:906:4f18:: with SMTP id t24-v6mr15577973eju.121.1539532052360; Sun, 14 Oct 2018 08:47:32 -0700 (PDT) Original-Received: from localhost ([213.233.155.141]) by smtp.gmail.com with ESMTPSA id k13-v6sm3348927edb.89.2018.10.14.08.47.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 14 Oct 2018 08:47:31 -0700 (PDT) In-Reply-To: <83zhvkwees.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 11 Oct 2018 21:01:47 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::530 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230379 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: > I've finally got to writing up this stuff, please take a look at the > ELisp manual's node "Writing Dynamic Modules" on the latest emacs-26 > branch. Comments are welcome. It all made sense to me, FWIW. I only noticed one potential improvement: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=internals.diff diff --git a/doc/lispref/internals.texi b/doc/lispref/internals.texi index 311eb6b262..c1d855fc2d 100644 --- a/doc/lispref/internals.texi +++ b/doc/lispref/internals.texi @@ -1190,7 +1190,7 @@ Module Functions Lisp function object from it using @code{make_function}. This is normally done in the module initialization function (@pxref{module initialization function}), after verifying the @acronym{API} -compatibility, and uses the pointer to @code{make_function} provided +compatibility, and using the pointer to @code{make_function} provided in the environment (recall that the pointer to the environment is returned by @code{get_environment}). --=-=-= Content-Type: text/plain > I'd like to take this opportunity to thank Philipp for his document > (https://phst.github.io/emacs-modules), which I used as inspiration > and as a reference against which to check my text. Thanks! Thanks to both of you for the great work! -- Basil --=-=-=--