From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Eli Zaretskii <eliz@gnu.org>
Cc: phst@google.com, Philipp Stephani <p.stephani2@gmail.com>,
aurelien.aptel@gmail.com, emacs-devel@gnu.org
Subject: Re: module documentation draft
Date: Sun, 14 Oct 2018 16:47:25 +0100 [thread overview]
Message-ID: <87pnwcfs36.fsf@tcd.ie> (raw)
In-Reply-To: <83zhvkwees.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 11 Oct 2018 21:01:47 +0300")
[-- Attachment #1: Type: text/plain, Size: 289 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
> I've finally got to writing up this stuff, please take a look at the
> ELisp manual's node "Writing Dynamic Modules" on the latest emacs-26
> branch. Comments are welcome.
It all made sense to me, FWIW. I only noticed one potential
improvement:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: internals.diff --]
[-- Type: text/x-diff, Size: 655 bytes --]
diff --git a/doc/lispref/internals.texi b/doc/lispref/internals.texi
index 311eb6b262..c1d855fc2d 100644
--- a/doc/lispref/internals.texi
+++ b/doc/lispref/internals.texi
@@ -1190,7 +1190,7 @@ Module Functions
Lisp function object from it using @code{make_function}. This is
normally done in the module initialization function (@pxref{module
initialization function}), after verifying the @acronym{API}
-compatibility, and uses the pointer to @code{make_function} provided
+compatibility, and using the pointer to @code{make_function} provided
in the environment (recall that the pointer to the environment is
returned by @code{get_environment}).
[-- Attachment #3: Type: text/plain, Size: 257 bytes --]
> I'd like to take this opportunity to thank Philipp for his document
> (https://phst.github.io/emacs-modules), which I used as inspiration
> and as a reference against which to check my text. Thanks!
Thanks to both of you for the great work!
--
Basil
next prev parent reply other threads:[~2018-10-14 15:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 17:04 module documentation draft Aurélien Aptel
2017-07-23 18:57 ` Philipp Stephani
2017-07-25 12:50 ` Aurélien Aptel
2017-09-28 20:25 ` Philipp Stephani
2017-09-28 21:51 ` Aurélien Aptel
2017-09-29 16:45 ` Eli Zaretskii
2017-09-29 16:49 ` Aurélien Aptel
2017-09-29 18:08 ` Eli Zaretskii
2017-09-29 20:39 ` Philipp Stephani
2017-09-29 21:03 ` Eli Zaretskii
2017-12-26 21:06 ` Philipp Stephani
2018-10-11 18:01 ` Eli Zaretskii
2018-10-14 15:47 ` Basil L. Contovounesios [this message]
2018-10-14 16:14 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnwcfs36.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=aurelien.aptel@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=p.stephani2@gmail.com \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).