From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Proposed changes to gnus-dup.el Date: Mon, 25 Mar 2019 17:33:32 +0000 Message-ID: <87pnqerh8z.fsf@tcd.ie> References: <8736nbip4l.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="189404"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 25 18:35:05 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8TV3-000n82-5b for ged-emacs-devel@m.gmane.org; Mon, 25 Mar 2019 18:35:05 +0100 Original-Received: from localhost ([127.0.0.1]:46005 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8TV2-0001CF-5L for ged-emacs-devel@m.gmane.org; Mon, 25 Mar 2019 13:35:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53384) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8TTy-0001C6-Ti for emacs-devel@gnu.org; Mon, 25 Mar 2019 13:34:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8TTw-00068K-Dp for emacs-devel@gnu.org; Mon, 25 Mar 2019 13:33:57 -0400 Original-Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:35835) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h8TTu-0005yj-Dz for emacs-devel@gnu.org; Mon, 25 Mar 2019 13:33:54 -0400 Original-Received: by mail-ed1-x536.google.com with SMTP id s39so2793538edb.2 for ; Mon, 25 Mar 2019 10:33:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=37ctwGq4NmVFNm8j1qqLGMiQN873vGi+KLaLk2jeWiU=; b=mX3kr7bFocXyGJOFAh2YarX3zLxEpREKyA/GAmJPxiKKtceI4dCYXMKPBKDj9uxC1F Fi5ERMTUDg3Ye80ZLkQ4sSYAoDp+LF7UdXlkxtwXskDDpxorWDzbcTChKUNaT3uNeajI Fl9amJgdCNS2pkN9zGXRUG+64njxfopWamE45T0NGCZ68t0C4UoYTJBuyNcO/KvvwHLH K9gHMWab/Y5E1M0xUppHyIFwEjaKztMFBQj9m7B7uc+oiQDRu7T9G0JyCzAqTIuWK3E7 ybAlLJjORy4j0jgFSBh5PQm37v5U39aT64WggjgQpqwfqZBHA1i0sWSFC2wL2Nk3qYnC eCOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=37ctwGq4NmVFNm8j1qqLGMiQN873vGi+KLaLk2jeWiU=; b=MlnQG5ZLbLzW/R2jMLMOqqRpSIxwf1kWfgYgsQtdaLLo0f7Ref/s7Nkfs2Tb6dxgAV NFgvcakSnXBDouVwkk5rI6NQSk+vUYim259FQOBa5wwGNUITZgqv9TLMyhDpgm+W6vQo EmnKRxtmWPanVDcNBmenaF8MgN+EO9IUU67JvBAuJdhwY/Ev0t09b4wSAbYsW0OjrTxw fu8gOVnqEEdADHtaL8Ye9vOa7OKqIkyo3jh1Y5fQjLI49008+/OVHDzT/WNYEoQPHY60 KEQ2l6Q0+4zQ33s0ykIHeiJaEXO1lYAR5icNcKiSJZ9t711Tytrn8aws1+2RhFUKs1B0 4kAQ== X-Gm-Message-State: APjAAAXlxY69zG7G7anjvT8KtHbAuOfqfw5VH/c4cAAzS8GVVDvM5PMb rqtHYpRZrJ+9fL4Z+1U7UPwFTw== X-Google-Smtp-Source: APXvYqw6b1dPONGXyDZ091PmKQQMQiEzkf8IfKM2jilfYkxTMC64L/Ku4inVi0PMMy4C6oG5BT9Sew== X-Received: by 2002:a17:906:5595:: with SMTP id y21mr14467518ejp.209.1553535213891; Mon, 25 Mar 2019 10:33:33 -0700 (PDT) Original-Received: from localhost ([134.226.214.210]) by smtp.gmail.com with ESMTPSA id j14sm5921955ede.46.2019.03.25.10.33.33 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 25 Mar 2019 10:33:33 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Mon, 25 Mar 2019 12:50:45 -0400") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::536 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234712 Archived-At: Stefan Monnier writes: >>> While looking into bug#34973, bug#34974, and bug#34987, I accumulated >>> the attached changes to lisp/gnus/gnus-dup.el which I would like to push >>> to master. WDYT? >> >> Given the games Gnus plays with bindings (see `defvoo' and `deffoo') the >> switch to lexical binding for gnus may prove to be complex. >> >> It would be better to avoid switching to lexical binding for a single >> file in gnus: rather, do that as part of a larger effort to switch all >> of gnus over to lexical binding. > > FWIW, I've been compiling Gnus using lexical-binding for many years now, > and it's the MUA I use to spam this mailing-list, so at least the main > "read&write messages" works fine for the nnimap and nntp backends. > > I think the def[fv]oo hacks don't get in the way of > lexical-binding at all. Thank you for sharing your experience; it's reassuring. -- Basil