From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Question about display engine Date: Wed, 4 Sep 2019 20:33:06 +0200 Message-ID: <87pnkfsyhx.fsf@Ergus.i-did-not-set--mail-host-address--so-tickle-me> References: <8acd9fc1-e6ce-9a86-cfb6-e00a672c154a@gmx.at> <20190901122628.aynhzwwpvqbgyydh@Ergus> <20190902110504.zniyfmd7bi53iyxe@Ergus> <83zhjm7juc.fsf@gnu.org> <4663e760-a611-6c29-e0e2-69bde9da87b1@gmx.at> <83tv9t77oq.fsf@gnu.org> <85658428-5253-6099-07b8-79831cf4e689@gmx.at> <83pnkh70d5.fsf@gnu.org> <81596d5c-427e-a95b-b66f-b571ac228ce1@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="33135"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: Eli Zaretskii , emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 04 20:33:59 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i5a6R-0008V1-3N for ged-emacs-devel@m.gmane.org; Wed, 04 Sep 2019 20:33:59 +0200 Original-Received: from localhost ([::1]:36254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5a6P-0000Xk-Vz for ged-emacs-devel@m.gmane.org; Wed, 04 Sep 2019 14:33:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59798) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5a5o-0000W0-BH for emacs-devel@gnu.org; Wed, 04 Sep 2019 14:33:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i5a5m-0005gc-Nn for emacs-devel@gnu.org; Wed, 04 Sep 2019 14:33:19 -0400 Original-Received: from sonic310-11.consmr.mail.ir2.yahoo.com ([77.238.177.32]:34245) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i5a5l-0005fL-5S for emacs-devel@gnu.org; Wed, 04 Sep 2019 14:33:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1567621995; bh=WE9ghz8Y3uwRsImEWscrOynv39Kq9wUo9EUGyccuNPs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=i0/zYhBOyVXLSJRLh9fOw7N2yuK6uRIp2vpM2RUsFMIlyW1Ek2UZRyreCE51Wx+XUrYFQIYnJaShL9t3Arg5L1tWa07UUCIfYCNJmYXehTXK/feRh8pRwPghI6XPDTlQCwf7V+edGiQhEXx+9Kxf5KvWryBOPjH8BznCy/q/Tzm9fh2cGpOCtOpLdGEa6iLG1VuNjaT8VfRd+U9lk6TYJEd7BbxUgJzr5lE4ZzMIjnCvk0kygJgh7fudBGyYEwXPYqvNxwfObUZmKzXdaAICy5kGp461rZ06lUSheTF59X7KGzizJPPFHmSTWm3rs4RjX00GVK+PB969R3exUNt1TQ== X-YMail-OSG: pqH6I6MVM1ni63izVTx52NtOI0qMdwCWdeVRfBVCvbrQAB2JM32DcNEEp.Xq3yB _rTt6aJ5C61EtRCGuT_z2aQGuYXRKrOJc1AkfesNpA0trRUNK9ULtbqmB1ONk6bPQUQH1Rv7X6DK 3MQsJmrZdgsvKl0LqNymMhvgCT.MhX1BYC672i1JdtwYb3woVnmS7oax4Z5WobzlbpCTycZkjdzK MCJryvWd6Yj9Ji7AOt2KTVkYutxn67fu8qBwaLoeI7Iqig.Z7gBxIKTzFYchVw3jfOgpbSbC5Tn6 NZOYtE.J_AxZgy72.SrxIQ5.0lkWXypBVo0lA0tXswTk6O2NrQVbMxWu94.dFn2VGJEh7GZw9pK9 nRj2yzT1vApOz9pUpE2y1YY_Oqxeitq9m2z8gC8fOIpmAhdoZ54IGXF2hfjN4kIoz3ZrDAH8wyY_ XiqMsXKZGZi6eoX5NQAXAvj2g0RGWvgyaZzYRjeTzyd7w6UIIXJ6RQnzEsIzUIybzA.ci66oxlQb u6cL_E8imMTh..FsThIP47YNR9wpRUT2ROuDAHJxLtLP2jz9JQmEpmAitH3B7bJIGPbYTjm3kxV0 POvfh22QUtKJU_UZkBJSDVrPbcjoOS2VfX7tCMouJX8jLwoSGiaK8AskFcxnIVP4JL6pyUoJ.tpH ZsorjjBRAMZiT_XWOIguVEPxXdpFQeYvLngxwERaitSYsciuW__JR.f25_xfOJp0wt_EWw.2Uo5h HyTTaprGKiQ39M34FQAxth8wO2rJ8MXaq98yma2LQBge53YQ303Qwd6v..OCMWzZtDlA4XIfHjqG Jfp0vv2x2imFOUpVUMtosfG3VdqjDFWSDalRik9HqM Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Wed, 4 Sep 2019 18:33:15 +0000 Original-Received: by smtp428.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID bf4181e11b41eb14e172bb153dc62ac3; Wed, 04 Sep 2019 18:33:14 +0000 (UTC) Content-Disposition: inline In-Reply-To: <81596d5c-427e-a95b-b66f-b571ac228ce1@gmx.at> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.177.32 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239843 Archived-At: Hi: I have just uploaded some changes but the functionality is still not working. I separated the changes in 3 commits and in the last one are only the ones I made in the xdisp.c (the ones that need to be checked, because the rest is only infrastructure.) see the master branch in: https://github.com/Ergus/Emacs But at this point I will need some extra comments about what I am doing wrong there. Ir if I am doing anything right. The extend now is working like always (testing for the region). In principle the region is the only face I have added :extend t But when I set it to nil it should be not extended and it is; so some extra condition is still missing.. The filter if condition (to merge or not) is a new macro FACE_EXTENSIBLE_P (face). So please any hint is very welcome now. On Tue, Sep 03, 2019 at 08:59:33PM +0200, martin rudalics wrote: >> I don't think it's expensive enough to justify such premature >> optimization. > >Earlier you preferred a lazy variant because > >> it scales better, because the >> display code is frequently invoked on short portions of the text, so >> there's no guarantee that it will actually get to producing glyphs >> with the "extension" variant of the face, so realizing that face in >> advance might well be waste of unneeded effort, because the additional >> face will never be used. > >Either way, let's see what Ergus comes up with. > >martin >