unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: master c59e878: Inhibit modification hooks when saving eieio-persistent's
Date: Mon, 04 May 2020 14:42:05 -0700	[thread overview]
Message-ID: <87pnbjwf6a.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <871rnz8jsh.fsf@web.de> (Michael Heerdegen's message of "Mon, 04 May 2020 23:36:14 +0200")

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> ;; With modification hooks uninhibited (ie, reverting Michael's commit).
>> (benchmark-run 100 (my-save-registry)) -> (1028.64836554 2801
>> 537.1068782020001)
>> (benchmark-run 100 (my-save-ebdb)) -> (51.585404029 134 20.779424303000003)
>>
>> ;; With modification hooks inhibited (Emacs master).
>> (benchmark-run 100 (my-save-registry)) -> (989.206686569 2800 526.325465032)
>> (benchmark-run 100 (my-save-ebdb)) -> (63.946958194 127 23.392065172000002)
>
> `my-save-ebdb' is slower with modification hooks inhibited?

That's why this took me so long, I decided I was confused and re-ran the
tests all over again.

Also I forgot to note:

My before-change-functions: (org-indent-notify-modified-headline org-before-change-function t syntax-ppss-flush-cache)

My after-change-functions: (jit-lock-after-change flyspell-after-change-function org-indent-refresh-maybe t)



  reply	other threads:[~2020-05-04 21:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200501192115.23847.67499@vcs0.savannah.gnu.org>
     [not found] ` <20200501192116.A55EE20B5B@vcs0.savannah.gnu.org>
2020-05-01 21:01   ` master c59e878: Inhibit modification hooks when saving eieio-persistent's Stefan Monnier
2020-05-01 21:45     ` Michael Heerdegen
2020-05-01 22:03       ` Stefan Monnier
2020-05-01 22:24         ` Michael Heerdegen
2020-05-01 22:40           ` Stefan Monnier
2020-05-01 23:30             ` Michael Heerdegen
2020-05-02 13:26               ` Stefan Monnier
2020-05-02 21:08                 ` Michael Heerdegen
2020-05-02 22:09                   ` Stefan Monnier
2020-05-03  2:44                     ` Michael Heerdegen
2020-05-03  4:01                       ` Stefan Monnier
2020-05-03  5:13                         ` Michael Heerdegen
2020-05-04 21:09                           ` Eric Abrahamsen
2020-05-04 21:36                             ` Michael Heerdegen
2020-05-04 21:42                               ` Eric Abrahamsen [this message]
2020-05-02  4:24             ` Michael Heerdegen
2020-05-02  0:03     ` Eric Abrahamsen
2020-05-02  0:22       ` Michael Heerdegen
2020-05-02 13:32       ` Stefan Monnier
2020-05-02 18:18         ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnbjwf6a.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=emacs-devel@gnu.org \
    --cc=michael_heerdegen@web.de \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).