From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Bastien Newsgroups: gmane.emacs.devel Subject: Re: GNU ELPA package discoverability Date: Mon, 01 Jun 2020 11:26:23 +0200 Organization: GNU Message-ID: <87pnajrvb4.fsf@bzg.fr> References: <4e937898-ae46-710a-cbca-e452a1156fa1@yandex.ru> <2e630dc7-ba1d-e4c9-74b3-4da976db1e82@yandex.ru> <87imglg51l.fsf@gnu.org> <83d06txuv4.fsf@gnu.org> <871rn9l35o.fsf@gnu.org> <83tv05waob.fsf@gnu.org> <874ks5gtca.fsf@gnu.org> <87h7w4oh5x.fsf@sachachua.com> <87o8qclael.fsf@gnu.org> <877dwzo1nm.fsf@sachachua.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="95190"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) Cc: Eli Zaretskii , rms@gnu.org, Emacs-devel@gnu.org To: Sacha Chua Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 01 11:27:09 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jfgip-000OiZ-SC for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Jun 2020 11:27:07 +0200 Original-Received: from localhost ([::1]:34454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfgio-0001S7-TY for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Jun 2020 05:27:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfgiN-00012J-SV for Emacs-devel@gnu.org; Mon, 01 Jun 2020 05:26:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44667) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfgiN-0005en-FW; Mon, 01 Jun 2020 05:26:39 -0400 Original-Received: from [2a01:e35:2fe1:f780:a886:3d11:7807:868b] (port=36300 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1jfgi9-00029x-OM; Mon, 01 Jun 2020 05:26:26 -0400 Original-Received: by guerry (Postfix, from userid 1000) id 9A0A01A603C1; Mon, 1 Jun 2020 11:26:23 +0200 (CEST) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251723 Archived-At: --=-=-= Content-Type: text/plain Hi Sacha, thanks for the feedback! Sacha Chua writes: > Oh, Tools makes sense too. Okay. > Hmm... What if the submenu has: > > - Manage package sources <-- move this one first? I agree this is better (more explicit) than "Manage package archives". > - Choose packages I'd rather go for "List available packages" as "Choose packages" feels like the user has to do something with the listed packages while "List available packages" feels more factual. But not a big deal, both are good. > - Customize the package interface As Dmitry said, maybe this one is not really needed. > - ... Maybe that help link? I'm not sure here -- maybe we can modify the help menu in another patch? I've updated my patch to modify the menu according to the suggestion above. Eli, let me know if I can apply it against master. Thanks, -- Bastien --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=menu-bar.el.patch diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el index 9bc667acd6..6340af08e9 100644 --- a/lisp/menu-bar.el +++ b/lisp/menu-bar.el @@ -1414,10 +1414,6 @@ menu-bar-options-menu (bindings--define-key menu [customize] `(menu-item "Customize Emacs" ,menu-bar-custom-menu)) - (bindings--define-key menu [package] - '(menu-item "Manage Emacs Packages" package-list-packages - :help "Install or uninstall additional Emacs packages")) - (bindings--define-key menu [save] '(menu-item "Save Options" menu-bar-options-save :help "Save options set from the menu above")) @@ -1682,6 +1678,18 @@ menu-bar-shell-commands-menu menu)) +(defvar menu-bar-package-menu + (let ((menu (make-sparse-keymap "Manage Emacs Packages"))) + (bindings--define-key menu [customize-package-archives] + '(menu-item "Customize package sources" + (lambda () (interactive) (customize-variable 'package-archives)) + :help "Set the list of Emacs package sources")) + (bindings--define-key menu [list-packages] + '(menu-item "List available packages" list-packages + :help "Browse a list of Emacs packages")) + + menu)) + (defun menu-bar-read-mail () "Read mail using `read-mail-command'." (interactive) @@ -1716,6 +1724,13 @@ menu-bar-tools-menu (bindings--define-key menu [separator-net] menu-bar-separator) + (bindings--define-key menu [package] + `(menu-item "Manage Emacs Packages" + ,menu-bar-package-menu)) + + (bindings--define-key menu [separator-package] + menu-bar-separator) + (bindings--define-key menu [browse-web] '(menu-item "Browse the Web..." browse-web)) (bindings--define-key menu [directory-search] --=-=-=--