From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= Newsgroups: gmane.emacs.devel Subject: Re: git-send-email Date: Mon, 15 Jun 2020 17:38:23 +0200 Message-ID: <87pna05ogg.fsf@gmail.com> References: <875zdteybt.fsf@runbox.com> <87368wrvf5.fsf@yahoo.com> <86k126d83n.wl-me@enzu.ru> <83pnbyckvv.fsf@gnu.org> <4923d7e98f5ed816a7569093dbc673153adcea88.camel@yandex.ru> <837dwb3zb6.fsf@gnu.org> <20200613141653.GA55972@breton.holly.idiocy.org> <835zbv3v6q.fsf@gnu.org> <20200613142329.GA56313@breton.holly.idiocy.org> <834krf3uij.fsf@gnu.org> <87r1ujatv4.fsf@igel.home> <831rmj3stn.fsf@gnu.org> <87mu57atav.fsf@igel.home> <87lfkpcn6t.fsf_-_@gmail.com> <83d0612gx3.fsf@gnu.org> <878sgobuvf.fsf@gmail.com> <837dw82xwd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="22743"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: schwab@linux-m68k.org, alan@idiocy.org, hi-angel@yandex.ru, stefan@marxist.se, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 15 17:39:00 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jkrCN-0005mk-J8 for ged-emacs-devel@m.gmane-mx.org; Mon, 15 Jun 2020 17:38:59 +0200 Original-Received: from localhost ([::1]:48532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkrCM-0005vm-KH for ged-emacs-devel@m.gmane-mx.org; Mon, 15 Jun 2020 11:38:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkrBt-0005WR-51 for emacs-devel@gnu.org; Mon, 15 Jun 2020 11:38:29 -0400 Original-Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:51435) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jkrBr-0004uS-4K; Mon, 15 Jun 2020 11:38:28 -0400 Original-Received: by mail-wm1-x344.google.com with SMTP id b82so36981wmb.1; Mon, 15 Jun 2020 08:38:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=QuZUATc09MVly5l1MULKNfI113hh67fqVqTVxx3T0lw=; b=rddVpFzewTvmHCzpi9b089Uc22X2WDV9JvMrWrDypEnGafRzer2VaQZQSjaRdEdtpo +Fzv5XlY5HOeMdAinIhScqrr1aDIRQVqDvlUmtxvQ4DCIkDalf1C49PzT0T9efH8+xNy nPhoYqOJY4bErMvKg1pUAho8H3/bCOWNoIzPLYbYFFyDLz9t5OdlMVEnn+4ey7Bra3/u 65hauh5J1nURCS25RILMJxrO2Nx7L1GEFx3VMhqAPeQAVDpb2yKI0H0ANfZam636yl+o 5IM7ue3ppxE7DChb96DhgAk24Mojv/OTZOldCgiHM/0yjCf7Qj5TORIE6C1rzy5wx4gb ulmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=QuZUATc09MVly5l1MULKNfI113hh67fqVqTVxx3T0lw=; b=r1TUXfXdGnLU0WQ6+Py3LsxNrJlekVQ0jJP7e7LIPTBtolkzLICX+KaYOpYQ8fmiwx 5IHd3IrHf+Q9l7x524Mnp9ZilTR4jlgGh6CcxomtSNDL/kM9F7Sy/NcsRt9TTZ0H1nWP 1kMUTPCG+Ef1gPLjT3w0l6mbMr8UluYG35ndN+gQ0njHYjFktmyDlj5hmyISIE+LO06r xu2tGs6sCtGhzVbsN5C27r16MgoRlYD48G9PZpXoJktpceQuJmR1LbSojAjNXWLrUEIy IP6vUM0aKcwOXIfh5dafo8uaEhL4xH9EjcMacyNJaR9tQHVM8IuIevLBOAlTQTjlE/S9 DGGQ== X-Gm-Message-State: AOAM533/hLnczCNxotksM+IvMSyNsgFpY0G5IcpoCybn0onHNfXS6cjJ Wy3fvSOGSeIYwVuC3bdTzTc= X-Google-Smtp-Source: ABdhPJy0tpQMlwRraGDCJoGvOBpIym0DKyXKTo1Z5X6YhxLnUQhqcWkfaD5vi/a42PnEoEvcZ9iUeg== X-Received: by 2002:a1c:b445:: with SMTP id d66mr13337499wmf.29.1592235504883; Mon, 15 Jun 2020 08:38:24 -0700 (PDT) Original-Received: from klegouguec-HP-ProBook-450-G1 (200.143.13.109.rev.sfr.net. [109.13.143.200]) by smtp.gmail.com with ESMTPSA id y19sm21934059wmi.6.2020.06.15.08.38.23 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Jun 2020 08:38:23 -0700 (PDT) In-Reply-To: <837dw82xwd.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 15 Jun 2020 17:42:42 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::344; envelope-from=kevin.legouguec@gmail.com; helo=mail-wm1-x344.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252273 Archived-At: Eli Zaretskii writes: > You need to look at this from the right vantage point: the POV of me > (or someone else) who needs to install changes in such an email. I'm > on the receiving end of the email, so I have no idea what command(s) > were used to create and send it. All I see is a random email message, > not unlike many others, just with diffs in its body. You suggest to > pipe it into Git, but how do I know it's in a proper format to be > processed correctly by Git? There's no clue. Thank you for taking the time to spell out how messages produced by git-send-email can be challenging to distinguish from handcrafted submissions. Indeed, I agree that it's not uncommon for contributors to send emails with "[PATCH]" in the subject and the diff appended at the end; it would be unreasonable to ask maintainers to be able to guess how the message was produced just by eyeballing it. Likewise, it would be unreasonable to ask maintainers to pipe random messages to git-am to find out if they have been produced by git-send-email; when I said: > - for maintainers, no need to scan the mail for attachments; just pipe > the mail itself to git am. I really meant "*when maintainers know the mail has been produced by git-send-email*, there is no need to scan it for attachments; just pipe it straight to git-am". FWIW, git-send-email adds a pretty explicit header[1] to inform recipients of how the message was produced. > Do you see now why we prefer the latter? And it isn't like Emacs is > the only project; many GNU projects also prefer to have patches > submitted in this format. I'm certainly not as well-versed in email mishaps as GNU maintainers, so I'll trust you when you say that attachments fare better than message bodies vs. the many transit/encoding problems you've listed. OTOH I also see that projects working with git-send-email seem to be none worse for the wear[2]. [1] X-Mailer: git-send-email [VERSION] [2] Save for some the occasional "some mail service forbids arbitrary header fields" shenanigans: https://lists.sr.ht/~sircmpwn/sr.ht-discuss/%3CCACFas%3DMug5JOOCZJPjucyb+km_21EK2hoxkFCWgLMtu3thztXQ%40mail.gmail.com%3E