From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: Add new functions to mark/unmark/delete all bookmarks Date: Sun, 02 Aug 2020 17:13:50 -0500 Message-ID: <87pn88lmqp.fsf@red-bean.com> References: <20200724005105.11f85d5f@pineapple> <87pn8ku3y9.fsf@red-bean.com> <20200725124618.49a073b1@pineapple> <87o8nyvufq.fsf@red-bean.com> <20200731045809.4587b13d@pineapple> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24730"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Matthew White Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 03 00:14:33 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2MFV-0006Kj-J7 for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Aug 2020 00:14:33 +0200 Original-Received: from localhost ([::1]:55836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2MFU-0004le-LW for ged-emacs-devel@m.gmane-mx.org; Sun, 02 Aug 2020 18:14:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2MEy-0004JM-LS for emacs-devel@gnu.org; Sun, 02 Aug 2020 18:14:00 -0400 Original-Received: from newsp.red-bean.com ([45.79.25.59]:46966 helo=sanpietro.red-bean.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2MEw-0004OC-NQ for emacs-devel@gnu.org; Sun, 02 Aug 2020 18:14:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:Reply-To:References:Subject:Cc:To:From:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mT9a+AqMSYrSPNPHezRjcWS/M0nH02WUt9i9aj7n/rg=; t=1596406438; x=1597616038; b=IHSeyS+thiTxjVCCUpHuFlMf0G9J/mFgeZfmKqMn2ap0vQIUSu2uLZWNWScJWYtxJavDYrH7oT V23bvSbt4QLpT3QMdDa1SKFYdx6PUUTpEI6cxiPNVXCGcf8TswKCLMOmxFgDq6zBwyCN3MYQk1gWK 9VUv7T7AlV5pe6WMJxEUsaS7n0W9LYL16CDkP3JYHVaXyjWR8NOSzq0etNTeUZm18Hz1uew+2LvZM hHR+SrD0nm1ItM31nJ9ZSw6qngxULHlsanE4ITowjSH19ALCk2iiUSCdfjnwNHtNsJ8pVnXMJxY5S dwjDxIdJc46fQipq1Yl+EEZwgvCnICv/f6dng==; Original-Received: from 99-112-125-163.lightspeed.cicril.sbcglobal.net ([99.112.125.163]:45302 helo=floss) by sanpietro.red-bean.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2MEt-0001Or-QJ; Sun, 02 Aug 2020 22:13:55 +0000 In-Reply-To: <20200731045809.4587b13d@pineapple> (Matthew White's message of "Fri, 31 Jul 2020 04:58:09 +0200") Received-SPF: pass client-ip=45.79.25.59; envelope-from=kfogel@red-bean.com; helo=sanpietro.red-bean.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/02 18:13:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253407 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable I wrote: >I will try again with the new the 'master' patch (both manual testing >and 'make check'). I'll also do a top-to-bottom review again of the >diff, just so we can be sure. Hi, Matthew. I have had a chance to test the new changes against the 'mast= er' branch, both manually and with 'make check'. Everything looks good. I also re-reviewed the diff. Actually, I diffed the *new* diff against you= r original diff from July 24th, since I'd already reviewed that one, and th= en I just reviewed the meta-diff :-). Everything seems fine. I see that i= n the tests you add some hyphens to bookmark names, e.g., "name0" to "name-= 0" (no problem). You also started using the existing `bookmark-bmenu-any-m= arks' in the tests -- good thinking; I had forgotten that that function exi= sted. There is one very minor thing that I should have spotted before. It is so = minor that there is no need to post a new patch -- I can just add a fixup c= ommit after applying your commit. In the new function `bookmark-delete-all= ', the doc string says: "Permanently delete all bookmarks. Doesn't ask for confirmation if NO-CONFIRM is non-nil." A more Emacs-y way to write this would be: "Permanently delete all bookmarks. If optional argument NO-CONFIRM is non-nil, don't ask for confirmation." There are actually several changes there: - Say that the argument is optional. - Put the condition before the consequence. - Use an active verb rather than a semi-stative one ("don't" instead of "doesn't"). You did this in the first sentence ("delete all bookmarks"), just not in the second. For more on doc strings, see https://www.gnu.org/software/emacs/manual/html_node/elisp/Documentation= -Tips.html . =20=20=20=20 Again, there is no need to redo the patch (unless you feel like it). We ca= n take care of it in a follow-up commit. Please let us know when your paperwork is all done. I'm looking forward to= having this change in Emacs. Best regards, =2DKarl --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEsgfAWXyjn8Fyi3xbCKC3XMXtg0UFAl8nOp4UHGtmb2dlbEBy ZWQtYmVhbi5jb20ACgkQCKC3XMXtg0UCphAAtG2Q9i+FU0OX717scqg05esWyhFS 31cqbSm5coTKvDVrScYxhUtmOtHzSCGXN4xJ4tmuHs0JkRX82Oi4oyab116lkGp2 s0r5xofGRMQkAR5NjOOBrgVgC/rr7jVkZdNz5O+jc0IVUqq4Gz13jkIkmLfPLuDp vlhOwxUYK34sy9SbPlL1Nj+puRbHoXq0Cm+xW/Fi6AY3uFvxEI5vy2xAEBIdDdSX Uxo4vBVjfQEF9zOle1gkXiBRFcUgiJV3BAq1JJgmleDoqjr3QVZlWBy4pDSMJJrF JND90DGKCmf2y905rGpy3p/HyK0/zeghdt94goi5Hz2U6KmeFNeREK/aPbkkxHQt n1ungmQ1XJVXbzSYXnraufxwxdkDFkZZx3B05PdSim/eI8idJ8tcLhsYecxEHgOK cirU9FhvJuz3Bz3Ib0B51Uiiqq8k2Y94c1diiAiWoAyOg5D7h/QrdHQr47TkIBUZ B5a5o+VJMeBZWcHXLWQoKdN2LAhztxC5OL8SScUGD2FfEA5x08DeAoH0Ik4Fzqk4 /zhgg2gXZnELIpzbUV/0o6ORYzSmWB8HE04+oDRM0TEho3Ll0b+0zLndkuOJpMJo KHBhrnXNOx+GVE1XnWeWpVMnSyfvsuih4YPOQL0c81BYDhzxjunHZRv+sFNgctiw eQABsogJHnX7xac= =hGxD -----END PGP SIGNATURE----- --=-=-=--