From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 3de31e7: Fix compilation of image.c on MS-Windows Date: Mon, 09 Nov 2020 17:04:29 +0100 Message-ID: <87pn4mjz3m.fsf@gnus.org> References: <20201109153652.21064.52372@vcs0.savannah.gnu.org> <20201109153654.3EADA20A27@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2390"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 09 17:05:34 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kc9fg-0000Ti-JE for ged-emacs-devel@m.gmane-mx.org; Mon, 09 Nov 2020 17:05:32 +0100 Original-Received: from localhost ([::1]:58482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kc9ff-0001zD-Lv for ged-emacs-devel@m.gmane-mx.org; Mon, 09 Nov 2020 11:05:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42342) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kc9er-0001Tw-4s for emacs-devel@gnu.org; Mon, 09 Nov 2020 11:04:42 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:33176) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kc9en-0001Wu-EG; Mon, 09 Nov 2020 11:04:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=OKRVph7GV/g3F6saofgbaP8fjDBndTGI4MGXW6jeHyI=; b=R4q9Dq+iL/rVLPRNnZQcW1xEEu Q8z0ebmSQqHWHcDu2g8Kb73Hi6UyCodA7vt8QmSK9wKDKwOiuXhrT4Ecp0zHGRS5QouhfYpOo5ySA f3hS2TaLYS4sN4yxxpvTStB1NvKl88V0/FMICfG3rro+2eZlNRw0cqfRoHgN4Nhh1gVs=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kc9eg-0007iI-V1; Mon, 09 Nov 2020 17:04:33 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEUHBgYtIxlaRDGj PSampo/////eOq0WAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+QLCRAEA6qaumEAAAHBSURBVDjLfZSJ dcMgDIahEyCcAYLQALHEAgHtP1PF5TSvaeX3fPD512Vk5z4buP/MR4yICMkOAB8BwlzP0kSKyjDu pzQVxwBNFslH/Ql0gzPmD4CFGVUvIC8Fn9QwraTyD9DvFrBU+S9gdoGi+A50CxTzR2AK+QSKKr8p SPPsR6l5AdINEIVJeQenOsA4I5bSkN8UG8gFbppid9WX2QBvYKuwFRm12M3zBUjrVFBX1A2ildFB ZpRcUTZIQKo6g8NRIU/Qn16AMsf2G7BVKbcFvAewGKpkJWP6ylR3jBjxbmmRLR+j1gm+zFWXPGPK nKxhxBvEsCo3YJW0FcO2JDjolasVKHgruoLD/FA42whUrgLHuhFrBwBT2enCaK7qab2h0mOs7gI9 J0jJMsKoOMeGUnkCGHj4ZImHyEtBUB4QO3AQfHB+7xJzFoZC0t05Dg6ODexN18H5sHfs6VJ0U21a AdppgVYdw1nqaaWYQhQDes0tJGoqAOnwcuZLATn4vnUR78dh01kW8ChxTHGlBxg+5NyuxKcxGnhD kVzaY85mChJ8n8PSukPr1VSAF7kPMCexF3Sl238e9rlsW/Rr+O/P8w3znopwZhnFrAAAACV0RVh0 ZGF0ZTpjcmVhdGUAMjAyMC0xMS0wOVQxNjowNDowMyswMDowMGaLV34AAAAldEVYdGRhdGU6bW9k aWZ5ADIwMjAtMTEtMDlUMTY6MDQ6MDMrMDA6MDAX1u/CAAAAAElFTkSuQmCC X-Now-Playing: Irreversible Entanglements's _Irreversible Entanglements_: "Chicago To Texas" In-Reply-To: <20201109153654.3EADA20A27@vcs0.savannah.gnu.org> (Eli Zaretskii's message of "Mon, 9 Nov 2020 10:36:53 -0500 (EST)") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258949 Archived-At: eliz@gnu.org (Eli Zaretskii) writes: > Fix compilation of image.c on MS-Windows > > This is a followup to last change in image.c. > * src/image.c (rsvg_handle_get_intrinsic_dimensions): Define to > call fn_rsvg_handle_get_intrinsic_dimensions. > (svg_css_length_to_pixels): Compile only for librsvg >=3D 2.46.0, as > RsvgLength type was not defined before. This leads to the following warnings on Debian bullseye, apparently: image.c: In function =E2=80=98svg_css_length_to_pixels=E2=80=99: image.c:9769:13: warning: this statement may fall through [-Wimplicit-fallt= hrough=3D] 9769 | value =3D dpi * value / 2.54; | ~~~~~~^~~~~~~~~~~~~~~~~~~~ image.c:9770:5: note: here 9770 | case RSVG_UNIT_MM: | ^~~~ image.c:9776:13: warning: this statement may fall through [-Wimplicit-fallt= hrough=3D] 9776 | value =3D dpi * value / 72; | ~~~~~~^~~~~~~~~~~~~~~~~~ image.c:9777:5: note: here 9777 | case RSVG_UNIT_PC: | ^~~~ image.c:9779:13: warning: this statement may fall through [-Wimplicit-fallt= hrough=3D] 9779 | value =3D dpi * value / 6; | ~~~~~~^~~~~~~~~~~~~~~~~ image.c:9780:5: note: here 9780 | case RSVG_UNIT_IN: | ^~~~ --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no