From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.devel Subject: Re: feature/native-comp c36b4ee 2/2: [TODO] Remove noisy anti-noise feature Date: Wed, 18 Nov 2020 18:10:33 +0100 Message-ID: <87pn4abng6.fsf@bernoul.li> References: <20201118142127.27797.43745@vcs0.savannah.gnu.org> <20201118142128.E137D20D1E@vcs0.savannah.gnu.org> <87r1oqlmoj.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36041"; mail-complaints-to="usenet@ciao.gmane.io" To: Robert Pluim , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 18 18:20:47 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kfR8Q-0009G9-F4 for ged-emacs-devel@m.gmane-mx.org; Wed, 18 Nov 2020 18:20:46 +0100 Original-Received: from localhost ([::1]:51554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfR8P-0007ek-9w for ged-emacs-devel@m.gmane-mx.org; Wed, 18 Nov 2020 12:20:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfQye-0006uE-Sn for emacs-devel@gnu.org; Wed, 18 Nov 2020 12:10:40 -0500 Original-Received: from mail.hostpark.net ([212.243.197.30]:36492) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfQyc-0000uo-Pk for emacs-devel@gnu.org; Wed, 18 Nov 2020 12:10:40 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id E5013160CB; Wed, 18 Nov 2020 18:10:33 +0100 (CET) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id YqQ9MWXF0Bm3; Wed, 18 Nov 2020 18:10:33 +0100 (CET) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id B1EE1160C3; Wed, 18 Nov 2020 18:10:33 +0100 (CET) In-Reply-To: <87r1oqlmoj.fsf@gmail.com> Received-SPF: none client-ip=212.243.197.30; envelope-from=jonas@bernoul.li; helo=mail.hostpark.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/18 12:10:34 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259361 Archived-At: Robert Pluim writes: > jonas@bernoul.li (Jonas Bernoulli) writes: > >> branch: feature/native-comp >> commit c36b4eed2d76f0e804d27d35dd6281f858639f94 >> Author: Jonas Bernoulli >> Commit: Jonas Bernoulli >> >> [TODO] Remove noisy anti-noise feature >> --- >> lisp/emacs-lisp/warnings.el | 11 ----------- >> 1 file changed, 11 deletions(-) >> > > Everyone is allowed to have an opinion on this feature, but just > removing it without discussion seems a little harsh. > > Robert That was an accidental push. I do think it would be best to remove this new feature completely, but of course I would have raised the issue before *intentionally* removing it. This is why I think this is not a good feature: People will make use of it. Longer version: Of course it is nice for users who don't know any elisp to opt-out of seeing warnings that they cannot understand, but I fear that users who could contribute by addressing these issues or by at least reporting them, will opt-out as well. Even some package authors are going to enable this, possibly because they misunderstand what it does. I did that for example. I thought it would disable "that particular" warning; not all of them. I then had to figure out how to revert that setting, there wasn't any button for that. Also in some contexts the buttons cause the actual warning message to be truncated. For example lazy native compilation shows only the first line of each warning and if a third of that line is used up by the buttons that are the same for each and every warning, that can turn a sufficiently informative warning into guess work. I am involved in an uphill battle, fixing the endless stream of compile warnings for the packages that are installed on my system. It would be nice if more people did that. Yes, these warning are a bit annoying but the underlying issues are not going away if we make it easier to ignore them. I don't use package.el and don't know what happens if there are warnings during package installation. If the problem is that noobs get confused because a buffer pops up with warnings that they don't understand, then we could prevent that buffer from poping up by default. Going further than that seems like an own goal. Jonas