From: "Štěpán Němec" <stepnem@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Calling internal-default-process-sentinel from another sentinel?
Date: Wed, 18 Nov 2020 15:37:48 +0100 [thread overview]
Message-ID: <87pn4a688z.fsf@gmail.com> (raw)
In-Reply-To: <jwvv9e2bvhl.fsf-monnier+emacs@gnu.org>
On Wed, 18 Nov 2020 09:19:36 -0500
Stefan Monnier wrote:
>> Such a use case doesn't seem uncommon and simply calling
>> 'internal-default-process-sentinel' from a custom sentinel would seem a
>> good solution, but the "internal-" prefix or the fact that such usage is
>> completely absent from Emacs core and very rare even in 3rd party
>> code[1] don't inspire confidence.
>
> `add-function` is your friend.
>
> (add-function :around (process-sentinel proc)
> (lambda (orig-fun proc state)
> (if (one particular case)
> (do the thing)
> (funcall orig-fun proc state))))
Thanks, I've seen similar examples in the code base, but always advising
an Elisp sentinel, not 'internal-default-process-sentinel', which is a C
function, and IIUC also would/might be called from C (e.g. from
status_notify ?). Or is the actual default sentinel some kind of a
wrapper?
And even for Elisp sentinels, I figured I'd rather avoid advice, as even
when using a self-removing piece of advice, it still applies to all
(even unrelated) calls of the same sentinel function occurring until the
removal. Or am I missing something?
--
Štěpán
next prev parent reply other threads:[~2020-11-18 14:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 13:28 Calling internal-default-process-sentinel from another sentinel? Štěpán Němec
2020-11-18 14:19 ` Stefan Monnier
2020-11-18 14:37 ` Štěpán Němec [this message]
2020-11-18 14:44 ` Stefan Monnier
2020-11-18 15:12 ` Štěpán Němec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn4a688z.fsf@gmail.com \
--to=stepnem@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).