From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: feature/completions-highlight-modifications e3c5b99 3/6: Add completions-highlight-mode initial implementation. Date: Mon, 23 Nov 2020 11:14:47 +0200 Organization: LINKOV.NET Message-ID: <87pn44juyg.fsf@mail.linkov.net> References: <92f3cbd7-29a0-461a-a023-562bc6020ea8@default> <87v9e5herj.fsf@mail.linkov.net> <20201116102729.ywubtda6cqdzc45z@Ergus> <87d00acuh3.fsf@mail.linkov.net> <20201119032519.lpa53ixezgpdppze@Ergus> <87d009kfmf.fsf@mail.linkov.net> <20201119105052.kfichqojkhfwwsiz@Ergus> <87k0ugfirt.fsf@mail.linkov.net> <20201120145248.wmbv2zgbvs7bg25i@Ergus> <871rgmwt6e.fsf@mail.linkov.net> <20201122230956.mai3i6ckqymzvyvb@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23348"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Stefan Monnier , Drew Adams , emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 23 10:49:56 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kh8Ts-0005z5-DD for ged-emacs-devel@m.gmane-mx.org; Mon, 23 Nov 2020 10:49:56 +0100 Original-Received: from localhost ([::1]:45608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kh8Tr-0002ZV-Ex for ged-emacs-devel@m.gmane-mx.org; Mon, 23 Nov 2020 04:49:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kh8Qu-00081C-E8 for emacs-devel@gnu.org; Mon, 23 Nov 2020 04:46:52 -0500 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:34353) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kh8Qr-000168-UX for emacs-devel@gnu.org; Mon, 23 Nov 2020 04:46:52 -0500 X-Originating-IP: 91.129.105.28 Original-Received: from mail.gandi.net (m91-129-105-28.cust.tele2.ee [91.129.105.28]) (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id C0037C0022; Mon, 23 Nov 2020 09:46:44 +0000 (UTC) In-Reply-To: <20201122230956.mai3i6ckqymzvyvb@Ergus> (Ergus's message of "Mon, 23 Nov 2020 00:09:56 +0100") Received-SPF: pass client-ip=217.70.183.198; envelope-from=juri@linkov.net; helo=relay6-d.mail.gandi.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259674 Archived-At: > Could you try it now please? Thanks, now this feature is getting into good shape, and it seems soon your branch will be ready for merging. > I am wondering that with this new behavior it is a bit more like zsh but > diverges a bit too much from the current default emacs completion, so > making this default will be virtually impossible. And my real objective > was to improve the default completion; not make a new one. Don't hold out too much hope on enabling this feature by default. Even in zsh this completion style is not enabled by default, only adding "zstyle ':completion:*' menu select" enables it. Also in Emacs even less intrusive icomplete-mode is not enabled by default. For example, currently when the completions buffer is displayed, C-r is still available for searching through the previous history. But when this new mode is enabled, it's more useful to allow C-r to search in the completions buffer, that works well with your latest commit. IOW, the main difference of this feature is that typing TAB enables a special mode for selecting a completion, and disables history navigation and motion keys in the minibuffer. > IMO we may reconsider if we should go in the direction of commit > 60a1003aee or in the one of c7c47e78e6. Yes, these are two diverging roads. So we need to try both, identify their advantages/disadvantages to decide what path/patch to follow. With c7c47e78e6, all present motion keys are still available in the completions buffer, but are all keys that used to exit still handled? Also setting buffer-local cursor-in-echo-area to t in the completions buffer provides a better look and feel of editing in the minibuffer (like you disabled mode-line).