From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master a0f6029: Fix misuses of `byte-compile-macro-environment` Date: Thu, 04 Mar 2021 13:38:16 +0000 Message-ID: <87pn0frqd3.fsf@tcd.ie> References: <20210301171853.8051.45984@vcs0.savannah.gnu.org> <20210301171854.C42CB20E1B@vcs0.savannah.gnu.org> <87h7lsthzh.fsf@tcd.ie> <87blbzd70v.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22431"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 04 14:39:18 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHoCE-0005hN-DS for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 14:39:18 +0100 Original-Received: from localhost ([::1]:49458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHoCD-0008V2-Bw for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 08:39:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHoBL-000841-MU for emacs-devel@gnu.org; Thu, 04 Mar 2021 08:38:23 -0500 Original-Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:41380) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHoBJ-0000lS-01 for emacs-devel@gnu.org; Thu, 04 Mar 2021 08:38:23 -0500 Original-Received: by mail-wr1-x42d.google.com with SMTP id f12so23886852wrx.8 for ; Thu, 04 Mar 2021 05:38:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=vylNB4Y9RjovjnRe8fu1/qg8tVtRiTrZqjp0aacHv/o=; b=HH86Ophg8kt8TT5oepCC8TiFhfz4GEKktW7BLlO8ZpsBPkPmjLsqun9aenw8nh8U3D 3dgZDg3mZjWfzZunMt045VIana/L8vJj0F7oeBqBahejXbQMWlkCi5IqRgD6F6i6Kbee lnNOaOMlVuJWVq75aWEsXuhgQRANnRbU6BcYnEw45/FHnZROgh1w7pXUs25dmdL1RI3Y D9bINN4z0sBB6OlW7hjNJmvS4o80dNZPlJmOX45fXnrUYzUP+NzaYfkE+xeB3gsNR90g BfL+M2Bqb1xCn/5eY2BZEhPVCyasCDh0rMoBk3lymYqQ8JmpBxV/n7OMQ1dIYI2q9oGi FRYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=vylNB4Y9RjovjnRe8fu1/qg8tVtRiTrZqjp0aacHv/o=; b=e3FfvsOjvA4FKXr+b6DgR3AkH5Kd6mvliL1vvZtUeJoWn4GIi2ZAS/D5cKfM6Lq0IU RYaVMqiLKI0sCCrCKsx/aI0pN5m2tOP+EvxMhBZ29wTJFcNLwdH/5fNky3n5lV3iC5jl JGBwkHNqmCkaAkfBqe2JwRjC3dEj12mPH00AxXy5shLWZpeBK6y7lx8eeQvNLfvlySw/ hqM/8FodZn07sPyWhcO18weMh9gjLqS48SfmFNZoZfWAQfKl9M6BARckoHW8K4DfkEU/ h5rAplVs9Mh7FGJWPRFVJ8+9azTBxt4vZrpNLfu4n5g/R+HzvSeEKz5/toDAa8+RFAe3 g/mQ== X-Gm-Message-State: AOAM5306bjkb9ujeS2lsi304K1er57gUPHFBuAm77LlFfP4/huLyJ2qH rXaSGVQ4nvAG8plr+h1uiu6fDTQpYnAlZA== X-Google-Smtp-Source: ABdhPJyYiAWYd2phtTLnxvNTP1fa+8RYPVlyMdC4mzu9NbjSKcv+5nFABxTA6GX09x6gvvqlSCMwSg== X-Received: by 2002:a5d:658d:: with SMTP id q13mr4085989wru.388.1614865098596; Thu, 04 Mar 2021 05:38:18 -0800 (PST) Original-Received: from localhost ([51.37.98.190]) by smtp.gmail.com with ESMTPSA id i4sm9119807wmq.12.2021.03.04.05.38.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Mar 2021 05:38:17 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Wed, 03 Mar 2021 21:33:16 -0500") Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=contovob@tcd.ie; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265950 Archived-At: Stefan Monnier writes: >> Beats me :/. Even after reverting commits a0f60293d9 and 88ca2280ba, >> 'make check' still fails. But both 'git bisect', and checking out its >> parent 6ad9b8d677, point to a0f60293d9 as being the culprit. > > It turns out it was because a `no-byte-compile` was hiding the problem. Sometimes I feel like the compiler doesn't ignore our comments. -- Basil