From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 4) Date: Mon, 10 May 2021 23:47:46 +0300 Organization: LINKOV.NET Message-ID: <87pmxywc25.fsf@mail.linkov.net> References: <0bbdeece-90d5-160c-07ec-2ad8edbf9872@daniel-mendler.de> <87czudm7bv.fsf@mail.linkov.net> <976056e8-3d46-db27-32c2-ddf3ca32d5a7@daniel-mendler.de> <878s5090e9.fsf@mail.linkov.net> <69fd42ed-a1a0-adcb-ac8b-caad80cb0967@daniel-mendler.de> <878s4zzpvc.fsf@mail.linkov.net> <95ac7ef3-5e8c-fc58-b316-544096c82aa0@daniel-mendler.de> <87o8dus00b.fsf@mail.linkov.net> <6718c89f-88a0-b529-1676-7e89fc152f00@daniel-mendler.de> <878s4w3law.fsf@mail.linkov.net> <87sg2ymq6j.fsf@mail.linkov.net> <78bb0663-80ef-a68f-c582-cd7cc0436c29@daniel-mendler.de> <069cec7d-db2c-8628-69fb-a2aee4ee5074@daniel-mendler.de> <6ac36d0f-bf5b-2124-1f70-69644bb40218@daniel-mendler.de> <871rafrdny.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25836"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Gregory Heytings , "emacs-devel@gnu.org" , Stefan Monnier , Dmitry Gutov To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 10 23:29:37 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgDT6-0006aa-Mf for ged-emacs-devel@m.gmane-mx.org; Mon, 10 May 2021 23:29:36 +0200 Original-Received: from localhost ([::1]:53216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgDT5-0001DX-ND for ged-emacs-devel@m.gmane-mx.org; Mon, 10 May 2021 17:29:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgDSC-0008KC-CO for emacs-devel@gnu.org; Mon, 10 May 2021 17:28:40 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:34061) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgDSA-0005VO-C3 for emacs-devel@gnu.org; Mon, 10 May 2021 17:28:39 -0400 X-Originating-IP: 91.129.102.166 Original-Received: from mail.gandi.net (m91-129-102-166.cust.tele2.ee [91.129.102.166]) (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 0D1A8E0008; Mon, 10 May 2021 21:28:30 +0000 (UTC) In-Reply-To: (Daniel Mendler's message of "Sun, 9 May 2021 20:50:04 +0200") Received-SPF: pass client-ip=217.70.183.196; envelope-from=juri@linkov.net; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269133 Archived-At: > So what is the plan regarding the patch? Use the variant which has the > action argument (title, transform, sort) or use the variant with the > boolean transform argument, which does not allow sorting of the groups? > > Stefan stated in his mail that letting the UI decide if the groups > should be sorted alphabetically is also a possibility. We can implement > this proposal by adding a `completions-sort` variable to minibuffer.el, Probably you meant to name it `completions-group-sort` since the name `completions-sort` is too ambiguous? Then such an option could support any function to perform sorting, and when necessary the API user could let-bind it around the API call, e.g. in the case of the ucs-char-names: diff --git a/lisp/international/mule-cmds.el b/lisp/international/mule-cmds.el index 5a7e417b8e..e7b56dd8e0 100644 --- a/lisp/international/mule-cmds.el +++ b/lisp/international/mule-cmds.el @@ -3161,6 +3161,10 @@ read-char-by-name (let* ((enable-recursive-minibuffers t) (completion-ignore-case t) (completion-tab-width 4) + (completions-group-sort + (if read-char-by-name-group-sort + (lambda (a b) (string< (car a) (car b))) + completions-group-sort)) (input (completing-read prompt This is just an example, I'm not sure if read-char-by-name-group-sort is really needed, but this example demonstrates that it's up to the user to define options more specific to the completion table.