From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Context menus and mouse-3 Date: Mon, 12 Jul 2021 23:56:39 +0300 Organization: LINKOV.NET Message-ID: <87pmvnuyug.fsf@mail.linkov.net> References: <20200914061111.3trmuzhdvv7nwdcc@Ergus> <87y2acv2tw.fsf@mail.linkov.net> <83zguragqj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28510"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: philipk@posteo.net, rms@gnu.org, spacibba@aol.com, emacs-devel@gnu.org, monnier@iro.umontreal.ca, arthur.miller@live.com, dgutov@yandex.ru, ghe@sdf.org, drew.adams@oracle.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jul 12 23:52:18 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m33qc-0007IX-GP for ged-emacs-devel@m.gmane-mx.org; Mon, 12 Jul 2021 23:52:18 +0200 Original-Received: from localhost ([::1]:55970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m33qb-00081n-CP for ged-emacs-devel@m.gmane-mx.org; Mon, 12 Jul 2021 17:52:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m33pw-0007M8-Vl for emacs-devel@gnu.org; Mon, 12 Jul 2021 17:51:37 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:39623) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m33pu-0004Dr-M2; Mon, 12 Jul 2021 17:51:36 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 80ED140008; Mon, 12 Jul 2021 21:51:23 +0000 (UTC) In-Reply-To: <83zguragqj.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 12 Jul 2021 14:55:48 +0300") Received-SPF: pass client-ip=217.70.183.194; envelope-from=juri@linkov.net; helo=relay2-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271188 Archived-At: >> >> > We don't need to choose, since we can get a context menu on >> >> > `down-mouse-3` and 'mouse-save-then-kill' on `mouse-3`. >> > >> > (defun mouse-maybe-context-menu (event) >> > "Bring up a context menu for a long click. >> > See `mouse-long-click-time' and `mouse-context-menu-function'." >> > (interactive "@e") >> > (if (let ((track-mouse t)) (sit-for (/ mouse-long-click-time 1000.0))) >> > (push (cons 'context-menu (cdr event)) unread-command-events))) >> > >> > It's not good enough for `master` (IIRC the sit-for tends to return nil >> > immediately in some circumstances), but I didn't pursue this any further >> > given the lack of interest at the time. I can't think of any reason why >> > it should be hard to fix. >> >> This is a much needed feature and it would nice to finish it one way or another. >> I tried to use timers, and the result works well in all test cases: > > Could you please remind us the problem you are trying to solve here? Nowadays every other app uses down-mouse-3 to pop up a context menu, but in Emacs mouse-3 operates on the region. So the solution is similar to mouse-1-click-follows-link: to pop up a context menu after a delay, otherwise the immediate click operates on the region. The only thing I don't understand why couldn't the context-menu implementation be the same as the menu-bar implementation? The global binding of [menu-bar] is defined in menu-bar.el, so the same way [context-menu] could be defined globally with the standard bindings such as all other apps have: "Cut", "Copy", "Paste", "Select All", "Undo", "Redo". Then the users will be able to customize the global [context-menu] applicable to all buffers. Every mode can define own [context-menu] in their mode-maps, then users will be able to customize mode's [context-menu] using mode hooks. Even text-properties could define the [context-menu] in their local bindings that will be used by '(current-local-map)' or better '(current-active-maps)'. To be able to override the [context-menu], local bindings could use text-property maps with another binding named [overriding-context-menu] that will replace the whole composite [context-menu], so e.g. flyspell-mode could put it on misspelled words, etc.