From: Lars Ingebrigtsen <larsi@gnus.org>
To: Anand Tamariya <atamariya@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [Patch] Draw and scribble notes in GNU Emacs
Date: Mon, 13 Sep 2021 10:25:01 +0200 [thread overview]
Message-ID: <87pmtchogy.fsf@gnus.org> (raw)
In-Reply-To: <CADm7Y4mHBc9STf6JDiABnh4nbBGA=cbNABz=D+q0ZKzhmHcibQ@mail.gmail.com> (Anand Tamariya's message of "Mon, 13 Sep 2021 11:06:46 +0530")
Anand Tamariya <atamariya@gmail.com> writes:
> Existing code doesn't ensure ids are unique.
svg--append isn't the function to ensure this. It's a very confusing
interface if a function like svg--append would make other nodes suddenly
disappear.
(And besides, `dom-remove-node' is very slow, so it shouldn't be used in
a function like this.)
> Furthermore, in case id is duplicated, only the attributes on the
> first tag gets replaced. That's a little unpredictable behaviour from
> an API perspective.
It's unpredictable, but the new version is still unpredictable -- but in
a different way, so I don't see a net positive here. We're altering the
behaviour from one slightly odd interface to another slightly odd
interface.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-09-13 8:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 7:54 [Patch] Draw and scribble notes in GNU Emacs Anand Tamariya
2021-09-09 8:33 ` Po Lu
2021-09-09 12:00 ` Eli Zaretskii
2021-09-09 12:23 ` Po Lu
2021-09-09 14:51 ` Lars Ingebrigtsen
2021-09-10 21:45 ` dalanicolai
2021-09-13 5:32 ` Anand Tamariya
2021-09-13 5:15 ` Anand Tamariya
2021-09-09 14:50 ` Lars Ingebrigtsen
2021-09-13 5:36 ` Anand Tamariya
2021-09-13 8:25 ` Lars Ingebrigtsen [this message]
2021-09-13 8:31 ` Anand Tamariya
2021-09-13 8:47 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmtchogy.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=atamariya@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).