From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 5252c45: Initialise unread buffer Date: Sun, 19 Sep 2021 16:56:02 +0200 Message-ID: <87pmt4obr1.fsf@gnus.org> References: <20210919142251.2698.98689@vcs0.savannah.gnu.org> <20210919142252.B0B1520ABE@vcs0.savannah.gnu.org> <87lf3spro4.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35694"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 19 16:57:20 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRyFq-00092H-Qm for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Sep 2021 16:57:18 +0200 Original-Received: from localhost ([::1]:50152 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRyFp-0003SN-KW for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Sep 2021 10:57:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRyEk-0002L8-PW for emacs-devel@gnu.org; Sun, 19 Sep 2021 10:56:11 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:60258) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRyEj-00016R-7A for emacs-devel@gnu.org; Sun, 19 Sep 2021 10:56:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=y1IpKnGJCydsSPU+CFpaaQb2NTItk8aD6/LydxfDxMg=; b=J9nEwaEaD3bayBfG62wCWTHxZq //4z/49l7F8eggjvkW9YMNjNphZcOTGk/G4a5o7MeyF8vimPHwdS1wcKGSmYuFm5KAcxQd5sj4Pt0 8QAyUEXnESB00S1Ye+VTALfAA2bQBZPwE9/gmUhySTg7e/Qm0xCFklQYovG2cttgIOaE=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRyEd-0008PA-LK; Sun, 19 Sep 2021 16:56:06 +0200 In-Reply-To: <87lf3spro4.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 19 Sep 2021 16:26:51 +0200") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275056 Archived-At: Lars Ingebrigtsen writes: > Mattias Engdeg=C3=A5rd writes: > >> The reader has an extra 1-char unread buffer that was incorrectly >> initialised to 0, which means that the first character read would >> always be NUL. As this is often the code that looks for the >> lexical-binding cookie, the first loaded source module would be >> treated as dynamically bound. During bootstrapping this is loadup.el >> and so its local variables got dumped into the global environment. > > Wow. How did you manage to debug this? :-) But it seems like this leads to random breakages: Debugger entered--Lisp error: (error "Invalid byte opcode: op=3D0, ptr=3D6") signal(error ("Invalid byte opcode: op=3D0, ptr=3D6")) apply(signal (error ("Invalid byte opcode: op=3D0, ptr=3D6"))) (setq value-198 (apply fn-196 args-197)) This is when evalling the body of this test: (ert-deftest eval-tests-accept-empty-optional-rest () "Check that Emacs accepts empty &optional and &rest arglists. Bug#24912." (dolist (args '((&optional) (&rest) (&optional &rest) (&optional &rest a) (&optional a &rest))) (let ((fun `(lambda ,args 'ok))) (ert-info ("eval") (should (eq (funcall (eval fun t)) 'ok))) (ert-info ("byte comp check") (byte-compile-check-lambda-list args)) (ert-info ("bytecomp") (let ((byte-compile-debug t)) (should (eq (funcall (byte-compile fun)) 'ok)))))) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no