unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Re: master 84bf954 2/2: Use a proportional font for the mode line
Date: Thu, 25 Nov 2021 19:44:40 +0100	[thread overview]
Message-ID: <87pmqo3wiv.fsf@gmail.com> (raw)
In-Reply-To: <83mtls3x9w.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 25 Nov 2021 20:28:27 +0200")

>>>>> On Thu, 25 Nov 2021 20:28:27 +0200, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Lars Ingebrigtsen <larsi@gnus.org>
    >> Date: Thu, 25 Nov 2021 19:18:15 +0100
    >> Cc: emacs-devel@gnu.org
    >> 
    >> > diff --git a/src/font.c b/src/font.c
    >> > index d423fd46b7..0cedb230c8 100644
    >> > --- a/src/font.c
    >> > +++ b/src/font.c
    >> > @@ -70,7 +70,7 @@ #define DEFAULT_ENCODING Qiso8859_1
    >> >    { 40, { "ultra-light", "ultralight", "extra-light", "extralight" }},
    >> >    { 50, { "light" }},
    >> >    { 55, { "semi-light", "semilight", "demilight" }},
    >> > -  { 80, { "regular", "normal", "unspecified", "book" }},
    >> > +  { 80, { "normal", "regular", "unspecified", "book" }},
    >> 
    >> Hm.  But is that a problem with Customize or this?  I guess "normal" is
    >> more normal than regular, so perhaps this is the right solution.

    Eli> I think it's a bug in Customize that it doesn't support the aliases
    Eli> here.  If nevertheless we fix it in font.c, we should have a prominent
    Eli> comment there explaining the importance of the order.

This also does it, but those weights look seriously out of whack
compared to the list in font.c

diff --git a/lisp/cus-face.el b/lisp/cus-face.el
index 5037ee77c7..82fe8f23be 100644
--- a/lisp/cus-face.el
+++ b/lisp/cus-face.el
@@ -92,7 +92,7 @@ custom-face-attributes
 	     (const :tag "semilight" semi-light)
 	     (const :tag "book" semi-light)
 	     (const :tag "normal" normal)
-	     (const :tag "regular" normal)
+	     (const :tag "regular" regular)
 	     (const :tag "medium" normal)
 	     (const :tag "semibold" semi-bold)
 	     (const :tag "demibold" semi-bold)



  reply	other threads:[~2021-11-25 18:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211124134823.8483.27841@vcs0.savannah.gnu.org>
     [not found] ` <20211124134825.75B422094B@vcs0.savannah.gnu.org>
2021-11-25 17:13   ` master 84bf954 2/2: Use a proportional font for the mode line Robert Pluim
2021-11-25 17:40     ` Lars Ingebrigtsen
2021-11-25 17:58       ` Robert Pluim
2021-11-25 18:18         ` Lars Ingebrigtsen
2021-11-25 18:28           ` Eli Zaretskii
2021-11-25 18:44             ` Robert Pluim [this message]
2021-11-25 19:06               ` Eli Zaretskii
2021-11-25 19:15                 ` Lars Ingebrigtsen
2021-11-25 19:30                   ` Eli Zaretskii
2021-11-26  8:26                     ` Robert Pluim
2021-11-26  8:36                       ` Eli Zaretskii
2021-11-26  8:42                         ` Robert Pluim
2021-11-26 11:10                           ` Eli Zaretskii
2021-11-26 12:39                             ` Lars Ingebrigtsen
2021-11-26 13:31                               ` Robert Pluim
2021-11-25 18:32           ` Robert Pluim
2021-11-25 18:56             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmqo3wiv.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).