From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Feng Shu" Newsgroups: gmane.emacs.devel Subject: Re: Variable pitch text filling Date: Fri, 03 Dec 2021 19:47:57 +0800 Message-ID: <87pmqd9afm.fsf@163.com> References: <87ilwft1ph.fsf@gnus.org> <87sfvessx6.fsf@gnus.org> <87wnkp9c3t.fsf@gnus.org> <87ee6wanra.fsf@gnus.org> <83r1awse4k.fsf@gnu.org> <87sfvc8kdw.fsf@gnus.org> <83czmgs7t1.fsf@gnu.org> <87k0go8ios.fsf@gnus.org> <83bl20s2dp.fsf@gnu.org> <87wnkojmny.fsf@gnus.org> <837dcos1oy.fsf@gnu.org> <87o860jm27.fsf@gnus.org> <831r2ws0jf.fsf@gnu.org> <87fsrcjkik.fsf@gnus.org> <83ee6uao67.fsf@gnu.org> <83sfva92vo.fsf@gnu.org> <83czme85xk.fsf@gnu.org> <87y252840y.fsf@163.com> <838rx19b11.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9107"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: casouri@gmail.com, larsi@gnus.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 03 12:48:51 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mt73b-0002FZ-HK for ged-emacs-devel@m.gmane-mx.org; Fri, 03 Dec 2021 12:48:51 +0100 Original-Received: from localhost ([::1]:53734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mt73a-0006wa-Ho for ged-emacs-devel@m.gmane-mx.org; Fri, 03 Dec 2021 06:48:50 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36486) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mt72q-0006DR-SW for emacs-devel@gnu.org; Fri, 03 Dec 2021 06:48:04 -0500 Original-Received: from m12-18.163.com ([220.181.12.18]:46279) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mt72n-0008Pi-I8; Fri, 03 Dec 2021 06:48:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=voxEH SRcGel6/bpPkPPjllaK/4ewLd5PxOnruqj68Ig=; b=o7ytIX+VLo1FlTY+3Phfz p6FEwvoyl/DTGmGRSHFONNg38Q/ur2x5SWJeAH582S+yUApj+gyB77ewolfx8mV5 xFoa4Wi15K7HzJcZbEYUh/tYnRykhx9Gc21UCGY1muRZNSqTJlP//QfPSggleOwM pYh8lHnx4R5D6wVe4ODXJg= Original-Received: from debian (unknown [218.92.14.78]) by smtp14 (Coremail) with SMTP id EsCowACX5CntA6phqAWcAA--.6181S2; Fri, 03 Dec 2021 19:47:58 +0800 (CST) In-Reply-To: <838rx19b11.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 03 Dec 2021 13:35:06 +0200") X-CM-TRANSID: EsCowACX5CntA6phqAWcAA--.6181S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Zr4DGFW7KFyrGw1Utr4xWFg_yoW8CrWkpF yUJw45Xr4vyrWI9rWkKa4kZayF9r1rJwsxJr97Cw1xCFy8GrWvvF13tFWavFna9FsrCFn7 J34Dt3s7CFn7Z37anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UF0PfUUUUU= X-Originating-IP: [218.92.14.78] X-CM-SenderInfo: 5wxpt2lkx6il2tof0z/1tbiEQ5e1F7+5sf7VAAAs7 Received-SPF: pass client-ip=220.181.12.18; envelope-from=tumashu@163.com; helo=m12-18.163.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280825 Archived-At: Eli Zaretskii writes: >> From: "Feng Shu" >> Cc: casouri@gmail.com, larsi@gnus.org, emacs-devel@gnu.org >> Date: Fri, 03 Dec 2021 16:51:41 +0800 >> >> Maybe we should conside the below feature: >> 1. Prevent minibuffer/mode/header/tab-line from shaking up and down >> 2. Provide a simple fontset config UI? customize-fontset? >> 3. line-height-factor > > First, I don't see how any feature that affects the height of the > lines could be useful for horizontal character-spacing, in general. > > Second, I already implemented 1 and 3, and you rejected the results as the patch implemented 1, do you mean the below? +++ b/src/window.c @@ -5246,7 +5246,10 @@ grow_mini_window (struct window *w, int delta) { struct frame *f = XFRAME (w->frame); int old_height = window_body_height (w, true); - int min_height = FRAME_LINE_HEIGHT (f); + int min_height = + FLOATP (Vline_height_factor) + ? FRAME_LINE_HEIGHT (f) * XFLOAT_DATA (Vline_height_factor) + : FRAME_LINE_HEIGHT (f); eassert (MINI_WINDOW_P (w)); @@ -5279,7 +5282,11 @@ grow_mini_window (struct window *w, int delta) shrink_mini_window (struct window *w) { struct frame *f = XFRAME (w->frame); - int delta = window_body_height (w, true) - FRAME_LINE_HEIGHT (f); + int min_line_height = + FLOATP (Vline_height_factor) + ? FRAME_LINE_HEIGHT (f) * XFLOAT_DATA (Vline_height_factor) + : FRAME_LINE_HEIGHT (f); + int delta = window_body_height (w, true) - min_line_height; eassert (MINI_WINDOW_P (w)); diff --git a/src/xdisp.c b/src/xdisp.c > unsatisfactory, so this is off the table. > > As for easier customization of fontsets: patches are welcome, of > course. But again, I'm not sure it will fix the problem discussed > here, since no one has yet come up with a list of fonts where the > problems that bother you are resolved. --