From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: emacs-28 edb1d49: * lisp/net/shr.el (shr-expand-url): Also strip trailing Date: Thu, 23 Dec 2021 19:53:00 +0100 Message-ID: <87pmpn40hf.fsf@gnus.org> References: <20211223180957.11470.44284@vcs0.savannah.gnu.org> <20211223180958.5B91921362@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16732"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Andreas Schwab , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 23 19:55:04 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n0TF2-00047x-5W for ged-emacs-devel@m.gmane-mx.org; Thu, 23 Dec 2021 19:55:04 +0100 Original-Received: from localhost ([::1]:51938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n0TF1-0007rX-9h for ged-emacs-devel@m.gmane-mx.org; Thu, 23 Dec 2021 13:55:03 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0TDC-00049c-Ef for emacs-devel@gnu.org; Thu, 23 Dec 2021 13:53:10 -0500 Original-Received: from [2a01:4f9:2b:f0f::2] (port=52048 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0TDA-0002PC-Ni; Thu, 23 Dec 2021 13:53:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+BstSUr/clGhH3VNTc5H0MP2hAciR5T2sgyhH5gqFL0=; b=skko/SDmC4EjrKT7DNFwYOCEtl lTgoHDO8FmGc2WsRXXjMlDCnNBdXgGXHrGFS8BaZdAyh4NoLkHQhTU/pDXnR9gT9G7sIpjJ23AJN9 G6bjQ7k5JA7GPiev1Jplt21eLahXBMX7aQZQQ+WXa52sFHGz0VpJU32r4oVgOU26V9ZY=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n0TD4-0004Xl-Ji; Thu, 23 Dec 2021 19:53:05 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEWuv9xildJAaKEo JTSTU1z///8TbjWQAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+UMFxIZIUqobO4AAAGaSURBVDjLdZOL dcMgDEVx7AECnQCRARLEABS0/0zVB6idtPIx+HCt35PtHNvmndrGD5s3c9Ps4P4JvNcj598BiInP FWwJ2XKcgCa4oVoeGcIEGw6LI9AE6pD5fvlr8iAA/gD7DJWtGwFaxdcC2/K4y2NaIJ5C8bpjITo6 g9sCGvMLSVIRgoAgt4GEVcCBsBkAA5zjZcUJCAAhwgRSKDcCnBxOIEjbKWFiEFTnAXzitxNTiOEK gk+lsyg+jvMJeKb1qAfED/BgQL1AoAZEjVaOQohFJG7m0GZVWA8VqzBoC8g4tL9SWDNo9BihRNzK onSUy6K5KbqKpSC3ZkDniiREdiR4NAVjSs4AqwZRPcKcno7ECfCsi1vzzuSOQpW/C5GXgUZ68k5a b1cAAzydNM5hiK6AO2DjRZQ5gWcv3RIxYFFEYhcZuEIDPHepSj2AAbGuBEGChhVKQOEe9NeR6ZYT eJXx53Bd+9kjfw9ZKpfWTwD3bDVJbuqfAMthKi5wTB1r/wfQfgXTCrn/QP0FYGdgb5T9DWTbO7pk 4AemVJesHfmgAgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0xMi0yM1QxODoyNTozMyswMDowMDG9 RlAAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMTItMjNUMTg6MjU6MzMrMDA6MDBA4P7sAAAAAElF TkSuQmCC X-Now-Playing: Hayato Mizuta's _Shelter_: "Wild Warp Western (Point East)" In-Reply-To: (Stefan Kangas's message of "Thu, 23 Dec 2021 10:40:48 -0800") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283008 Archived-At: Stefan Kangas writes: > schwab@gnu.org (Andreas Schwab) writes: > >> - ;; Strip leading whitespace >> + ;; Strip leading/trailing whitespace >> (and url (string-match "\\`\\s-+" url) >> (setq url (substring url (match-end 0)))) >> + (and url (string-match "\\s-+\\'" url) >> + (setq url (substring url 0 (match-beginning 0)))) > > This could be simplified to: > > (setq url (string-trim url)) And I'm not sure about the logic -- even stripping the leading spaces seems dubious. The function is supposed to perform expansion of URL (which may be a fragment) to BASE, and it's not supposed to do any DWIM stuff. What's the use case for stripping spaces? (Which are valid enough characters in URLs in some (pre-encoding) cases.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no