From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: gnus-search-mu Date: Tue, 29 Mar 2022 13:28:46 -0700 Message-ID: <87pmm433lt.fsf@ericabrahamsen.net> References: <87czib77uz.fsf@disroot.org> <878rszidk9.fsf@ericabrahamsen.net> <87sfr6eunp.fsf@disroot.org> <8735j5tzus.fsf@ericabrahamsen.net> <87ils0yqxd.fsf@disroot.org> <87ilrzuoof.fsf@ericabrahamsen.net> <87ilrz9d2x.fsf@disroot.org> <878rsuvie4.fsf@ericabrahamsen.net> <87bkxqa3l6.fsf@disroot.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7887"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: emacs-devel@gnu.org Cancel-Lock: sha1:4VELwUAlw3DOFwoU4H/1PgFyQBQ= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 29 22:30:07 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZITf-0001pa-Ep for ged-emacs-devel@m.gmane-mx.org; Tue, 29 Mar 2022 22:30:07 +0200 Original-Received: from localhost ([::1]:60580 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZITd-0008Q9-Vn for ged-emacs-devel@m.gmane-mx.org; Tue, 29 Mar 2022 16:30:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZISY-0007ih-MC for emacs-devel@gnu.org; Tue, 29 Mar 2022 16:28:58 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:38730) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZISX-0004HP-5D for emacs-devel@gnu.org; Tue, 29 Mar 2022 16:28:58 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nZIST-0000BP-HC for emacs-devel@gnu.org; Tue, 29 Mar 2022 22:28:53 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287567 Archived-At: Jai Flack writes: > Eric Abrahamsen writes: > >>> Were there any docstrings in particular you noticed that didn't make up >>> a complete sentence? I've updated them to be (roughly) the same as the >>> notmuch and namazu backends but the first lines already matched. >> >> Sorry, that was poorly phrased. I meant the first sentence of the docstring >> should all fit on a single line. Like this: >> >> (defcustom gnus-search-mu-raw-queries-p nil >> "If t, all mu engines will only accept raw search query >> strings. >> >> This can also be set per-server." >> :type 'boolean >> :group 'gnus-search) >> >> The first sentence should be munged until it doesn't wrap, then the >> second blank line doesn't need to be there. A la the "Tips for >> Documentation Strings" section of the Elisp manual. > > Ah right. > >> (If gnus-search.el itself doesn't fully adhere to these conventions, >> well... I'll get there eventually.) > > I also noticed some of the defcustom :types don't match (like > `gnus-search-*-remove-prefix). Probably wouldn't save you any time > writing a patch for these. > >>>>>> Out of curiosity, what is `ansi-color-filter-apply' doing there? >>>>> >>>>> I think I had trouble with mu giving ANSI escape codes to Emacs, it >>>>> might no longer be a problem or maybe there is a better solution. >>>> >>>> Okay, sounds good! ansi-color is built in so there's no harm in that. >>> >>> I've changed this to use the --nocolor option for mu. >> >> Even better. >> >>>> I'm assuming you have done copyright assignment. Do you have push >>>> permissions for ELPA and/or Emacs proper? >>> >>> Done copyright assignment. Don't have any push permissions. >> >> Are you expecting to ask for permission? (I'm not able to grant it.) If >> not, I can push these things for you. > > I wasn't planning on asking for permission. Not sure about the process > but I assume a bit more trust is required than a potential patch and a > couple potential ELPA packages. Worked for me! Ha. >>> For the ELPA package is there a good way to signal to users that the >>> built-in version should be used on a recent-enough Emacs version? >> >> I think your current Package-Requires header is the best we can do. I >> haven't actually tested if it will refuse to install on Emacs < 28.1, >> but I think due diligence is done. > > Not sure if you misunderstood me, I meant a warning for Emacs > 28 when > the mu backend will (hopefully) be a part of Emacs. > > Though it will possibly not like the current pretest 28.0.92 < 28.1. Oh... I actually don't know how that's supposed to work -- if there's some automatic machinery in place to prefer the built-in version when it's newer than the package. We'd have to ask the experts. Packaging experts? Is there anything special that has to be done? Eric