From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Trey Peacock Newsgroups: gmane.emacs.devel Subject: Re: PGTK-related misconceptions Date: Tue, 19 Apr 2022 23:02:08 +0000 Message-ID: <87pmlcad91.fsf@treypeacock.com> References: <87y202f4dq.fsf@treypeacock.com> <87o80xhor2.fsf@yahoo.com> <877d7lrbta.fsf@treypeacock.com> <87mtghg0j6.fsf@yahoo.com> Reply-To: Trey Peacock Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha256; boundary="------26b128cedb885dd916b7624ffec3581b09d38f5fb4e7cbea6364bdb0b98ab0b7"; charset=utf-8 Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29207"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Morgan Smith , emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 20 01:03:15 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ngwsM-0007NZ-7d for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Apr 2022 01:03:14 +0200 Original-Received: from localhost ([::1]:60128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngwsK-00041o-UD for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Apr 2022 19:03:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngwrc-0003LM-Nm for emacs-devel@gnu.org; Tue, 19 Apr 2022 19:02:28 -0400 Original-Received: from mail-40136.proton.ch ([185.70.40.136]:12505) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngwrZ-0006BZ-Uc for emacs-devel@gnu.org; Tue, 19 Apr 2022 19:02:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=treypeacock.com; s=protonmail2; t=1650409336; bh=CKVwv8biBD8N960Z4vFZaHy39MlUTZltb77WfZPDtJE=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=v6fYuDwJtXp1ijLDPJnsebysQW7vYOd7TmTV72YyP1PTK+MoGiwaeP0bqjIKUecNH H2gNv8p2MKY+EkrcX4v6s7vA+Gj0E+I1vfYEG3vV4kbAWqSObcdOoKM1zab23MH8sG 3+aVp38R9j++rJ4/eh2Hn2BzXzlbLyGQYbuGIucdEuR+/3trxtAQR166tiXENl+hi3 H7Ya6bU93xauNu/Mvdb8IlG5oantxnjHQHIvB+3vGq+jFEshVM+AvsvN0byM6aX/i4 nmUCNxAmpgpcGd2EPjwYREIQJPp22zXTVN9OvZtp8uBcbBVpKVMfOzbmV8ZEWO5yBX 36c02DFOiLvJA== In-Reply-To: <87mtghg0j6.fsf@yahoo.com> Feedback-ID: 17020329:user:proton Received-SPF: pass client-ip=185.70.40.136; envelope-from=gpg@treypeacock.com; helo=mail-40136.proton.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288680 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------26b128cedb885dd916b7624ffec3581b09d38f5fb4e7cbea6364bdb0b98ab0b7 Content-Type: multipart/mixed; boundary=32442f931ec007a2da05931e0703b5acb880af2b91379d0143edde7ecda2 From: Trey Peacock To: Po Lu Cc: Morgan Smith , emacs-devel@gnu.org Subject: Re: PGTK-related misconceptions In-Reply-To: <87mtghg0j6.fsf@yahoo.com> References: <87y202f4dq.fsf@treypeacock.com> <87o80xhor2.fsf@yahoo.com> <877d7lrbta.fsf@treypeacock.com> <87mtghg0j6.fsf@yahoo.com> Date: Tue, 19 Apr 2022 16:02:02 -0700 Message-ID: <87pmlcad91.fsf@treypeacock.com> MIME-Version: 1.0 --32442f931ec007a2da05931e0703b5acb880af2b91379d0143edde7ecda2 Content-Transfer-Encoding: Content-Disposition: Content-Type: text/plain; charset=UTF-8 "Po Lu" writes: > Trey Peacock writes: > >> Neither of the WMs I mentioned use GNOME Shell, but they do both use >> wlroots. Looking into this, it seems that any wlroots based Wayland >> compositor will use GDK_MOD4_MASK as Super. However, mutter (GNOME's >> WM) uses GDK_SUPER_MASK. Rebuilding emacs with the below patch seems >> to have fixed the issue. I'm not sure if there could be further >> implications for pgtk_emacs_to_gtk_modifiers. > > GDK_MOD4_MASK is a real modifier. GDK_SUPER_MASK is a "virtual > modifier" mask. > > The entire point of that change was to rely on GDK to compute the > correspondence between real modifiers and virtual modifiers instead of > doing it ourselves, since a real modifier can mean any number of virtual > modifiers and vice versa. It does not seem to be a requirement of GTK 3.2 or XKB to send virtual modifiers. The only compositor I have come across that actually sends a virtual modifier is mutter/GNOME. Neither wlroots nor Weston, the Wayland reference implementation, send them. I'm unsure about Plasma, but I believe this highlights an issue with the development of pgtk, if it is meant to be targeted towards wayland users it should be tested against more than just one compositor. > Hard-coding the meaning of GDK_MOD4_MASK would be a step backwards. The experience of a user updating Emacs and realizing a key is no longer recognized, without any notification or justification would also be a step backwards. > This seems to either be a bug in wlroots or GDK, so I suggest that a bug > be filed with their developers. I have spoken with devs of wlroots & wayland over IRC and they seem to agree that it is not necessary. I don't mean to be adversarial but would be happy to see this change amended to incorporate the entirety of wayland compositors. --32442f931ec007a2da05931e0703b5acb880af2b91379d0143edde7ecda2 Content-Transfer-Encoding: base64 Content-Disposition: attachment; name="publickey - gpg@treypeacock.com - da008078.asc"; filename="publickey - gpg@treypeacock.com - da008078.asc" Content-Type: application/pgp-keys; name="publickey - gpg@treypeacock.com - da008078.asc"; filename="publickey - gpg@treypeacock.com - da008078.asc" LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tClZlcnNpb246IEdvcGVuUEdQIDIu NC4xCkNvbW1lbnQ6IGh0dHBzOi8vZ29wZW5wZ3Aub3JnCgp4ak1FWVRVVCtSWUpLd1lCQkFIYVJ3 OEJBUWRBd2Q1cUwyVkRyREJ4R2RVUnp1T09xZGpraEZjbU9VUUhrdkxRClU5Q2EvZ1BOS1dkd1ow QjBjbVY1Y0dWaFkyOWpheTVqYjIwZ1BHZHdaMEIwY21WNWNHVmhZMjlqYXk1amIyMCsKd284RUVC WUtBQ0FGQW1FMVJhY0dDd2tIQ0FNQ0JCVUlDZ0lFRmdJQkFBSVpBUUliQXdJZUFRQWhDUkRJNUlj QgpKOVBEYlJZaEJOb0FnSGlxQzNRVW5OTDZoY2praHdFbjA4TnRtUndBL2o2ZWZFRzAvUmU5Z2ln UFVCWm5KZ0NCCm5DSU1JVzhGd2hDL04rMVQ1OVVZQVA0L0tMcGhWSVh3Zzh5TUpRYTM1aWZzendS TncvakpPQjRXcjFienlaMHEKQXM0ekJHRTFGQzRXQ1NzR0FRUUIya2NQQVFFSFFLVzE1Q093WWMw bE9zR2hCWE1IR3drcWNLRHoraHhCZ0ZiWgprSFAwQzVGMHdzQXZCQmdXQ2dBSkJRSmhOVVduQWhz Q0FKZ0pFTWpraHdFbjA4TnRkaUFFR1JZS0FBWUZBbUUxClJhY0FJUWtRMlNWQmhnZmRIYlFXSVFU LzVqZjRnYTR4N203MnBnblpKVUdHQjkwZHRIejRBUDltVEdUa09FWGEKYU4vZmR4ZTgrak5CZk11 R01hR3BoMzJteWRzT1NiS1pRZ0VBOElvSWlKc2ZTVWtmZDc3d0lKUVBGM1AxSTlOdAppZFluYWhO bXY5Qnlkd1FXSVFUYUFJQjRxZ3QwRkp6UytvWEk1SWNCSjlQRGJWNDhBUUNIaFVxbWVPRFBMcERj CjJKN0hxcHhINTRUZG9xclRobHdoN01jbnBSZWs4d0Q3QldhcjNqVEhCY2pIK0cyM0Vvc0VaVGQ5 RCtUWXcxVU4KbHlSaysxcVJTQXZPT0FSaE5SUlhFZ29yQmdFRUFaZFZBUVVCQVFkQTg2WUpoMHkz cW5LV2l0bW5Rc2hHYlhoRQppdmlmWEthbGpXK2dPM3BUUEhZREFRZ0h3bmdFR0JZSUFBa0ZBbUUx UmFjQ0d3d0FJUWtReU9TSEFTZlR3MjBXCklRVGFBSUI0cWd0MEZKelMrb1hJNUljQko5UERiWnJZ QVFDeHBTWUlkMkd3WFZzR1lMSFNiMXRnd1cyeUZoRVMKT2lvZXpDYkhmMmhvT1FFQTByMm1XUU1I RXlCaGl3TldUL3VTcFJZa0NJU1dNQzhuUFlDdlo3a3FUUVRPTXdSaApOUlJwRmdrckJnRUVBZHBI RHdFQkIwRHZLRmpFTkRGUy9YSENxVWR6aml6RnFleVVlWjJrLys5K3BQQXpGNnlWCklzSjRCQmdX Q2dBSkJRSmhOVVduQWhzTUFDRUpFTWpraHdFbjA4TnRGaUVFMmdDQWVLb0xkQlNjMHZxRnlPU0gK QVNmVHcyMk1xUUVBMXNEYVovUEVpOGNPUFBMMllWUE5HY2R6MkdyaUY1bEVFVVQ4cU1YNmpKd0Ev Um16VEJNbQpCNTRqcldEZTdjSzJFTEtQM3JtM2JGM0hQZUovMFFWbUxlRUMKPUZhYVEKLS0tLS1F TkQgUEdQIFBVQkxJQyBLRVkgQkxPQ0stLS0tLQ== --32442f931ec007a2da05931e0703b5acb880af2b91379d0143edde7ecda2-- --------26b128cedb885dd916b7624ffec3581b09d38f5fb4e7cbea6364bdb0b98ab0b7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: ProtonMail wnUEARYIACcFAmJfP24JkNklQYYH3R20FiEE/+Y3+IGuMe5u9qYJ2SVBhgfd HbQAAPS6AQCK5CwIyNGprAFqiI4OAT5f3Xn0qUUBqzgkvbVdwLIoBAD+Kkxr wSVHhnWC0QnCRtyfrkMDzuOAiPx9WRbth9asXAk= =JXlY -----END PGP SIGNATURE----- --------26b128cedb885dd916b7624ffec3581b09d38f5fb4e7cbea6364bdb0b98ab0b7--