From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org, Daniel Mendler <mail@daniel-mendler.de>
Subject: Re: master 49e06183f5 1/3: Allow REQUIRE-MATCH to be a function
Date: Sat, 11 Jun 2022 12:57:00 +0200 [thread overview]
Message-ID: <87pmjfsc1v.fsf@gnus.org> (raw)
In-Reply-To: <jwvk09ohdom.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 10 Jun 2022 10:15:50 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> But besides the `test-completion` part of the completion table, this new
> feature also overlaps with the `predicate` argument. I think it would
> be good to write down somewhere how those three compare.
The PREDICATE argument is under-documented, yes -- it's just supposed to
be a filter on COLLECTION, isn't it?
> I see that the `minibuffer-completion-confirm` function completely
> replaces the usual handling of require-match (i.e. the attempt to fix
> the case and the prompting for confirmation).
(You probably noticed it, but in case not -- I didn't change that code,
I just changed the indentation.)
> Maybe this should be better documented, and also AFAICT currently
> a `minibuffer-completion-confirm` function cannot reliably reproduce this
> behavior by hand because it doesn't have access to `beg` and `end`.
> I think we should make this "default behavior" more easily accessible
> (e.g. put it into its own function and document it as something that can
> be called from `minibuffer-completion-confirm`?).
I'm pretty sure I don't understand the subtleties here, but er sure? 🧐
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-06-11 10:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165484935985.12525.14065631018362412932@vcs2.savannah.gnu.org>
[not found] ` <20220610082240.A7222C01683@vcs2.savannah.gnu.org>
2022-06-10 14:15 ` master 49e06183f5 1/3: Allow REQUIRE-MATCH to be a function Stefan Monnier
2022-06-11 10:57 ` Lars Ingebrigtsen [this message]
2022-06-11 15:03 ` Stefan Monnier
2022-06-11 16:11 ` Lars Ingebrigtsen
2022-06-11 16:29 ` Stefan Monnier
2022-06-12 9:59 ` Lars Ingebrigtsen
2022-06-12 13:18 ` Stefan Monnier
2022-06-13 12:12 ` Lars Ingebrigtsen
2022-06-13 16:37 ` Stefan Monnier
2022-06-14 12:02 ` Lars Ingebrigtsen
2022-06-14 12:44 ` Stefan Monnier
2022-06-16 12:50 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmjfsc1v.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=mail@daniel-mendler.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).