From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: master 979308b4ca 5/9: org-export-data: Concatenate strings in temporary buffer for performance Date: Fri, 17 Jun 2022 19:35:50 +0800 Message-ID: <87pmj77ca1.fsf@localhost> References: <165536698076.5328.17316430648307086249@vcs2.savannah.gnu.org> <20220616080945.7DD14C01685@vcs2.savannah.gnu.org> <87y1xwept4.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21887"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 17 13:36:16 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o2AGt-0005UM-9n for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Jun 2022 13:36:15 +0200 Original-Received: from localhost ([::1]:57434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2AGr-0000DY-Uq for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Jun 2022 07:36:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2AFS-00075l-1E for emacs-devel@gnu.org; Fri, 17 Jun 2022 07:34:46 -0400 Original-Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:46980) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2AFQ-00012r-B8 for emacs-devel@gnu.org; Fri, 17 Jun 2022 07:34:45 -0400 Original-Received: by mail-pl1-x62f.google.com with SMTP id d13so3623426plh.13 for ; Fri, 17 Jun 2022 04:34:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=+w/Teqw5nBLzsrni6qlUlcS29GRL0TBVPYXXSeqkX38=; b=OPqaLtCcJCjF2aOCbQ8d+qClHif2fsoxQKs6dcKYJZx4kIFgcX9VGnABccJfsTRhu7 QrrdXL1TxamhKRwZvdLDizhxWPujvFaI6eECdkrAnPGOfn3IFSoErzc8x2nT4JuObEss 6fFJXD3pS8VMpQeh2JdSR//2gvLIvBr+YAzmtbMoluogfoRDqOl6PTw6D2SWe+ip0NAS XqM27f47hIbVn7jAY4e5BLE2hEi4co7Lg9ucZmMW8gkg1k9FlPCla/TleBArkAJ55SDj FByiGNzq6LmcXhFGXobBNFFpkVBkgrVJ8YNmado4bNsS+dQuH0hlLE9j+tBvm4VEIz8M F3gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=+w/Teqw5nBLzsrni6qlUlcS29GRL0TBVPYXXSeqkX38=; b=Xhd4y412tI+j/b+5C1rHIPEIPXQOGzE10zEfE4UyQjunbLTi8YLiwQUsDcEfTcrg/o LgMg1rlNvQhMjNkkDhKek7e5ebCBmPQENxs201fMsE9nn3M4glRyXBUsg1jIHv19+HmB WAQGAVpS3mRZykLlVUDoggwS0NNvVup8kwrIH41/y5SFX8d6MnQAoM6mYDNP2HZjZbFv nooXRJo6+BJP3oweOAwVILkhhtDP+iaLf81zIvpR0BneIzOeHbLEiLBVKDbC1YGcnLxD IRZkgmmOXPwy+aMjQblA/5GR5zsZV+oodCzTiNmAtLJ+SLTkhKZaX3b2F4EG85VN4WXH smzw== X-Gm-Message-State: AJIora8GdIiJwN9ksAcFnEOvYP26lkzZ9IQjR2JRZ39tblXlXgNEvGHu m3oEEQ7zRAEUavo0r/oDniLLvnb/awdKMWD0 X-Google-Smtp-Source: AGRyM1vNc9t+xWW2ZBXtsjhbryhgqbmUMGEydEO6esUsy2TAVAQefm0s9YMbEOUj8fd/gsETP+bfYg== X-Received: by 2002:a17:902:f813:b0:169:8f5d:c343 with SMTP id ix19-20020a170902f81300b001698f5dc343mr5265452plb.98.1655465682787; Fri, 17 Jun 2022 04:34:42 -0700 (PDT) Original-Received: from localhost ([66.154.105.4]) by smtp.gmail.com with ESMTPSA id k15-20020a170902760f00b00163e4410b82sm3313726pll.239.2022.06.17.04.34.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jun 2022 04:34:42 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::62f; envelope-from=yantar92@gmail.com; helo=mail-pl1-x62f.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291291 Archived-At: Stefan Monnier writes: > Ihor Radchenko [2022-06-16 20:49:27] wrote: >> I hope that I did not get it wrong. I _believe_ that I did see an >> improvement. So, you better check if it makes a difference on your side >> if you revert that patch (especially with un-optimized build where the >> differences should be more prominent). > > The fact that you think you saw a significant difference is already > a good hint that there might be something there, in any case. > But of course, we need to look more closely to see not just "if" but > "how" it is faster. I just tested the performance difference before/after reverting this particular commit. There is no measurable difference on my system. So, what I saw was probably a result of multiple commits I cramped together during testing. In any case, optimizing mapconcat should not heart. Best, Ihor