From: Ihor Radchenko <yantar92@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master 979308b4ca 5/9: org-export-data: Concatenate strings in temporary buffer for performance
Date: Fri, 17 Jun 2022 19:35:50 +0800 [thread overview]
Message-ID: <87pmj77ca1.fsf@localhost> (raw)
In-Reply-To: <jwv4k0ktt9l.fsf-monnier+emacs@gnu.org>
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Ihor Radchenko [2022-06-16 20:49:27] wrote:
>> I hope that I did not get it wrong. I _believe_ that I did see an
>> improvement. So, you better check if it makes a difference on your side
>> if you revert that patch (especially with un-optimized build where the
>> differences should be more prominent).
>
> The fact that you think you saw a significant difference is already
> a good hint that there might be something there, in any case.
> But of course, we need to look more closely to see not just "if" but
> "how" it is faster.
I just tested the performance difference before/after reverting this
particular commit. There is no measurable difference on my system.
So, what I saw was probably a result of multiple commits I cramped
together during testing.
In any case, optimizing mapconcat should not heart.
Best,
Ihor
next prev parent reply other threads:[~2022-06-17 11:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165536698076.5328.17316430648307086249@vcs2.savannah.gnu.org>
[not found] ` <20220616080945.7DD14C01685@vcs2.savannah.gnu.org>
2022-06-16 12:19 ` master 979308b4ca 5/9: org-export-data: Concatenate strings in temporary buffer for performance Stefan Monnier
2022-06-16 12:45 ` Lars Ingebrigtsen
2022-06-16 13:33 ` Robert Pluim
2022-06-16 12:49 ` Ihor Radchenko
2022-06-16 17:43 ` Stefan Monnier
2022-06-17 11:35 ` Ihor Radchenko [this message]
2022-06-16 12:53 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmj77ca1.fsf@localhost \
--to=yantar92@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).