unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master 4895ca16f7: Ensure that we don't call print-unreadable-function from " prin1"
       [not found] ` <20220728102410.1F26BC0F1EF@vcs2.savannah.gnu.org>
@ 2022-07-28 10:28   ` Robert Pluim
  2022-07-28 10:30     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Robert Pluim @ 2022-07-28 10:28 UTC (permalink / raw)
  To: emacs-devel; +Cc: Lars Ingebrigtsen

>>>>> On Thu, 28 Jul 2022 06:24:09 -0400 (EDT), Lars Ingebrigtsen <larsi@gnus.org> said:

    Lars> branch: master
    Lars> commit 4895ca16f76aa0ec044212a2b96ef8646cf4d0ed
    Lars> Author: Lars Ingebrigtsen <larsi@gnus.org>
    Lars> Commit: Lars Ingebrigtsen <larsi@gnus.org>

    Lars>     Ensure that we don't call print-unreadable-function from " prin1"
    
    Lars>     * src/print.c (PRINTPREPARE): Bind the current buffer so that we
    Lars>     can retrieve it later.
    Lars>     (print_vectorlike): Use it (bug#56773).
    Lars>     (syms_of_print): New internal `print--unreadable-callback-buffer'
    Lars>     variable.

If itʼs truly internal we should `unintern' it, no?

Robert
-- 



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master 4895ca16f7: Ensure that we don't call print-unreadable-function from " prin1"
  2022-07-28 10:28   ` master 4895ca16f7: Ensure that we don't call print-unreadable-function from " prin1" Robert Pluim
@ 2022-07-28 10:30     ` Lars Ingebrigtsen
  2022-07-28 10:37       ` Robert Pluim
  0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2022-07-28 10:30 UTC (permalink / raw)
  To: Robert Pluim; +Cc: emacs-devel

Robert Pluim <rpluim@gmail.com> writes:

> If itʼs truly internal we should `unintern' it, no?

I didn't know that was possible?




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master 4895ca16f7: Ensure that we don't call print-unreadable-function from " prin1"
  2022-07-28 10:30     ` Lars Ingebrigtsen
@ 2022-07-28 10:37       ` Robert Pluim
  2022-07-28 10:40         ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Robert Pluim @ 2022-07-28 10:37 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: emacs-devel

>>>>> On Thu, 28 Jul 2022 12:30:57 +0200, Lars Ingebrigtsen <larsi@gnus.org> said:

    Lars> Robert Pluim <rpluim@gmail.com> writes:
    >> If itʼs truly internal we should `unintern' it, no?

    Lars> I didn't know that was possible?

  DEFSYM (Qinternal_interpreter_environment,
	  "internal-interpreter-environment");
  DEFVAR_LISP ("internal-interpreter-environment",
		Vinternal_interpreter_environment,
	       doc: /* If non-nil, the current lexical environment of the lisp interpreter.
When lexical binding is not being used, this variable is nil.
A value of `(t)' indicates an empty environment, otherwise it is an
alist of active lexical bindings.  */);
  Vinternal_interpreter_environment = Qnil;
  /* Don't export this variable to Elisp, so no one can mess with it
     (Just imagine if someone makes it buffer-local).  */
  Funintern (Qinternal_interpreter_environment, Qnil);

Robert
-- 



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master 4895ca16f7: Ensure that we don't call print-unreadable-function from " prin1"
  2022-07-28 10:37       ` Robert Pluim
@ 2022-07-28 10:40         ` Lars Ingebrigtsen
  0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2022-07-28 10:40 UTC (permalink / raw)
  To: Robert Pluim; +Cc: emacs-devel

Robert Pluim <rpluim@gmail.com> writes:

>   /* Don't export this variable to Elisp, so no one can mess with it
>      (Just imagine if someone makes it buffer-local).  */
>   Funintern (Qinternal_interpreter_environment, Qnil);

Thanks; now done.





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-07-28 10:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <165900384926.31041.14812200639744652787@vcs2.savannah.gnu.org>
     [not found] ` <20220728102410.1F26BC0F1EF@vcs2.savannah.gnu.org>
2022-07-28 10:28   ` master 4895ca16f7: Ensure that we don't call print-unreadable-function from " prin1" Robert Pluim
2022-07-28 10:30     ` Lars Ingebrigtsen
2022-07-28 10:37       ` Robert Pluim
2022-07-28 10:40         ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).