From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Tue, 30 Aug 2022 12:23:03 -0700 Message-ID: <87pmghv8mg.fsf@melete.silentflame.com> References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <999d1cb2-6b7f-8020-5202-e919278d895e@yandex.ru> <83v8q9u1q8.fsf@gnu.org> <87a67ladep.fsf@gnus.org> <83o7w1u0k1.fsf@gnu.org> <875yi9ac74.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19707"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: Lars Ingebrigtsen , Eli Zaretskii , dgutov@yandex.ru, ams@gnu.org, juri@jurta.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 30 21:49:13 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oT7EW-0004wW-HQ for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 21:49:13 +0200 Original-Received: from localhost ([::1]:51988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oT7EV-000615-5r for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 15:49:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT6pK-0006EX-AD for emacs-devel@gnu.org; Tue, 30 Aug 2022 15:23:10 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:38429) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT6pH-0003WI-Uw; Tue, 30 Aug 2022 15:23:09 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 5F8505C00E0; Tue, 30 Aug 2022 15:23:05 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 30 Aug 2022 15:23:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1661887385; x=1661973785; bh=i3Gn9VnX2a ruDZ8OXfjq+PqJYdO5LAe+B4Oh0QZgwXE=; b=Fw8nVBCKF/KxPXVSenCKy8kxT7 QGlWF/L/hy9lBlAgHKU6zjQxQaixKl1VVoVjvpiGGPSazHcx6WtFobMOYYNm6IWn NLXNl178gLCI2toBWimq0rLNr90f9Yl01t5bPWthRl75ScsLY8jd18NueY4EAQaT hdryDA7sMBQkZcE1e9HCEoXBDGJpqt36ZY9O4CNGIBLQNWwu3H7FmClx9Q3UHRUU /6p7kZGXoLRh25jnhIsjF/C1FhmKP34hZhsYmpyRRFecSmyHySpNAL8icLBtrc/s So8TKXDIeFZv4DzwCB+oDYqDYDNl92THMFS1bqjC+1i95yl7ZP5dY79vOeTg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1661887385; x=1661973785; bh=i3Gn9VnX2aruDZ8OXfjq+PqJYdO5 LAe+B4Oh0QZgwXE=; b=ZmkpjkxACMsXnezx6OU6fZ7uD172k9eEhm2Dflqwf3kf LPDXPwvOu/nT0OCg883VnbDLzdu/GxFJJ4jDChY68faksIhnZBW6XeQqBIGzIN32 mLSbEDqN7BLladWPFMSLN9Bu+f2JopGxY9asNLAHiytyUASgwukB/TrC3aK8hC0X NYXs/HdGdri1m/ZchGmRFOXMX3jJGm+o8FmnJazP3/Puw+1QFag2W7AjzIRh7/ir rukh6kzJeMh6UluWwR/X4dVTYUfwis+XBd3yrqyvehP4zDjYabxX/qJA+CiNEpnv aoldyuAxIaAW93ooiKSNkro6t66ZMYpGo9dZbj0bZA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdekfedgudefkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpeffueettdefvddtteevgfeufeejgfegudfgfedutdegfeet keehuddvfeejjeeifeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 30 Aug 2022 15:23:05 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id E05597E8C74; Tue, 30 Aug 2022 12:23:03 -0700 (MST) In-Reply-To: <875yi9ac74.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 30 Aug 2022 19:11:27 +0200") Received-SPF: pass client-ip=66.111.4.25; envelope-from=spwhitton@spwhitton.name; helo=out1-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, GAPPY_SUBJECT=0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294381 Archived-At: Hello, On Tue 30 Aug 2022 at 07:11PM +02, Lars Ingebrigtsen wrote: > Eli Zaretskii writes: > >> And then show a message to the user saying something like >> >> Edit the diffs to leave only the hunks you want to commit, >> then type C-c to go ahead and commit them. > > In a recursive edit? > > Sure, that's a possible interface, but I don't really see much practical > difference, except being less flexible. You're proposing a > "start-a-selective-commit" command followed by `C-c C-c'. > > But today you can say `C-x v D' to make the diff buffer, but you can > also make it in other ways, like `v' in the vc-dir buffer, or your own > self-composed command to get the current tree's diff (I've got one on > `H-d' that does some other stuff first and then presents me with the > diff buffer). And then you an edit the buffer, and `C-x v v' to commit > just the selected bits. > > It's more flexible, and not more work for the user than what you're > proposing, as far as I can tell. I agree, and prefer how with the C-x v D approach you aren't in some incomplete or transient state, waiting for you to trim the diff. You can just do it when and if you want to. -- Sean Whitton