From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Niklas Eklund Newsgroups: gmane.emacs.devel Subject: Re: Add zuul.el package to ELPA Date: Tue, 30 Aug 2022 19:52:52 +0000 Message-ID: <87pmgh1pbf.fsf@posteo.net> References: <874jxuj3q1.fsf@posteo.net> <87v8qaumrh.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25359"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 31 04:24:06 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTDOg-0006Oa-B5 for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 04:24:06 +0200 Original-Received: from localhost ([::1]:47418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTDOf-0004vN-4x for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 22:24:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT7IM-0000zX-Qz for emacs-devel@gnu.org; Tue, 30 Aug 2022 15:53:12 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:36093) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT7IJ-0000C2-Tx for emacs-devel@gnu.org; Tue, 30 Aug 2022 15:53:10 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id E91F6240108 for ; Tue, 30 Aug 2022 21:53:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1661889182; bh=1eaNDmhu+Ztm943rcr26FDWYfVdazj1u49sJMJvjFk8=; h=From:To:Cc:Subject:Date:From; b=caIV9TTRqgGg6XBdgVKZ8RnGnrXs/yWTkyDj1imHU4wFyvrShcRG66Fi8gNA2ASUE KZY+SJt+vH8ljNtDq2xk4OwqLiu8XPQNQuhyaYQEamkpftisxt6OuCiuZnei1UIDCt 40zqe9PIdpEehRPdCcAgN/z6VHcXIQYskzoqjzGg8jVckDqKVNl8H6Jl0KFFQGCPOx +WuAOdMzoUzzfYc7viMVpdt97O76L4rUQnOxsGlD3cDy+KMt/aOuLplNghKpDSi2CW tGGZ8AVAVkJLUkNKMgbb2Neavu7+gC3wcu1nwd2e2cVVWLCOFndMb1pCSN9UyjIa5d ANXTe52Bd6AeQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MHHzH4zjqz6tms; Tue, 30 Aug 2022 21:52:59 +0200 (CEST) In-Reply-To: <87v8qaumrh.fsf@posteo.net> Received-SPF: pass client-ip=185.67.36.66; envelope-from=niklas.eklund@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 30 Aug 2022 22:22:50 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294395 Archived-At: Philip Kaludercic writes: > Niklas Eklund writes: > >> >> Hello, >> >> I would like to add a package that I have developed named zuul.el, >> https://git.sr.ht/~niklaseklund/zuul.el, to ELPA. > > Just a few comments from briefly skimming the code: Hi Philip, thanks a lot for the review! :) > I believe if you used compat, you can reduce the minimal version of > Emacs down to 26.1, and the only hard dependency appears to be > project.el? I wasn't familiar with the compat library. But if I have a dependency to project.el which package-lint tells me I need to have Emacs 28.1 for, is the proper way to add project to Package-Requires to circumvent the need? Should I then do the same for e.g. seq or does compat provide functionality for that library? > I'd also recommend using more specific custom types for your user > options. See (elisp) Composite Types. Thanks for the suggestion, I wasn't aware about these composite types! > It also appears you should be able to use defconst and defvar-local in > your private variable section. defvar-local I didn't know about. > Keywords (:foo) do not have to be quoted to prevent evaluation. > > I believe, but I might be mistaken, that it is advised to require rx in > a `eval-when-compile' block. Make sense. > (mapconcat #'identity ...) should do the same as `string-join' Yeah this becomes clearer. > Defining a map like zuul-log-mode-map is usually done using defvar > > (defvar foo-map > (let ((map (make-sparse-keymap))) > (define-key map ...) > ... > map)) I have taken your suggestions and made them into the following commits: - Add defvar to zuul-log-mode-map - Replace mapconcat with string-join - Require rx at compilation - Use defconst and defvar-local in private vars - Use composite types for defcustom variables https://git.sr.ht/~niklaseklund/zuul.el/log /Niklas >> The package allows users to access build logs from the Zuul, >> https://zuul-ci.org/, CI system. Users uses the completion interface of >> Emacs to select a specific build and a buffer is then opened with the >> build log. >> >> The package utilizes Emacs compilation mode to navigate between errors >> in the logs. It also lets the user configure where projects can be found >> on the local machine so that navigating to the source code of an error >> works, even though the absolute path might not be found on the local >> host. >> >> /Niklas Eklund >> >> From ed4201c73aa66b21b040169009dddb636ab76048 Mon Sep 17 00:00:00 2001 >> From: Niklas Eklund >> Date: Mon, 29 Aug 2022 20:26:35 +0200 >> Subject: [PATCH] * elpa-packages (zuul): New package >> >> --- >> elpa-packages | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/elpa-packages b/elpa-packages >> index 4ae12a26ca..5ab182f93b 100644 >> --- a/elpa-packages >> +++ b/elpa-packages >> @@ -810,4 +810,8 @@ >> ("yasnippet-classic-snippets" :url nil) >> ("zones" :url nil) ;https://www.emacswiki.org/emacs/zones.el >> ("ztree" :url "https://github.com/fourier/ztree") >> + ("zuul" :url "https://git.sr.ht/~niklaseklund/zuul.el" >> + :news "CHANGELOG.org" >> + :readme "README.md" >> + :auto-sync t) >> )