From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.devel Subject: Re: Call for volunteers: add tree-sitter support to major modes Date: Tue, 11 Oct 2022 09:13:13 +0200 Message-ID: <87pmeyesty.fsf@thornhill.no> References: <83czb1jrm3.fsf@gnu.org> <878rlo7on0.fsf@thornhill.no> <83o7uki5ol.fsf@gnu.org> <87tu4c5g9j.fsf@thornhill.no> <835ygshz6k.fsf@gnu.org> <87zge3jj0j.fsf@gnus.org> <83o7uig9dm.fsf@gnu.org> <9E2D0EEB-3910-4C58-96E7-68E7C84E5097@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25646"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, emacs-devel@gnu.org, jostein@kjonigsen.net To: Jostein =?utf-8?Q?Kj=C3=B8nigsen?= , Eli Zaretskii , Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 11 09:44:47 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oi9wU-0006PZ-Go for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 09:44:46 +0200 Original-Received: from localhost ([::1]:46172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oi9wS-0000TQ-T2 for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 03:44:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oi9S4-0005Dh-Fi for emacs-devel@gnu.org; Tue, 11 Oct 2022 03:13:20 -0400 Original-Received: from out0.migadu.com ([94.23.1.103]:15019) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oi9S2-0008BR-Eh; Tue, 11 Oct 2022 03:13:20 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1665472395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Uvrp6gzYT5KLnhEp66Os5GFO2Yu5UqEuxvrKkmrlPug=; b=ziPW8dqjJzZiwi03oq+ksuq8KFmWNJQVwDsJgk9PGTpErFEwx6A3q2d3eK7jis6SeZX47E zL3Fya51nbBG5hKZDOuIGoMU47d8IxMboS3HeD+ViY0bpoQI2zUxt4GpPiI6f09T+PqEpF Dnr7ZzXRw7muCAUoa3uwAX4ecwiE+mJsf+UE5r4gqiRNnUiz3pZb4n6YDtcC+OC16bU/ud baonVSHb+5odkge1Iy/3eVYwU3KfL2pW920UT9FiQttXs+O6e4JMMCUYXWAWlAKuQU/iPU yOMP+9Tj5Q47rOtuSJx3TMj0zlc57Jg3oLlyrhuKNmVzqSykZUOuLFtoV1McAw== In-Reply-To: X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=94.23.1.103; envelope-from=theo@thornhill.no; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297436 Archived-At: Jostein Kj=C3=B8nigsen writes: > If someone has typescript-mode installed from MELPA and upgrade to=20 > Emacs-29... Which typescript-mode are they going to be running? > > Emacs does not support namespaces, so there would be no way to separate=20 > those two. And if the MELPA version runs, it would shadow the Emacs29=20 > implementation. > > Since I believe in keeping things simple for users, I think another=20 > option we could consider would be to simply make typescript-mode (the=20 > plain elisp version hosted on MELPA) simply not register itself if it=20 > finds that the tree-sitter version is already available from Emacs. And=20 > then we could stop updating it, and people would eventually stop=20 > installing it. > > Speaking as one of the MELPA typescript-mode co-maintainers, I have=20 > absolutely zero plans for maintaining the old elisp-based version once a= =20 > better, tree-sitter version has been mainlined into Emacs itself. > > -- > Yeah, agreed. Though the new in-tree one could be renamed to tsx-mode. That will support both typescript and tsx, anyways. Or it could be made to not work on 29.1, hehe. I don't really have a strong opinion, but seeing the state of the current typescript-mode, I do think there's a case here for actually superseding it. But that's not really my call to be made.=20 _I_ think the best name here is typescript-mode, but it could be tsx-mode, typescript-tree-sitter-mode or anything else. How about deprecating typescript.el the moment the 29.1 branch is cut? After we can but some sort of structure in place for the two to coexist? Theo