From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: feature/package+vc 04c4c578c7 3/4: Allow for packages to be installed directly from VCS Date: Wed, 26 Oct 2022 18:22:25 +0000 Message-ID: <87pmeev40u.fsf@posteo.net> References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <20220214140020.04438C00891@vcs2.savannah.gnu.org> <87bkqmqpvb.fsf@posteo.net> <87edv96q4j.fsf@posteo.net> <83tu455a5s.fsf@gnu.org> <87a65v2ytp.fsf@posteo.net> <834jw33rmx.fsf@gnu.org> <87pmer0xtz.fsf@posteo.net> <83wn8z2aze.fsf@gnu.org> <878rle1i0k.fsf@posteo.net> <87ilkelc10.fsf@posteo.net> <878rl6syg8.fsf@posteo.net> <87zgdjqcu0.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9194"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Richard Stallman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 26 20:25:00 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1onl5H-00028w-IU for ged-emacs-devel@m.gmane-mx.org; Wed, 26 Oct 2022 20:24:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1onl38-0003GZ-Ll; Wed, 26 Oct 2022 14:22:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onl2z-0002mu-NU for emacs-devel@gnu.org; Wed, 26 Oct 2022 14:22:39 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onl2u-0001Df-Sx for emacs-devel@gnu.org; Wed, 26 Oct 2022 14:22:35 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id DB4B9240104 for ; Wed, 26 Oct 2022 20:22:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1666808546; bh=LpD2m0J6mifJnscB8YtFCJ20i7syNF4vERD0vqIMzLU=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=BSxY8Wncx8C3cPUCD3gn5ynoad70MljUJFDi3ayq6xJYDSD52CoFQEiCTeBOoyE99 bdY0pQrDubTxodXpDEbH4kWGm5TXjz6SJwIC1OkAC3sY7jIPqEvgs3WytMjDoJjUJB L889bE9ZxePCosfv+y9tC139IaQiHizizo3MgzJ8PLwBGCHsRFdkfKdY2x/J339Jzm 7EH+pskmpxQBJCf4sGrZb9Pf2W8B084zHKojrI6cQUzp5vml7XvuBTdCImnq5kTGSK KnmiLAZUGIdHl1dgniFHrgyD1zHU1KmJPaEDu7nwY2InziwQWq4CUBgfuSq6xH/MQU s7FVNFR6MqxQA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MyHGV2vYXz9rxL; Wed, 26 Oct 2022 20:22:26 +0200 (CEST) In-Reply-To: <87zgdjqcu0.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 26 Oct 2022 09:11:03 +0200") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298563 Archived-At: --=-=-= Content-Type: text/plain Philip Kaludercic writes: >> But there is a general principle that it is better to get the external >> interfaces right before installing something new. Changing those >> interfaces now won't require people to change habits; changing them >> later could do so. >> >> The code for checking out the current-version repo of an ELPA package >> should be very little different from the code for checking out the >> upstream repo. If the latter is already working, getting the former >> to work equally well shouldn't take long. Would you please do that? > > It can be done, but I believe it would be best to add those kinds of > annotations to the server side (elpa-admin.el). The issue is that > figuring out what version was used to release a package is non-trivial > using just vc. I have pushed a commit to feature/package+vc that will use the release revision (if it is known) when `package-vc-install' is invoked with a prefix argument. On the server side, all that has to be added for this to work is the following: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/elpa-admin.el b/elpa-admin.el index 7ed78430d6..eb94afb512 100644 --- a/elpa-admin.el +++ b/elpa-admin.el @@ -770,6 +770,9 @@ of the current `process-environment'. Return the modified copy." (prin1 (mapcan (lambda (spec) + (let ((rel (ignore-errors (elpaa--get-last-release spec)))) + (when rel + (nconc spec (list :release-rev (cdr rel))))) (pcase spec (`(,name :url nil . ,rest) `((,name :url ,(concat "https://git.sv.gnu.org/git/" elpaa--gitrepo) --=-=-=--