Re: [NonGNU ELPA] 11 new packages!

[Akib Azmain Turja <akib@disroot.org>]

[-- Attachment #1: Type: text/plain, Size: 1618 bytes --]

Philip Kaludercic <philipk@posteo.net> writes:


[...]

>> blow:
>
> Attached the wrong file here:
>
> diff --git a/blow.el b/blow.el
> index 15cfd75956..974f745d6b 100644
> --- a/blow.el
> +++ b/blow.el
> @@ -93,7 +93,7 @@
>  
>  (defun blow--set-mode-list (symbol value)
>    "Set SYMBOL's default value to VALUE, SYMBOL should be `blow-mode-list'."
> -  (set-default symbol value)
> +  (set-default symbol value)		;perhaps `custom-set-default' would be better?
>    (when blow-mode
>      (blow--setup-all-buffers)))
>  

Thanks, and done.

> @@ -111,12 +111,12 @@ Don't modify this variable from Lisp programs, use `blow' instead."
>                         (sexp :tag "Mode line template")))
>    :set #'blow--set-mode-list)
>  
> -(defvar blow--original-lighters nil
> +(defvar blow--original-lighters nil	;why isn't the value initialised?
>    "Hash table of modes and their original lighters or nil.")
>  

I don't know.  Anyway, I change to initialize to (make-hash-table).

>  (defun blow--hash-exists-p (key table)
>    "Return t if KEY is in hash table TABLE."
> -  (let ((default (make-symbol "blow--nonexistant")))
> +  (let ((default (make-symbol "blow--nonexistant"))) ;the prefix is not necessary, the symbol isn't interned anyway
>      (not (eq (gethash key table default) default))))
>  
>  (defun blow--puthash-unless-exists (key value table)
>

Removed.

-- 
Akib Azmain Turja, GPG key: 70018CE5819F17A3BBA666AFE74F0EFA922AE7F5
Fediverse: akib@hostux.social
Codeberg: akib
emailselfdefense.fsf.org | "Nothing can be secure without encryption."

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]