From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master 8aef401b4f: LAP optimiser: more stack reduction hoisting Date: Mon, 13 Feb 2023 22:54:10 +0000 Message-ID: <87pmadrxbh.fsf@tcd.ie> References: <167630393968.3716.18264966967495324218@vcs2.savannah.gnu.org> <20230213155859.EC4E9C13915@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39526"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 13 23:55:06 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRhiz-000A6G-CJ for ged-emacs-devel@m.gmane-mx.org; Mon, 13 Feb 2023 23:55:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRhiG-0006ZH-Dv; Mon, 13 Feb 2023 17:54:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRhiF-0006Z8-3N for emacs-devel@gnu.org; Mon, 13 Feb 2023 17:54:19 -0500 Original-Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRhiC-00019Z-Ps for emacs-devel@gnu.org; Mon, 13 Feb 2023 17:54:18 -0500 Original-Received: by mail-wr1-x42a.google.com with SMTP id m14so13788242wrg.13 for ; Mon, 13 Feb 2023 14:54:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=USA1LPb1nNhfPr8YulQJKZZafUQGhETVMlPP0ATTuHw=; b=Ve+BuI4Q7XdvyExGHLGT4MBUZlZZVz/RMDVqgMr/LxK/Cgl4BeN7823c8aY/tDrdMT V942Eb3u8JhzUE/ty8ZQ6OkvYptTb5V8b9n03AgDwBEoBlqDNBRkvUfzyzkw16zmRovb qJKTb6pfF7GFpPXitdUB0v4p67WkuCb2/6/h2ZgZsH9dxKfFaEpkwvK70YBy8nxLvvQ5 b9wuEu4GfW3hAREFziyxZGo9rzhmexZzXAuMW1XTngdg3sTxI3XoY7omk2QiM18ObKGl PoAm338q+/QA8yQqq/sUcT6DSAPfj9A5WOBBm3ME/g7L+Yg6aGJflSkwNEUviz22TwCz KMtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=USA1LPb1nNhfPr8YulQJKZZafUQGhETVMlPP0ATTuHw=; b=LtI6YhHAX3rKWBExzfsTMF62hwBgWn6sUr4wR8tSsfStYdcnaIPdHD2mXe+w69jf58 ne6czvObFjCvCuczKvfviMxvzToGhbwoFOEJNV4af7DVA+woeVvj3fNYX3+SJHoWUxTI bLECW1cPCJOshazLdddA46L6ZlMhiirrgv8j/MoAfeAHRPrmPwiLIhF2gxdJiAhzlCYI GUjQaR/Roj2wbdzci4Dqz2joa+5UFm05t0LxrG/S57ZKbhzJ3PbWdouv9FPKezwMNl+e 9D6SHOsahWwdIkRVMeJo6HenBmln3kkyhmFAj9v84m59eUZJHbW7kkn2fJZ3gTHQqXV5 /UwA== X-Gm-Message-State: AO0yUKV1ckJ6/WxW+r2bcpFdYNM7em7k1bScE778NdM13aBh1/bv3B3I SlTOYw7oxiiUoxXbOY1IxIiUkNO78vge9zks X-Google-Smtp-Source: AK7set/uM1/oR+yqugrjuEdG8kW4buLB8Q5SZAoe4MaBnMdjHyswwjDhJ0W1c1ov/VuD3iMo0Zj3hg== X-Received: by 2002:adf:f545:0:b0:2c5:4d8f:ff11 with SMTP id j5-20020adff545000000b002c54d8fff11mr139984wrp.61.1676328852884; Mon, 13 Feb 2023 14:54:12 -0800 (PST) Original-Received: from localhost ([109.78.14.217]) by smtp.gmail.com with ESMTPSA id y16-20020adff6d0000000b002c55521903bsm4698239wrp.51.2023.02.13.14.54.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 14:54:12 -0800 (PST) In-Reply-To: <20230213155859.EC4E9C13915@vcs2.savannah.gnu.org> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Mon, 13 Feb 2023 10:58:59 -0500 (EST)") Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=contovob@tcd.ie; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303244 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mattias Engdeg=C3=A5rd [2023-02-13 10:58 -0500] wrote: > branch: master > commit 8aef401b4f66a64ddfa9390590fb2cae1f96d522 > Author: Mattias Engdeg=C3=A5rd > Commit: Mattias Engdeg=C3=A5rd > > LAP optimiser: more stack reduction hoisting >=20=20=20=20=20 > Hoisting stack reduction ops allows them to coalesce and/or cancel out > pushing ops, and for useful operations to sink and combine, such as > not + goto-if-[not-]nil. >=20=20=20=20=20 > * lisp/emacs-lisp/byte-opt.el (byte-optimize-lapcode): > Add the rule >=20=20=20=20=20 > UNARY discardN-preserve-tos --> discardN-preserve-tos UNARY >=20=20=20=20=20 > where UNARY pops and pushes one value. >=20=20=20=20=20 > Generalise the rule >=20=20=20=20=20 > const discardN-preserve-tos --> discardN const >=20=20=20=20=20 > to any 0-ary op, not just const: varref, point, etc. I suspect the following test is failing as a result of this (I could bisect only to within =C2=B11 commit): --=-=-= Content-Type: text/plain Content-Disposition: inline; filename=map-tests.log -*- mode: compilation; default-directory: "~/.local/src/emacs-nox/" -*- Compilation started at Mon Feb 13 22:44:45 make TEST_LOAD_EL=no SELECTOR='"elt-gv"' test/map-tests make -C test map-tests make[1]: Entering directory '/home/blc/.local/src/emacs-nox/test' make[2]: Entering directory '/home/blc/.local/src/emacs-nox/test' GEN lisp/emacs-lisp/map-tests.log Running 1 tests (2023-02-13 22:44:45+0000, selector `"elt-gv"') Test test-map-elt-gv backtrace: signal(ert-test-failed (((should (map-empty-p map)) :form (map-empty ert-fail(((should (map-empty-p map)) :form (map-empty-p ((wrong-type #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name test-map-elt-gv :documentation "Test ert-run-or-rerun-test(#s(ert--stats :selector "elt-gv" :tests [#s(er ert-run-tests("elt-gv" #f(compiled-function (event-type &rest event- ert-run-tests-batch("elt-gv") ert-run-tests-batch-and-exit("elt-gv") eval((ert-run-tests-batch-and-exit '"elt-gv") t) command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/map-tests command-line() normal-top-level() Test test-map-elt-gv condition: (ert-test-failed ((should (map-empty-p map)) :form (map-empty-p ((wrong-type-argument number-or-marker-p nil))) :value nil)) FAILED 1/1 test-map-elt-gv (0.001755 sec) at lisp/emacs-lisp/map-tests.el:119 Ran 1 tests, 0 results as expected, 1 unexpected (2023-02-13 22:44:45+0000, 0.068526 sec) 1 unexpected results: FAILED test-map-elt-gv make[2]: *** [Makefile:174: lisp/emacs-lisp/map-tests.log] Error 1 make[2]: Leaving directory '/home/blc/.local/src/emacs-nox/test' make[1]: *** [Makefile:240: lisp/emacs-lisp/map-tests] Error 2 make[1]: Leaving directory '/home/blc/.local/src/emacs-nox/test' make: *** [Makefile:1100: test/map-tests] Error 2 Compilation exited abnormally with code 2 at Mon Feb 13 22:44:45 --=-=-= Content-Type: text/plain I don't immediately spot anything wrong with the test (but then I wrote it :). Could you (or someone else) please have a look? Thanks, -- Basil In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu) of 2023-02-13 built on tia Repository revision: b950b46f514989442fdd9937a0e96d53a3affa88 Repository branch: wt/master-nox System Description: Debian GNU/Linux bookworm/sid Configured using: 'configure 'CFLAGS=-O2 -march=native' -C --prefix=/home/blc/.local --program-suffix=-nox --enable-checking=structs --with-file-notification=yes --with-x-toolkit=no --without-x' Configured features: ACL DBUS GMP GNUTLS GPM JSON LCMS2 LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER SECCOMP SOUND SQLITE3 THREADS TREE_SITTER XIM ZLIB Important settings: value of $LANG: en_IE.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow regexp-opt sort mail-extr emacsbug message mailcap yank-media puny dired dnd dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils term/xterm xterm byte-opt gv bytecomp byte-compile rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 47621 6434) (symbols 48 5735 0) (strings 32 15012 1635) (string-bytes 1 434358) (vectors 16 8412) (vector-slots 8 104194 7244) (floats 8 24 44) (intervals 56 200 10) (buffers 984 10)) --=-=-=--