From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: file-equal-p Date: Thu, 16 Feb 2023 16:43:25 +0800 Message-ID: <87pmaaq9ua.fsf@yahoo.com> References: <87a61es8fh.fsf.ref@yahoo.com> <87a61es8fh.fsf@yahoo.com> <83fsb681me.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10515"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 16 09:47:00 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSZut-0002ZK-FT for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Feb 2023 09:46:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSZu8-000178-EC; Thu, 16 Feb 2023 03:46:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSZtt-00014F-9O for emacs-devel@gnu.org; Thu, 16 Feb 2023 03:46:06 -0500 Original-Received: from sonic313-37.consmr.mail.ne1.yahoo.com ([66.163.185.60]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSZtq-0004Qu-Id for emacs-devel@gnu.org; Thu, 16 Feb 2023 03:45:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676537151; bh=FKhvMEbOAZCDj9zBLYD/eit/80KSGK04JCc1oq7F/F4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=Gte7SDSS72yWQTO6VDEf6rM/UMaBR+5m80633iBvF5N6ajQgGpWNKIcxlwqZ0cCIr8vZBCw7MZ7Eg+xq6OZeXUFwT9uc6f+/73PU8CIOeuEt2UgqLvfLgmVhI7zpOfwJXZoZlwhBuh1WFfTeggychFBgDe7IoGmtWYC8DFf5XKTeHFfqRngwQIYTeLnRyPWMVMeBiVq9cRkOWvPEycUB9BQejIKPtBzIjYqqJORTPXmd/NWO7q6JsblaNFHtili4tlBclSrDqM4kvgPJ2v5xRF74LL9QjAx24cHnJDPnEA0epThDY7taiKXrbfgbJmPJvGSQbwrT8ny0X5mu2T0jtg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676537151; bh=TxSlcY+t4Bl53GG8towKtYnhGfxu6ZWvqV49xcf2E9G=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=M5crLJevOOgwMe6D4MKeLbqPk+v2UWXF2yy7cFwf18xVsKe282jdxMGtU5mgYZG85hq/zbXXYFRzyHlj7RDJzEVIelrxXFESQnQKC0a/VA9hctihHPg0jXGlzlwBJtxYNt/w2TfYx0pgc3QqjCZB2+afVFEq+qE0gMzCZ+hqqEhIz0Cb+mL5biDkjHIg6EHnVTv/KbmU0OBNdek+2hiSyE/afkRqk8HAu7UF6Qtzhtz5s+asXpW711XTa6dUapu3fggjGSMuMFcU2BcaZh8Na9PDpraRPj/E2wrcELAgvH9YOEXJRRxsMijGpQ0dBeNpWMD0qP1X0j45kdPQOF8SsA== X-YMail-OSG: qiYPHYsVM1n7QqDOBW939vOoAVob.ijwN6QR6JHlh58clysyLjHSde2h0_qg6TZ StgWWEfnEv_evEUOEI24Pcf4FMiB3y2hW.M2Qw6wHSTYapiuzqqrxyt64gFq1unA.1O6ojY3WQD5 2OHZir.WWae_lD9s7LFtfKfWwLnVhg1yASC1VZWzTVxAO6X.7C6Y0Z6Pki_zUTd.eAUJjB_G5WwD CLdEceUWd7rGkqx19PX2ifVG5zuZzALGxPnb6bCilylN7chQXmI6b90IS1paQnG8GTvJBjBEYtON Qb8CX8kHGPXOTQTnVuTRTxDyaMqCgdskgIw5vfRcACodexVHUwhficl_x3aWqd2GBDJgxu0tbIJj k_8L0sVbi142GV27TuQZAaxI7OTkuuscSNAMu6TP5zYHbS1JzZW6kPi7rvHRdI3dTeA21S5Baeie 0wuY18TslHP66acK.9xwbboZ.2k7kSHtwEV_ndZe4woQZvvonfvQJHGHzhmFXw5Y576z8f1PZtRc NtFmBUrzy6Kr9DPPuf2HhMcPsmeWftDTHHoI3RkOcH92var.xC.rXPvpwftJvlhG0WOIosWn.AFE DSUauWt8vYPt85xz2i_zCTzJQN7Ek4rOU3rEFDYUzuNchDrvfxFAS7CvhMaq9zeAj8h0PEr0Lveh Eel2gjJk.hSAkITe0C_KvTTnF1k.hiLa.x9YTEX0aof.rOfB5Bqkc0J6KumX3kQP40wgVZOK7L7I uBjteIpkJqbUFX24CYZ8hoVr7rCnwdhOeLt8ZX9Cs3eN9XtsTavD2ARF7EfDHYE4_KVHl6Vi_RqG Nn54SF.BUHtCmC_czXyXVVEylEAfJGxYPG1upKWZir X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Thu, 16 Feb 2023 08:45:51 +0000 Original-Received: by hermes--production-sg3-9fc5746c8-8hlql (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 83f17567f55054942a3f4b8a4b34097b; Thu, 16 Feb 2023 08:43:48 +0000 (UTC) In-Reply-To: <83fsb681me.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Feb 2023 10:18:17 +0200") X-Mailer: WebService/1.1.21183 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.185.60; envelope-from=luangruo@yahoo.com; helo=sonic313-37.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303383 Archived-At: Eli Zaretskii writes: > Fix Haiku? A 'stat' call accesses the directory and file's meta-data, > not the file itself, so what Haiku does makes no sense, IMO. > > But if you cannot fix Haiku, a suitable haiku-only change in > file-equal-p, whereby the access times are exempt from comparison, is > a possibility. Something like this? diff --git a/lisp/files.el b/lisp/files.el index b0ec6bb09d0..dcd17df166a 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -6360,7 +6360,17 @@ file-equal-p (let (f1-attr f2-attr) (and (setq f1-attr (file-attributes (file-truename file1))) (setq f2-attr (file-attributes (file-truename file2))) - (equal f1-attr f2-attr)))))) + (progn + ;; Haiku systems change the file's last access timestamp + ;; every time `stat' is called. Make sure to not compare + ;; the timestamps in that case. + (when (and (eq system-type 'haiku) + (consp (nthcdr 4 f1-attr)) + (consp (nthcdr 4 f2-attr))) + (ignore-errors + (setcar (nthcdr 4 f1-attr) nil) + (setcar (nthcdr 4 f2-attr) nil))) + (equal f1-attr f2-attr))))))) (defun file-in-directory-p (file dir) "Return non-nil if DIR is a parent directory of FILE. BTW, what if a file changes in between the calls to `file-atttributes' on any old GNU/Linux system? Thanks.