From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: Merging feature/android Date: Tue, 21 Mar 2023 08:48:04 +0100 Message-ID: <87pm92pmtn.fsf@gmail.com> References: <87edq7ztks.fsf.ref@yahoo.com> <87edq7ztks.fsf@yahoo.com> <874jqn9508.fsf@yahoo.com> <875yb3vftq.fsf@gmail.com> <87zg8f7h2d.fsf@yahoo.com> <871qlrvcc7.fsf@gmail.com> <87wn3jtwxg.fsf@gmail.com> <87v8j37ehz.fsf@yahoo.com> <87sfe7tr57.fsf@gmail.com> <87y1nzv18a.fsf@gmail.com> <87ilf27tt1.fsf@yahoo.com> <87jzziuzba.fsf@gmail.com> <87pm9a5n14.fsf@yahoo.com> <87bkkuulp5.fsf@gmail.com> <87wn3h4gld.fsf@yahoo.com> <87o7oru7i1.fsf@gmail.com> <87ttyj3i3u.fsf@yahoo.com> <87a6071xxt.fsf@yahoo.com> <87bkknr7io.fsf@gmail.com> <87355zqzbh.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1009"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , emacs-devel To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 21 08:48:47 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1peWjf-00006Q-77 for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Mar 2023 08:48:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peWj6-00058r-4N; Tue, 21 Mar 2023 03:48:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peWj3-00057r-T8 for emacs-devel@gnu.org; Tue, 21 Mar 2023 03:48:09 -0400 Original-Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1peWj2-0007Me-7E for emacs-devel@gnu.org; Tue, 21 Mar 2023 03:48:09 -0400 Original-Received: by mail-wr1-x431.google.com with SMTP id l12so12641350wrm.10 for ; Tue, 21 Mar 2023 00:48:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679384886; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=YMzQOXt/GPuldefiIabhDcLoGzbUnuKu/XpOpjMaHDM=; b=Qix4yyPbSox5q7LoyQJFl51N8nK3TkqUAUBJtN/can7yrTmUtvjKI9UDHdiN3VHeKW vMFwxH8lytSpc2uyA4zw6JyFPwnKhfVYjQXzTRbBxD6Q1PFZEstoaTZh8PaYASDvkGf5 1SruyNiRZPYKCRXfJlt51SFo5xiIxXLnoyyuFwAakCkuinVAieSKe831kci97Nr2z9jN vi7Xoa0qnTYR2bCfysfe/Zw1zz9IUglW3hL5gGwRdIAVx84tiZ8B8hggpRjVvm5zllt/ 1kYQS2CAfwh+A+4C5m8WCDCv1kATA7eeYsOWT3ES+El34YtfDazyc3hogpP4QPnD4m2G rFSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679384886; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YMzQOXt/GPuldefiIabhDcLoGzbUnuKu/XpOpjMaHDM=; b=6dk5j6zWD9+mbeaFrokFLYZuI6XDd5/rRzmqZTpHUI8rFQh8cgryeO4PMKfIqkjP80 h8m7PiKJ1ipULxB9cj44sO/RzIyDQTjMZvtVtIja1/psNNSoYEs7r5z11ni4kQJBs8lJ k0wiC/TvDByb+7KV06UaUhCP4RjFNL29AtlmXWweNjm0zg/zaJuWxkp/8pov0+QiTsuD 9uW32kbiQNx+Xxk8iU4tCcM5KszLeiUEcpWjMJwZzuWj0nKTSd/4cS1w1/DGQqRSAaqn ZkkpvwHG7bhFErX59HNPwGyAryVIAyFpxpA5AWBCc1up7Ev9R2EjnYaWR3LPst26ko9m MjPA== X-Gm-Message-State: AO0yUKVSwdIP+Zz4JLXu/WICyKFC2Cdf/wvRa/B8tRgmqzcIBqLuVsxJ 7na4t0UonmIqUzPL+9cK/7KpjQ9NoD0= X-Google-Smtp-Source: AK7set+rbCuY6qiUKaQY+wnJLSByGfaPxyTCgdFSgjqTIt1Gb1oZWEovhYnSJ39IFvR3xkPX0QySZg== X-Received: by 2002:a05:6000:128f:b0:2d1:ac83:d94f with SMTP id f15-20020a056000128f00b002d1ac83d94fmr1282745wrx.55.1679384885807; Tue, 21 Mar 2023 00:48:05 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id q7-20020adff947000000b002d419f661d6sm9121069wrr.82.2023.03.21.00.48.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 00:48:05 -0700 (PDT) In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Mon, 20 Mar 2023 17:34:22 +0000") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=rpluim@gmail.com; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304630 Archived-At: >>>>> On Mon, 20 Mar 2023 17:34:22 +0000, Jo=C3=A3o T=C3=A1vora said: Jo=C3=A3o> On Mon, Mar 20, 2023 at 2:20=E2=80=AFPM Robert Pluim wrote: >>=20 >> >>>>> On Mon, 20 Mar 2023 12:23:27 +0100, Robert Pluim said: >>=20 >> >>>>> On Mon, 20 Mar 2023 19:09:34 +0800, Po Lu = said: Robert> Po Lu> Do you see the clangd problem on master as well? >>=20 Robert> I do now, although I could have sworn it wasn=CA=BCt failing ea= rlier. >>=20 Robert> Po Lu> I have a feeling this is some problem with clangd, but i= t reliably Robert> Po Lu> crashes for me while running this test. >>=20 Robert> Po Lu> This is: >>=20 Robert> Po Lu> clangd version 15.0.0 (Fedora 15.0.0-3.fc37) >>=20 Robert> Debian clangd version 11.0.1-2 >>=20 Robert> here. Looks like it=CA=BCs an issue on master, I see if I can b= isect. >>=20 >> OK, so on master originally this test used rust, and was skipped on = my >> system, but now it=CA=BCs using clangd, and failing. Jo=C3=A3o, any = ideas? >> Should we just add a clangd version test to >> `eglot-test-diagnostic-tags-unnecessary-code'? Jo=C3=A3o> Hello, Jo=C3=A3o> Took me quite a while of rummaging to figure out what you are Jo=C3=A3o> talking about here. Consider changing the subject line or Jo=C3=A3o> adding a bit more context next time. Sounds like you forgot to do (package-install 'telepathy) ;-) Jo=C3=A3o> _If_ I understand correctly, Robert, your run of Jo=C3=A3o> eglot-test-diagnostic-tags-unnecessary-code is failing Jo=C3=A3o> because of a face mismatch, presumably because only Jo=C3=A3o> clangd-11 is installed in your system, but if you install Jo=C3=A3o> a more recent clangd it goes away? If so, yes, I think a Jo=C3=A3o> version check is appropriate, yes. Yes. Version 11 fails, version 17 works, I don=CA=BCt know where the cutoff point is. Which version do you use? Robert --=20