From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: eglot-test-diagnostic-tags-unnecessary-code fails with certain clangd versions Date: Wed, 22 Mar 2023 11:19:06 +0100 Message-ID: <87pm91nl5x.fsf@gmail.com> References: <87edq7ztks.fsf.ref@yahoo.com> <87a6071xxt.fsf@yahoo.com> <87bkknr7io.fsf@gmail.com> <87355zqzbh.fsf@gmail.com> <87pm92pmtn.fsf@gmail.com> <87lejqp7zc.fsf_-_@gmail.com> <87h6uep63a.fsf@gmail.com> <87fs9yqhk4.fsf@gmx.de> <87355yqfsb.fsf@gmx.de> <87y1nqp09x.fsf@gmx.de> <875yauoyfo.fsf@gmail.com> <87ttydnn58.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10630"; mail-complaints-to="usenet@ciao.gmane.io" Cc: chad , Michael Albinus , Po Lu , emacs-devel To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 22 11:19:51 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pevZO-0002Ze-U2 for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Mar 2023 11:19:51 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pevYn-0008HD-Ky; Wed, 22 Mar 2023 06:19:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pevYm-0008Gw-FI for emacs-devel@gnu.org; Wed, 22 Mar 2023 06:19:12 -0400 Original-Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pevYk-00052Y-4k for emacs-devel@gnu.org; Wed, 22 Mar 2023 06:19:12 -0400 Original-Received: by mail-wr1-x42d.google.com with SMTP id r29so16397742wra.13 for ; Wed, 22 Mar 2023 03:19:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679480348; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=mJqKwAg4mBlBeLV0Ebi5Ixo3JzDdCX8/eysWgbDQvq0=; b=Tg7kgI3ikOXZN95LO3dMxiijdePq9xZxZb0hk4K0kdOgkzjdGc8u9drJGFRjVZcTUs +Z+4VzwPbGqKcGCJrOph49w+YeVEK119zZao+OQXLvjx2PhZ48sbYABwmRjNYRJ4Axvg Cok2og+1N7qbIW1gwMjHhfYN8b1Uwi4Zg7CtClO9hN9GlVgY05eNeTmx9e5vzyFVLLDT iq17hR1I05vagSCm+qpQ8U0+xxTtxVJsrQ6d31TzxqK0u3qYDupa/Jn/ha6yA9kzCLy6 Y8SCHBdXt3ErCPTgCURSvVnNdRXk4VfhU8JFl2UIW8SrX22g792ky/B6K90dfmlPQizw kc8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679480348; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mJqKwAg4mBlBeLV0Ebi5Ixo3JzDdCX8/eysWgbDQvq0=; b=NMbiYzPD3r22w+CTzQVdgFHvoxMT8ui4GJWqCOunnM8MHAc/6u/N/pCbvCAfTknIHH TuZQxtHDunSSa3FphCtuD9vDZArzm8gZ1UXWmY1OERjKtMh6frn3TG+UycZGRgFPmtTb oUwbM1TjTD8HZ1CKdKuwNQwv8WTBKDag0qE9ErXST7CKZuY8k4qeSKOBEVSa5ESbh5wE jdrmEIvXj3JSTj46vZ6IfM5hsQjWpS1zdq+IvQ7NSLecM/xKn6rFBbFG9nvrbko6pl/4 eMvkzYJAm0qJVIaGjTbWhMmGgN9hpFVWf8yrSAm5j6lDpWtxH+eGmV1c1oDMDLKcxKPb e00w== X-Gm-Message-State: AO0yUKVwwyONvXMSqcPUFlecxnfViid1/xrRTle3vdFPSklTqoEMpe46 sNRZTiPYYhiu4Sw5dLLq4ascarBKw1I= X-Google-Smtp-Source: AK7set99WpcqRVixsIiq0+0+sGpdlnZMTkqbsNXwM7MbV9lwRJBoErIYv8U5A42MADEj144gqio43A== X-Received: by 2002:a5d:49cb:0:b0:2ce:a6f6:edca with SMTP id t11-20020a5d49cb000000b002cea6f6edcamr4404836wrs.55.1679480347878; Wed, 22 Mar 2023 03:19:07 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id a6-20020a056000100600b002c8ed82c56csm13511962wrx.116.2023.03.22.03.19.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 03:19:07 -0700 (PDT) In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Wed, 22 Mar 2023 09:45:26 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=rpluim@gmail.com; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304700 Archived-At: >>>>> On Wed, 22 Mar 2023 09:45:26 +0000, Jo=C3=A3o T=C3=A1vora said: Jo=C3=A3o> What I meant rather, was trying to install version 14 from o= ne of Jo=C3=A3o> those sources I listed earlier. Perhaps all that we'll see = is that Jo=C3=A3o> instead of: Jo=C3=A3o> clangd-13 libclang-common-13-dev libclang-cpp13 libllvm13 Jo=C3=A3o> we'll see Jo=C3=A3o> clangd-14 libclang-common-14-dev libclang-cpp14 libllvm14 Jo=C3=A3o> If the former is acceptable so should be the latter, especia= lly Jo=C3=A3o> if the installation of the support libraries is motivated by Jo=C3=A3o> clangd alone. Maybe. It=CA=BCs not on my list of things to try :-) Jo=C3=A3o> Anyway, I now pushed a version-checking patch to master. >>=20 >> Thanks, that test is skipped for me now (aside: is there any way to >> get ert to not spew the diagnostic output from commands such as clan= gd >> to the terminal?) Jo=C3=A3o> As far as I understand the output you mean, when running `ma= ke check` Jo=C3=A3o> all this output goes to a separate file. The output is very= useful for Jo=C3=A3o> debugging test failures. But maybe I'm not following: what = command Jo=C3=A3o> are you running exactly? The results go to a log file, but some of it also ends up on the terminal (this is not specific to eglot, it happens with other tests as well): $ make -C test eglot-tests make: Entering directory '/home/rpluim/repos/emacs/test' make[1]: Entering directory '/home/rpluim/repos/emacs/test' GEN lisp/progmodes/eglot-tests.log Running 50 tests (2023-03-22 11:15:47+0100, selector `(not (or (tag :unstab= le) (tag :nativecomp)))') [eglot-tests] [eglot-test-auto-detect-running-server]: test start [eglot] Connected! Server `clangd' now managing `(c-mode c-ts-mode c++-mode= c++-ts-mode)' buffers in project `project'. [eglot-tests] [eglot-test-auto-detect-running-server]: OK [eglot] Asking EGLOT (project/(c-mode c-ts-mode c++-mode c++-ts-mode)) poli= tely to terminate [jsonrpc] Server exited with status 9 [eglot-tests] Killing (cena.c coiso.c merdix.c), wiping /tmp/eglot--fixture= SVO44D, restoring nil passed 1/50 eglot-test-auto-detect-running-server (0.161681 sec) [eglot-tests] [eglot-test-auto-reconnect]: test start [eglot] Connected! Server `clangd' now managing `(c-mode c-ts-mode c++-mode= c++-ts-mode)' buffers in project `project'. [jsonrpc] Server exited with status 9 [eglot] (warning) Reconnecting after unexpected server exit. Warning (eglot): Reconnecting after unexpected server exit. [eglot] Connected! Server `clangd' now managing `(c-mode c-ts-mode c++-mode= c++-ts-mode)' buffers in project `project'. [eglot] Reconnected! [jsonrpc] Server exited with status 9 [eglot] (warning) Not auto-reconnecting, last one didn't last long. Warning (eglot): Not auto-reconnecting, last one didn't last long. [eglot-tests] [eglot-test-auto-reconnect]: OK [eglot-tests] Killing (thingy.c), wiping /tmp/eglot--fixture0bo9S2, restori= ng nil passed 2/50 eglot-test-auto-reconnect (2.342542 sec) [eglot-tests] [eglot-test-auto-shutdown]: test start [eglot] Connected! Server `clangd' now managing `(c-mode c-ts-mode c++-mode= c++-ts-mode)' buffers in project `project'. [eglot] Asking EGLOT (project/(c-mode c-ts-mode c++-mode c++-ts-mode)) poli= tely to terminate [jsonrpc] Server exited with status 9 [eglot-tests] [eglot-test-auto-shutdown]: OK [eglot-tests] Killing nil, wiping /tmp/eglot--fixtureFDN5l3, restoring nil passed 3/50 eglot-test-auto-shutdown (0.162224 sec) skipped 4/50 eglot-test-basic-completions (0.000283 sec) [eglot-tests] [eglot-test-basic-diagnostics]: test start [eglot] Connected! Server `clangd' now managing `(c-mode c-ts-mode c++-mode= c++-ts-mode)' buffers in project `diag-project'. [eglot-tests] waiting for `(string=3D method textDocument/publishDiagnostic= s)' . [eglot-tests] detected: textDocument/publishDiagnostics [eglot-tests] [eglot-test-basic-diagnostics]: OK [eglot] Asking EGLOT (diag-project/(c-mode c-ts-mode c++-mode c++-ts-mode))= politely to terminate [jsonrpc] Server exited with status 9 [eglot-tests] Killing (main.c), wiping /tmp/eglot--fixtureA3MDfA, restoring= nil passed 5/50 eglot-test-basic-diagnostics (0.339335 sec) skipped 6/50 eglot-test-basic-xref (0.001034 sec) passed 7/50 eglot-test-capabilities (0.000371 sec) passed 8/50 eglot-test-dcase (0.000354 sec) passed 9/50 eglot-test-dcase-issue-452 (0.000252 sec) skipped 10/50 eglot-test-diagnostic-tags-unnecessary-code (0.023891 sec) skipped 11/50 eglot-test-eclipse-connect (0.000277 sec) skipped 12/50 eglot-test-eldoc-after-completions (0.000297 sec) [eglot-tests] [eglot-test-ensure]: test start [eglot] Connected! Server `clangd' now managing `(c-mode c-ts-mode c++-mode= c++-ts-mode)' buffers in project `project'. [eglot-tests] [eglot-test-ensure]: OK [eglot] Asking EGLOT (project/(c-mode c-ts-mode c++-mode c++-ts-mode)) poli= tely to terminate [jsonrpc] Server exited with status 9 [eglot-tests] Killing (foo.c bar.c), wiping /tmp/eglot--fixtureUZO630, rest= oring (c-mode-hook) passed 13/50 eglot-test-ensure (0.242147 sec) passed 14/50 eglot-test-glob-test (0.084042 sec) skipped 15/50 eglot-test-javascript-basic (0.000492 sec) skipped 16/50 eglot-test-json-basic (0.000390 sec) [eglot-tests] [eglot-test-lsp-abiding-column]: test start [eglot] Connected! Server `clangd' now managing `(c-mode)' buffers in proje= ct `project'. [eglot-tests] waiting for `(should (equal 71 (cadddr (cadadr (aref (cadddr = params) 0)))))' [eglot-tests] detected: textDocument/didChange [eglot-tests] [eglot-test-lsp-abiding-column]: OK [eglot] Asking EGLOT (project/(c-mode)) politely to terminate [jsonrpc] Server exited with status 9 [eglot-tests] Killing (foo.c), wiping /tmp/eglot--fixturejFxISB, restoring = nil passed 17/50 eglot-test-lsp-abiding-column (0.181948 sec) skipped 18/50 eglot-test-multiline-eldoc (0.000361 sec) skipped 19/50 eglot-test-non-unique-completions (0.000314 sec) skipped 20/50 eglot-test-path-to-uri-windows (0.000125 sec) skipped 21/50 eglot-test-project-wide-diagnostics-rust-analyzer (0.0002= 76 sec) skipped 22/50 eglot-test-project-wide-diagnostics-typescript (0.000297 = sec) skipped 23/50 eglot-test-python-autopep-formatting (0.000262 sec) skipped 24/50 eglot-test-python-yapf-formatting (0.000260 sec) [eglot-tests] [eglot-test-rename-a-symbol]: test start [eglot] Connected! Server `clangd' now managing `(c-mode c-ts-mode c++-mode= c++-ts-mode)' buffers in project `rename-project'. [eglot] applying 2 edits to `main.c'...=20 [eglot] applying 2 edits to `main.c'...done [eglot] Edit successful! [eglot-tests] [eglot-test-rename-a-symbol]: OK [eglot] Asking EGLOT (rename-project/(c-mode c-ts-mode c++-mode c++-ts-mode= )) politely to terminate [jsonrpc] Server exited with status 9 [eglot-tests] Killing (main.c), wiping /tmp/eglot--fixtureVbF4jY, restoring= nil passed 25/50 eglot-test-rename-a-symbol (0.153973 sec) skipped 26/50 eglot-test-rust-analyzer-hover-after-edit (0.000611 sec) skipped 27/50 eglot-test-rust-analyzer-watches-files (0.000545 sec) skipped 28/50 eglot-test-rust-on-type-formatting (0.000578 sec) [eglot-tests] [eglot-test-same-server-multi-mode]: test start [eglot] Connected! Server `clangd' now managing `(c++-mode c-mode c-ts-mode= c++-ts-mode)' buffers in project `project'. [eglot-tests] [eglot-test-same-server-multi-mode]: OK [eglot] Asking EGLOT (project/(c++-mode c-mode c-ts-mode c++-ts-mode)) poli= tely to terminate [jsonrpc] Server exited with status 9 [eglot-tests] Killing (foo.cpp foolib.h foolib.c), wiping /tmp/eglot--fixtu= re1WKNsB, restoring nil passed 29/50 eglot-test-same-server-multi-mode (0.156214 sec) passed 30/50 eglot-test-server-programs-class-name-and-contact-spec (0= .001711 sec) passed 31/50 eglot-test-server-programs-class-name-and-plist (0.000274= sec) passed 32/50 eglot-test-server-programs-executable-multiple-major-mode= s (0.000292 sec) passed 33/50 eglot-test-server-programs-executable-with-arg (0.000279 = sec) passed 34/50 eglot-test-server-programs-executable-with-args-and-autop= ort (0.000266 sec) passed 35/50 eglot-test-server-programs-function (0.000302 sec) passed 36/50 eglot-test-server-programs-guess-lang (0.000503 sec) passed 37/50 eglot-test-server-programs-host-and-port (0.000304 sec) passed 38/50 eglot-test-server-programs-host-and-port-and-tcp-args (0.= 000265 sec) passed 39/50 eglot-test-server-programs-simple-executable (0.000274 se= c) passed 40/50 eglot-test-server-programs-simple-missing-executable (0.0= 00285 sec) skipped 41/50 eglot-test-single-line-eldoc (0.000343 sec) [eglot-tests] [eglot-test-slow-async-connection]: test start [eglot] Waiting in background for server `EGLOT (project/(c-mode))' [eglot] Connected! Server `clangd' now managing `(c-mode)' buffers in proje= ct `project'. [eglot-tests] [eglot-test-slow-async-connection]: OK [eglot] Asking EGLOT (project/(c-mode)) politely to terminate [jsonrpc] Server exited with status 9 [eglot-tests] Killing (something.c), wiping /tmp/eglot--fixtureGOw9Qx, rest= oring nil passed 42/50 eglot-test-slow-async-connection (2.219000 sec) [eglot-tests] [eglot-test-slow-sync-connection-intime]: test start [eglot] Connected! Server `clangd' now managing `(c-mode)' buffers in proje= ct `project'. [eglot-tests] [eglot-test-slow-sync-connection-intime]: OK [eglot] Asking EGLOT (project/(c-mode)) politely to terminate [jsonrpc] Server exited with status 9 [eglot-tests] Killing (something.c), wiping /tmp/eglot--fixturedlRt53, rest= oring nil passed 43/50 eglot-test-slow-sync-connection-intime (1.154543 sec) [eglot-tests] [eglot-test-slow-sync-connection-wait]: test start [eglot] Connected! Server `clangd' now managing `(c-mode)' buffers in proje= ct `project'. [eglot-tests] [eglot-test-slow-sync-connection-wait]: OK [eglot] Asking EGLOT (project/(c-mode)) politely to terminate [jsonrpc] Server exited with status 9 [eglot-tests] Killing (something.c), wiping /tmp/eglot--fixtureH37RjM, rest= oring nil passed 44/50 eglot-test-slow-sync-connection-wait (1.160179 sec) [eglot-tests] [eglot-test-slow-sync-timeout]: test start [jsonrpc] Server exited with status 9 [eglot-tests] [eglot-test-slow-sync-timeout]: OK [eglot-tests] Killing (something.c), wiping /tmp/eglot--fixturecLAgnU, rest= oring nil passed 45/50 eglot-test-slow-sync-timeout (1.131108 sec) skipped 46/50 eglot-test-snippet-completions (0.000943 sec) skipped 47/50 eglot-test-snippet-completions-with-company (0.000599 sec) passed 48/50 eglot-test-strict-interfaces (0.000569 sec) [eglot-tests] [eglot-test-tramp-test]: test start [eglot] Connected! Server `clangd' now managing `(c-mode c-ts-mode c++-mode= c++-ts-mode)' buffers in project `project'. [eglot-tests] [eglot-test-tramp-test]: OK [eglot] Asking EGLOT (project/(c-mode c-ts-mode c++-mode c++-ts-mode)) poli= tely to terminate [jsonrpc] Server exited with status 9 [eglot-tests] Killing (cena.c coiso.c merdix.c), wiping /mock:rltb:/tmp/egl= ot--fixturezOSKmQ, restoring nil passed 49/50 eglot-test-tramp-test (0.632109 sec) [eglot-tests] [eglot-test-tramp-test-2]: test start [eglot] Connected! Server `clangd' now managing `(c-mode)' buffers in proje= ct `project'. [eglot-tests] waiting for `(should (equal 71 (cadddr (cadadr (aref (cadddr = params) 0)))))' [eglot-tests] detected: textDocument/didChange [eglot-tests] [eglot-test-tramp-test-2]: OK [eglot] Asking EGLOT (project/(c-mode)) politely to terminate [jsonrpc] Server exited with status 9 [eglot-tests] Killing (foo.c), wiping /mock:rltb:/tmp/eglot--fixture8XZVqO,= restoring nil File is missing: /mock:rltb:/tmp/eglot--fixture8XZVqO/project/foo.c~ passed 50/50 eglot-test-tramp-test-2 (0.412540 sec) Ran 50 tests, 30 results as expected, 0 unexpected, 20 skipped (2023-03-22 = 11:15:57+0100, 10.577235 sec) 20 skipped results: SKIPPED eglot-test-basic-completions SKIPPED eglot-test-basic-xref SKIPPED eglot-test-diagnostic-tags-unnecessary-code SKIPPED eglot-test-eclipse-connect SKIPPED eglot-test-eldoc-after-completions SKIPPED eglot-test-javascript-basic SKIPPED eglot-test-json-basic SKIPPED eglot-test-multiline-eldoc SKIPPED eglot-test-non-unique-completions SKIPPED eglot-test-path-to-uri-windows SKIPPED eglot-test-project-wide-diagnostics-rust-analyzer SKIPPED eglot-test-project-wide-diagnostics-typescript SKIPPED eglot-test-python-autopep-formatting SKIPPED eglot-test-python-yapf-formatting SKIPPED eglot-test-rust-analyzer-hover-after-edit SKIPPED eglot-test-rust-analyzer-watches-files SKIPPED eglot-test-rust-on-type-formatting SKIPPED eglot-test-single-line-eldoc SKIPPED eglot-test-snippet-completions SKIPPED eglot-test-snippet-completions-with-company make[1]: Leaving directory '/home/rpluim/repos/emacs/test' make: Leaving directory '/home/rpluim/repos/emacs/test' Robert --=20