From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: Is it valid to call isearch-filter-predicate outside isearch? Date: Thu, 01 Jun 2023 11:48:10 +0000 Message-ID: <87pm6f9zet.fsf@localhost> References: <875y8nks9t.fsf@localhost> <86pm6sb5g8.fsf@mail.linkov.net> <87ttvsn77s.fsf@localhost> <83edmwfz6p.fsf@gnu.org> <87r0qwk6bz.fsf@localhost> <83ttvseg3k.fsf@gnu.org> <87o7m0k1li.fsf@localhost> <87pm6g14hy.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26397"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 01 13:44:13 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4giy-0006ef-Cg for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Jun 2023 13:44:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q4gia-00078s-OA; Thu, 01 Jun 2023 07:43:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4giZ-00075Q-16 for emacs-devel@gnu.org; Thu, 01 Jun 2023 07:43:47 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4giW-0006pp-TW for emacs-devel@gnu.org; Thu, 01 Jun 2023 07:43:46 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 777AC240101 for ; Thu, 1 Jun 2023 13:43:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1685619821; bh=FBpFh/xqKVqd4jlDyFido4qok23F0jXyPIhJYYRzzB8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=kpMfPl/C6zr0x9pHu6JkMrUFriVkNxJt2wa8L1RCagS9iWZ/6WmE8BfuMO/yE3prk zPNQg964RsC0SuE9ivwpcZATfwBgp8Z0nVAwLmY6SOD4iNA3FUY9QUWKC7QcvGbZQb jL0d+x4VvK5EioEJsBvh+fDc/pDR6vcfOxCqN7LlzYSPow8Z2DOtVL0EhfMxw0xaE7 0RoadCjZViiSOJ1ESHoDHJtpGUGZcmj/JK2e1QY6usMWy3MHHU8fAd+YVRBG/1PoOx a5HHHPaPnWXSCcspwP9e9tqq+c/tHCAidA+0rjK8gsPdCGWinsUoQ4TBgt5Gk7EuMW uWp7ToE1fEOBg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QX45n0P5Zz9rxR; Thu, 1 Jun 2023 13:43:41 +0200 (CEST) In-Reply-To: <87pm6g14hy.fsf@web.de> Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306509 Archived-At: Michael Heerdegen writes: >> Sure. I have no issue with this. That's why I asked to add a word of >> warning about the state of affairs to the docstring. It is not normal >> that major mode-specific predicates are used elsewhere. > > This is not an appropriate description of reality: replace is more or > less a part of isearch, and nearly all of the other hits are of the type > "implement isearch behavior for this mode/ this place" (e.g. for the > minibuffer in "simple.el"). Yes. And they selectively use some parts of isearch but not other. If a third-party library is to re-bind `isearch-filter-predicate' what should it expect about the environment? For now, it appears that even though `isearch-mode-end-hook' is not always called, `isearch-clean-overlays' does. But it may not be in future, for example. Potentially breaking the working code. More accurate documentation would at least provide a guide what to expect. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at