Jumping to message by ID

Jumping to message by ID

[Andrea Monaco]

I thought of a feature for rmail.  If point is on a message id, for
example those in the In-reply-to and References field, then pressing
ENTER or some key could show the message with that id, if such is found.

I would occasionally find this feature useful.  Let me know.



Andrea Monaco

Re: Jumping to message by ID

[Eli Zaretskii]

> From: Andrea Monaco <andrea.monaco@autistici.org>
> Date: Sat, 09 Sep 2023 11:00:11 +0200
> 
> 
> I thought of a feature for rmail.  If point is on a message id, for
> example those in the In-reply-to and References field, then pressing
> ENTER or some key could show the message with that id, if such is found.
> 
> I would occasionally find this feature useful.  Let me know.

Sounds useful, please feel free to work on adding this.

Thanks.

[PATCH] Jumping to message by ID

[Andrea Monaco]

diff --git a/lisp/mail/rmail.el b/lisp/mail/rmail.el
index f76600000c9..aaccf8b9b24 100644
--- a/lisp/mail/rmail.el
+++ b/lisp/mail/rmail.el
@@ -2699,6 +2699,35 @@ rmail-show-message
     (if blurb
 	(message blurb))))
 
+(defun rmail-get-email-address-at-point ()
+  "Return the email address or message id around point, or nil if none is present."
+  (save-mark-and-excursion
+    (let ((p (point)))
+      (unless (= p (point-max))
+	(forward-char))
+      (if (and
+	   (search-backward "<" nil t)
+	   (let ((end (re-search-forward "<.*@.*>" nil t)))
+	     (and end (> end p))))
+	  (match-string 0)))))
+
+(defun rmail-show-message-by-id (&optional id)
+  "Show message with given Message ID, defaulting to the id around point."
+  (interactive
+   (list (rmail-get-email-address-at-point)))
+  (unless id
+    (error "No message ID around point"))
+  (let ((id (rmail-get-email-address-at-point)))
+    (when id
+      (unless (and rmail-summary-message-parents-vector
+		   (= (length rmail-summary-message-parents-vector)
+		      (1+ rmail-total-messages)))
+	(rmail-summary-fill-message-parents-and-descs-vectors))
+      (let ((entry (assoc id (gethash id rmail-summary-message-ids-hash-table))))
+	(if entry
+	    (rmail-show-message (cdr entry))
+	  (error (concat "No message with ID " id " found")))))))
+
 (defun rmail-is-text-p ()
   "Return t if the region contains a text message, nil otherwise."
   (save-excursion



New command to jump to a message with the ID around point

* lisp/mail/rmail.el (rmail-get-email-address-at-point)
    (rmail-show-message-by-id): New functions.



Andrea Monaco

Re: [PATCH] Jumping to message by ID

[Eli Zaretskii]

> From: Andrea Monaco <andrea.monaco@autistici.org>
> Cc: emacs-devel@gnu.org
> Date: Fri, 20 Oct 2023 10:09:55 +0200
> 
> 
> +(defun rmail-get-email-address-at-point ()
> +  "Return the email address or message id around point, or nil if none is present."

The name of the function doesn't seem to reflect what it does.  Can
you come up with a better name?

> +(defun rmail-show-message-by-id (&optional id)
> +  "Show message with given Message ID, defaulting to the id around point."
> +  (interactive
> +   (list (rmail-get-email-address-at-point)))
> +  (unless id
> +    (error "No message ID around point"))
> +  (let ((id (rmail-get-email-address-at-point)))
> +    (when id
> +      (unless (and rmail-summary-message-parents-vector
> +		   (= (length rmail-summary-message-parents-vector)
> +		      (1+ rmail-total-messages)))
> +	(rmail-summary-fill-message-parents-and-descs-vectors))
> +      (let ((entry (assoc id (gethash id rmail-summary-message-ids-hash-table))))
> +	(if entry
> +	    (rmail-show-message (cdr entry))
> +	  (error (concat "No message with ID " id " found")))))))
> +

If I have many hundreds of messages in my INBOX (e.g., I have almost
2100 now where I'm typing this, and this number is not an anomaly in
my Rmail use patterns), wouldn't
rmail-summary-fill-message-parents-and-descs-vectors take a
significant time?  If so, perhaps it would make sense to update the
data each time we update the summary, instead of punishing the first
call after getting new email?

Thanks.

Re: [PATCH] Jumping to message by ID

[Andrea Monaco]

  > The name of the function doesn't seem to reflect what it does.  Can
  > you come up with a better name?

What about rmail-match-email-address-around-point?  Of course I'm
looking for message ids, but those have the same syntax as email
addresses and the latter are surely known to whoever reads my function.


  > If so, perhaps it would make sense to update the data each time we
  > update the summary, instead of punishing the first call after
  > getting new email?

You're right, that's the same issue as rmail-summary-by-thread.

In this case I only need the message id hash table so I could just
update that, at the risk of making it out of sync with the vectors of
parents and descendants.

The only solution is updating all the data structures each time new mail
is got or mail is expunged, instead of recreating them from scratch; I
can look into that.



Andrea Monaco

Re: [PATCH] Jumping to message by ID

[Adam Porter]

> What about rmail-match-email-address-around-point?  Of course I'm
> looking for message ids, but those have the same syntax as email
> addresses and the latter are surely known to whoever reads my function.
Friendly FYI:

   goto-address-find-address-at-point is a native-compiled Lisp function
   in ‘goto-addr.el’.

   (goto-address-find-address-at-point)

   Find e-mail address around or before point.
   Then search backwards to beginning of line for the start of an e-mail
   address.  If no e-mail address found, return nil.

Re: [PATCH] Jumping to message by ID

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

This is a useful change -- but it could be even more useful
if it had a user interface that did not require an additioal
command,  I don't see how to do that -- do you?

-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)