From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: Permanently fix org versioning breakage during builds? Date: Sun, 24 Dec 2023 18:56:02 +0000 Message-ID: <87plyv1lbx.fsf@localhost> References: <25989.50971.995591.385250@google.com> <87a5q0dc9m.fsf@localhost> <87edfbbyzm.fsf@localhost> <875y0n4px0.fsf@localhost> <87v88n3515.fsf@localhost> <87mstz34ec.fsf@localhost> <87jzp3344t.fsf@localhost> <87cyuv320s.fsf@localhost> <83mstzbfos.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1252"; mail-complaints-to="usenet@ciao.gmane.io" Cc: joaotavora@gmail.com, raman@google.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 24 19:53:19 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rHTbC-000AeF-K8 for ged-emacs-devel@m.gmane-mx.org; Sun, 24 Dec 2023 19:53:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rHTaz-0007PF-7o; Sun, 24 Dec 2023 13:53:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHTao-0007Le-Ja for emacs-devel@gnu.org; Sun, 24 Dec 2023 13:52:54 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHTal-0006wV-PQ for emacs-devel@gnu.org; Sun, 24 Dec 2023 13:52:53 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 28444240028 for ; Sun, 24 Dec 2023 19:52:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1703443970; bh=vWbDQdhyoD5GeZfYnEIW4iZO63XqKbt7rBcJ3zvtAI0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=YQy9rp/JSPBSy6qLXqJJI5aJu3sg7yAOXBD39wHzUXOFmWQO+jPzzWsc6RYtXmW1Y nN0LFJaDzaTZaOYdrw+lA20rZyGfq0etywiq2wgiBcJsgqx6+3LXp1y5qt90QdEVau Q7DZiZtm937Xy/oevyiHJXYICBZ83k3EOYS8Cc1NWnZYfrGP4pkOunsS4pnSsbyyix +u1lpqtMEUtsdUsm40rAjvyvD2qwjojxxvwVrMTHoV92hwbEOBuLDpt2HFOFfWbeH4 zZBKcwkwCadYCaXo4c8Crx+Zmg5L9LE9MivXMarwLidMr/fySeTuggonesLccyerbI BnGQtyY6ZqOWw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Syqss50Jjz9rxB; Sun, 24 Dec 2023 19:52:49 +0100 (CET) In-Reply-To: <83mstzbfos.fsf@gnu.org> Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314183 Archived-At: Eli Zaretskii writes: >> org-assert-version is the best we came up with. >> If you know a concrete idea how to solve it differently, feel free to >> share it. > > Why not just let things break when incompatible changes in Org macros > are installed? We do that for any other Lisp file in the repository > that defines macros used by other files. Why cannot Org do the same > when it is compiled as part of the Emacs build? Org can. However, breaking Emacs builds is not the main purpose of org-assert-version. The bigger problem I am trying to solve is obscure breakage when people upgrade Org mode or mix built-in and newer Org mode in their init files. > IOW, why not simply disable the version test as part of the Emacs > build, and leave the breakage for those cases where (a) changes in > macros are really incompatible and (b) they affect Org code that is > being run as part of the build? That's what the patch I shared is about. But I still need to check that the patch will not break detection of loading mixed Org versions from init.el. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at