From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: Add Tango and Adwaita icons for the toolbar Date: Sat, 04 May 2024 17:48:24 +0800 Message-ID: <87plu19ac7.fsf@yahoo.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15153"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: "Ergus via Emacs development discussions." To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 04 11:49:19 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s3C19-0003ny-EK for ged-emacs-devel@m.gmane-mx.org; Sat, 04 May 2024 11:49:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s3C0Y-0002ML-F2; Sat, 04 May 2024 05:48:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3C0X-0002MA-GA for emacs-devel@gnu.org; Sat, 04 May 2024 05:48:41 -0400 Original-Received: from sonic305-20.consmr.mail.ne1.yahoo.com ([66.163.185.146]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s3C0V-0004En-8m for emacs-devel@gnu.org; Sat, 04 May 2024 05:48:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1714816117; bh=/73lBEdEPP2iTVllna0CXXqElW+vknMFmiW6Wu0NXbw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=MNxuToE20bXPMWSGqVLK2/YEHvDIuHhbuNvTAZ83df3PLjdH019FyPa4g78myUtpW3zRo3Rw3n/fGAINisvZ9GWhiUo9QVqQfGbuNdG1S4+y1k8+fM2G/dyhpNDxsy/FlKHeueEvDZ3oag1fxEpDWtWLEQ2pFHj6gY3sFcFETlKFcCA7esD/cWh/V5U1yFOEtQsO6Ec7EFjvzqPkDXz00RBjVbeb2OeTyjvJQrnTCXq3/XZaXWchZnvw66yoIEHMOSYIhlbK1Rq9eJ0DKZfYfIb0Q23sFk9tHHOVFz9mAkEV3CRAQRQK8sxdbVHYkePDep5TvdmYeQvilY5c/GDtpA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1714816117; bh=QOuOAMrGSubpOX65qj4RKCwFL35J80cItV1iLfTINuV=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=n/gaxxrB80d7M2nPznlmCEhw8hIgd2MveA1ZKcWhNYRZqXkR5SZc0ZglqCC5ZG7IvRjy47MokTf0tANpnzkSzVnHLNqKC4q0QUpjNyNJCTkXVGEqbfyFo9Im9lYOlfFOIQmhvqBhyJ8l0eU+q+bn8f0JL3ijPG/3yEjpTTG1wKf/P732VNlbZ/GdnNA3l596G1K5r8pPMPptGcc26EsYNSrujnkWwOetzVMLxS3UHHcAhxfplJywSMCwfECwwsEAO9NOxDDRcsLdZadotCoPyR4dBA9n45ZInii1/b30MwQ3C2LMcDGjyYGhM6VLv0h+YkHwuZHfLqamxzBDU6VZjg== X-YMail-OSG: JvUkl.0VM1mvuhj6D5FYE_rn9s7YLmkpqDLn2EeM5De2mutMqkchdwCnkLXfhW_ LVmgtf6tG4YGK.o.1yjPxYT30FIF7qqoXZukRzDF.PtEG3gW4dzvnXaeGh2cY3lrIPU9zcE_vSj. 9s1H3Fe.Ivwj79cJB8ZA.2CiBY7ARlJLgFI5P6whvwV7EJGcO6sPtiCOhPUDf541gktJCZD6.QDO 2L._racLpTrRaUHJSfVhpEkQxGs.2HFuXIt0j2RORtr9jZSVCPgVDhc0U4J4RPwZRL_0P7gjDcWP G4MdpkUFcJkUJ1YHlcJfpHctA2XUTZArvajm0itpwhR2smZiIq93hplITzz8fnfOpWlxLwLsYnZF CdlDB0vHafIq2orFexvswAp4wN3t194gTdsRYFRb155SjJYWGqqO5ebkG_a4sNMEHjw3bWIkwJen BEw_V2ojwDskBxi3WG17tOuETjTC1JFJ2KS2J_mdMrL3jCaqdnNI8.QQ_Bw_8qm3278md.K_.JMP YAZKkKFVyeXb_zSuRhimAiM7srD14EMjM_vTdQNbiXe49npI_iZvJGFnN6TPTcbwj73p2yePUK0X Gx0UYGxraP9py60CFJxQM_efLjNE.wLzpGglU00MQSqrVmNQyhCP0I9dUJTB7aHqvGCmTlgy2xJz oKmiVYUWgXFGdq8vmxjsIyM1uRC63HSPMYy_jeBDZrA9uSNo4TKwYLC4btLDHXqaAeovDSRcMGKp 7JzNmId2utFSUG0kOV0QKJ7.vIYpg3ypdTYJtzzQFbQM98vonkoNLRglID.iIrPJSwRdobV0.Ovu ktr4wFfmCAdmIs3Fa002NpCa6Xc35TnbREcJ0LcLQ_ X-Sonic-MF: X-Sonic-ID: a7fc630c-2893-40bd-9503-f87e316db8df Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ne1.yahoo.com with HTTP; Sat, 4 May 2024 09:48:37 +0000 Original-Received: by hermes--production-sg3-6f9f87bd85-wmrrf (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID bc2abb2301edf2d88f0ab71ad98d1e61; Sat, 04 May 2024 09:48:30 +0000 (UTC) In-Reply-To: (Yuan Fu's message of "Sat, 4 May 2024 02:20:07 -0700") X-Mailer: WebService/1.1.22256 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.185.146; envelope-from=luangruo@yahoo.com; helo=sonic305-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:318735 Archived-At: Yuan Fu writes: > Hey guys, > > I followed the original tool-bar icon thread in 2022. At the time I > didn=E2=80=99t have much time and I personally prefer colorful icons for = the > tool bar [1] (IMO mono-colored symbolic icons are more suitable for > inline, small icons), so I didn=E2=80=99t do anything except for observin= g the > discussion. > > [1] I especially adore the life ring icon for help! Whatever icon set > we use for the tool-bar, the help icon should always be a cute life > ring :-) > > The recent Emacs app icon thread reminded me of that thread, and I do > have time now. So, I went ahead and searched for the Tango and Adwaita > icons (basically the high-res version of the existing tool-bar icon > that we use), then converted them to be suitable for Emacs tool-bar. > > About 1/3 of the icons can be directly taken from Tango or Adwaita, > the rest I have to modify or kind of take apart and > re-assemble. Anyway, in the end I managed to get most of the basic > icons covered. For details see etc/images/scalable/README. > > You can see the attached screenshots for the current built-in icons > and the new icons. I also attached the patch for it. You want to > rebuild or byte-compile tool-bar.el for the new icons to take effect. > > I hope these new icons won=E2=80=99t be controversial. As you can see, th= ey > are basically straight high-res upgrades for the existing icons. There > are many imperfections that=E2=80=99ll be atrocious in the eyes of a grap= hic > designer=E2=80=94I did the conversion work in an afternoon and I=E2=80=99= m no where > near a graphic designer; but it=E2=80=99s definitely an upgrade and we can > always incrementally improve after. They will not be controversial if it is possible to opt out of them, and enough of the icons are replaced that none of us encounter tool-bars bearing an unsightly mixture of old and new. That is to say: Please generate XPM and monochrome PBM versions of the new icons introduced, these being the only two image formats implemented without dependencies in image.c, and enable SVG only on systems where the scalable versions produce a visible improvement to image quality. Finally, please see that _all_ major modes are covered by this new icon set, including but not limited to message-mode, Doc View, xwidget-webkit, and anywhere else a custom tool-bar-map is defined, and that there is means of reverting to the old set of icons, for users who are so inclined. The PBM icons should not be unmodified ImageMagick output, they should be modified for legibility on actual monochrome displays. The other day there was a post to help-gnu-emacs from an Android user with a monochrome display, so these configurations are by no means irrelevant. > If no one objects, I=E2=80=99ll happily push this to master. Nobody objects to these icons in principle, but do not push such changes until they are complete and have been tested by an adequately wide audience. Let it not be forgotten that we are still contending with the fallout from another enormously premature change.