From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master ac797f60160 2/2: ; * lisp/net/shr.el (shr-image-zoom-levels): Fix wrong type. Date: Thu, 11 Jul 2024 09:37:45 +0200 Message-ID: <87plrk8jli.fsf@gmail.com> References: <172054273136.24557.15429439759711990393@vcs2.savannah.gnu.org> <20240709163212.254C9C2BC9A@vcs2.savannah.gnu.org> <877cdua4ur.fsf@gmail.com> <811B0DE0-5514-436F-9D95-8F6294FB4909@gmail.com> <8734ohaa9m.fsf@gmail.com> <8b88d2f3-b0dc-6307-480d-0bdbb0664c68@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3067"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , Emacs Devel To: Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 11 09:38:41 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sRoO1-0000d5-F1 for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Jul 2024 09:38:41 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRoNG-00082t-9j; Thu, 11 Jul 2024 03:37:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRoNE-00082g-HS for emacs-devel@gnu.org; Thu, 11 Jul 2024 03:37:52 -0400 Original-Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sRoND-0007au-1W for emacs-devel@gnu.org; Thu, 11 Jul 2024 03:37:52 -0400 Original-Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4267300145eso4091755e9.3 for ; Thu, 11 Jul 2024 00:37:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720683468; x=1721288268; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=iaJnWCeIXDVaM2gI1sRWLwGd4F+2Sq4JLeSURCqrX2I=; b=ghZtkPXRNnWVLkyYvHDxEdqovtqgnjl9Bth1JqhDK5ZG9kXGq6hyKEMelxWREZ/Dyi zvdLDaK8KFVa/J3bixEvmkdteE4ZtGKqeff78k3MLQ7ydsgCliVU8zl/4o6EjzOCPpir C7Cm+r1rx9oewpZZDyxJSBkyx8xRZilkpjttICtbv/WJmTw92/gzuxjlCS+aCZzJYOD0 sTngsm03gV8jyG7cl5AG9vbaGg6P4wY5yU0cbrnobUmmN8KsF5q0JPlOyff8lzG/ocfy ESALMqzk1zKQLien8jV8ocY0E9K+1hLV7w2vsukIAKg29nj9miSqf0IR5CKcwYGZZmIB m5oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720683468; x=1721288268; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iaJnWCeIXDVaM2gI1sRWLwGd4F+2Sq4JLeSURCqrX2I=; b=qsKdi8JqjbMv4I8Ln3lpolJd5KTZWH2KvEfAKpcgPbqbMXEqpbupsWWxg1nVDO12Dz c/xEOFqXfrdPqUibKrrp1LmKF1nuuGXhyEyP9qOSz8etTEzBRRt0WbUu7PLm1AgYCKr7 sxlEp4qaghsSaNq8Wm0KDt7pXYldCHWYzjE9DgR+mEhCuEIdfShc6sL06XsmiePtNfBv JSNkNo+duCHAUvimYUsD8+ril1ZQLtcUYu82dYgoq75nDtAbophnjP69R1LIhKddQv22 gtY4yzSkA1/lZkjsdtuqlAP6+sMC4Ld1TdWo+wwB23xUZ1KJZ0AL8Yo2QgU5Jy07EbHW siag== X-Forwarded-Encrypted: i=1; AJvYcCXynT85n+qoGVtzSQSurIaHM+wmSBirSmCeF8fWpAJOCC3nhrQR9fIZeoSEOzXMsPsGIs9dsQY1V+rdoxJlS6GYd26R X-Gm-Message-State: AOJu0YxK51fAQKQivS+tnZhEF/gsgBatU2+0WD95dZ6t/1/6x1KZ4yJn nfeeyW5Kh+fxsma5Wn7rPcDUBjacnNeszCbhBYgvIkP4M0YE38XUyGXzcg== X-Google-Smtp-Source: AGHT+IFru/KulrI+X/e9Lq/avqsq/izS9scR/hvRZugyAZvOnQ1SCy5hfdXUhuxUN7j2sqAs/XvTpA== X-Received: by 2002:adf:eac9:0:b0:367:9511:b612 with SMTP id ffacd0b85a97d-367ceadc704mr6370142f8f.61.1720683467470; Thu, 11 Jul 2024 00:37:47 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cdfa06d3sm6982119f8f.75.2024.07.11.00.37.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jul 2024 00:37:46 -0700 (PDT) In-Reply-To: <8b88d2f3-b0dc-6307-480d-0bdbb0664c68@gmail.com> (Jim Porter's message of "Wed, 10 Jul 2024 10:24:10 -0700") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=rpluim@gmail.com; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321582 Archived-At: >>>>> On Wed, 10 Jul 2024 10:24:10 -0700, Jim Porter said: Jim> On 7/10/2024 2:04 AM, Robert Pluim wrote: >> The type agrees with the value, but not the documentation: >> Each element >> can be one of the following symbols: Jim> [snip] >> The current type lets you choose to enable each option, but not to >> reorder them without resorting to lisp code. Jim> Ultimately, I'm more interested in ensuring the list has no duplic= ate Jim> elements than in allowing reordering (the code would behave strang= ely Jim> with duplicate elements), but if we got both that would certainly = be Jim> nice. If we had to choose one or the other though, I think the cur= rent Jim> type (thanks Mattias!) is the way to go. The current type is `set', which is supposed to be orderless. If we change it to `repeat' we can always check for duplicates in the variable=CA=BCs `:set' function. Robert --=20