From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: MPS: Win64 testers? Date: Tue, 13 Aug 2024 15:51:07 +0000 Message-ID: <87plqc2zh3.fsf@protonmail.com> References: <86le17murx.fsf@gnu.org> <86y156kzh0.fsf@gnu.org> <86wmkqkz0g.fsf@gnu.org> <86frreklfy.fsf@gnu.org> <867cckha4f.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34304"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Quang Kien Nguyen , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 13 18:31:05 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sduQK-0008fJ-Sr for ged-emacs-devel@m.gmane-mx.org; Tue, 13 Aug 2024 18:31:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sduPh-0002qJ-UD; Tue, 13 Aug 2024 12:30:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sdtno-0006cX-To for emacs-devel@gnu.org; Tue, 13 Aug 2024 11:51:17 -0400 Original-Received: from mail-40133.protonmail.ch ([185.70.40.133]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sdtnm-0000RV-Qb; Tue, 13 Aug 2024 11:51:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1723564271; x=1723823471; bh=boCmniIG25jgTu3p3zwGO4DYY37rBb5nBGKmcOV6f5c=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=uF1qXGW+X6GWgXQYHc0K40f5aL/kQBz0ukc+evahgQyjyLuwqxHIa2UfeFruQZULj BGMPrelmeTmGvyac7DuPuuQFgLIYPJ6JDzVzXOz61KMFg4q1GuTavX94AqY5Hr6z9q PFvem8rMGawtYvRpIGd8l8YxwbKOvo1Iv/7BGcu8jRUip6jGYeRirxWKydtPNnA2sa xqBqGZGxS5Lt7TiQjQf3+EA6N+AmKw057oqlLHpIh2csmANZSfU2Z3BXINBHLy6xTZ Ne1jWD6s60qflQA6VHe9jJ3Ax4Cq+iPoWJ2zsphYCAxll2+/6gQQ4LihUnGoxEstAt rzF6VF2uqJujA== In-Reply-To: <867cckha4f.fsf@gnu.org> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: dc0b11ddf267fea6558c263b779731345dc52083 Received-SPF: pass client-ip=185.70.40.133; envelope-from=pipcet@protonmail.com; helo=mail-40133.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 13 Aug 2024 12:30:23 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322712 Archived-At: "Eli Zaretskii" writes: >> From: Quang Kien Nguyen >> Date: Tue, 13 Aug 2024 05:12:19 -0700 >> Cc: emacs-devel@gnu.org >> >> By the way, @Pip Cet, have you been able to build 64bit Emacs with MPS? (I assume you mean for Microsoft Windows). Yes, I have. It's even started on a machine running Microsoft Windows, though I'm usually limited to testing on wine, and even that binary was built using wine. >> I've tried to build them but Emacs crashed as soon as temacs was >> trying to bootstrap. That's probably the setjmp thing, worked around in my tree at https://codeberg.org/pipcet/emacs-android (sorry about the repository name, it's no longer accurate). Note that there are "Actions" available which have artifacts that you can download and test, if you are so inclined. Right now, for me, the ucrt64 build doesn't work but the 64-bit mingw32 build does. If you're interested in testing this, please let me know which tree you use so I can provide a patch that applies there and just contains the setjmp fix. >> Here is the patch I used for MPS though >> https://raw.githubusercontent.com/kiennq/emacs-build/main/patches/mps/00= 02-mingw64-support-mingw64.patch > > Did you run the MPS test suite, and if you did, did all the tests > succeed? I must confess I haven't done that yet. As it has been decided to deliberately break Emacs CI/CD using Wine, though, I'm not sure there's any point. > It is not recommended to try the MPS build of Emacs as long as the MPS > library doesn't pass the tests with flying colors. The patch to > mpstd.h is the first place to look for possible issues. E.g., why is > MPS_PF_ALIGN 8 and not 16? I don't believe we use that macro anywhere (scratch/igc uses 8 byte alignme= nt on all platforms) but yes, MPS_PF_ALIGN should be 16. > Also, did you audit all the places > conditioned on MPS_BUILD_MV and MPS_PF_W3I6MV and made sure they are > conditioned on MPS_BUILD_GC and MPS_PF_W3I6GC when the MinGW64 build > needs the same code as the 64-bit MSVC build? I'm pretty sure I did, but I use a slightly different patch (https://codeberg.org/pipcet/mps): Please be aware that this code does run Emacs, but hasn't passed the test suite, so pretty much the only thing you should be doing with it is to run the test suite. Also, please keep in mind that -fno-omit-frame-pointer may be required for GCC when optimizing. I spent entirely too much time tracking down a bug that was ultimately due to that missing flag. Pip