From: Morgan Willcock <morgan@ice9.digital>
To: emacs-devel@gnu.org
Cc: Eli Zaretskii <eliz@gnu.org>, Tassilo Horn <tsdh@gnu.org>
Subject: Re: No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback)
Date: Sun, 22 Sep 2024 21:57:02 +0100 [thread overview]
Message-ID: <87plovmmox.fsf@ice9.digital> (raw)
In-Reply-To: <87msk0oqoq.fsf@gnu.org> (Tassilo Horn's message of "Sat, 21 Sep 2024 19:35:33 +0200")
Tassilo Horn <tsdh@gnu.org> writes:
> Since doc-view-svg-face inherits from the default theme, in theory the
> SVG should be adjusted acording to your theme.
>> If the SVG rendering is enabled (when available) by default, does this
>> mean that it is the user's responsibility to set usable default
>> colours? Or should the theme be setting usable default colours?
>
> The latter. If the theme sets the default face sensibly (which it
> surely does), then your PDFs should look the same. Well, and that's
> true for "normal" PDF documents (black on white, e.g., academic papers)
> but somehow fails for "fancy" documents.
>
> I don't know how the :foreground/:background SVG image properties work
> but it looks to me as if :background works well every time but
> :foreground doesn't as soon as the text is not black. I suspect the
> heuristic is something like: if it's transparent, it's the background,
> and if it's either black or white, it's the foreground.
When looking at the SVG files in the location browsed by
doc-view-dired-cache I can see that the Azure invoice has:
- A transparent background with black and grey text on it.
- A dark grey border with white text on it.
- A white border with black text on it.
The transparent background is shown as white or black, depending on
whether the light or dark theme is loaded, but the text is always
readable because the text colour complements the background.
The problem is the text that is not on the transparent area of the
document, presumably because a coloured border cannot be identified as
being part of the background and so the border colours will never follow
the theme.
Based on my usage, setting doc-view-mupdf-use-svg to t seems to make
reading PDF documents significantly more difficult.
Perhaps there should be an option to just assume a white background and
render using the original colours, and turn that on by default. Would
that be what a regular PDF viewer does?
--
Morgan Willcock
next prev parent reply other threads:[~2024-09-22 20:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 17:53 No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback) Morgan Willcock
2024-09-20 18:53 ` Eli Zaretskii
2024-09-20 19:34 ` Visuwesh
2024-09-20 19:39 ` Morgan Willcock
2024-09-20 22:29 ` chad
2024-09-20 22:46 ` Morgan Willcock
2024-09-21 8:09 ` Eli Zaretskii
2024-09-21 9:27 ` Morgan Willcock
2024-09-21 17:35 ` Tassilo Horn
2024-09-22 20:57 ` Morgan Willcock [this message]
2024-09-23 6:44 ` Tassilo Horn
2024-09-23 8:34 ` Manuel Giraud via Emacs development discussions.
2024-09-23 8:45 ` Tassilo Horn
2024-09-23 11:34 ` Manuel Giraud via Emacs development discussions.
2024-09-23 11:56 ` Eli Zaretskii
2024-09-23 14:51 ` Tassilo Horn
2024-09-23 15:35 ` Eli Zaretskii
2024-09-23 15:50 ` Morgan Willcock
2024-09-23 16:10 ` Tassilo Horn
2024-09-23 16:27 ` Eli Zaretskii
2024-09-23 16:54 ` Tassilo Horn
2024-09-24 11:17 ` Eli Zaretskii
2024-09-24 11:22 ` Tassilo Horn
2024-09-23 17:56 ` Manuel Giraud via Emacs development discussions.
2024-09-23 18:35 ` Tassilo Horn
2024-09-23 19:06 ` Manuel Giraud via Emacs development discussions.
2024-09-23 9:36 ` Visuwesh
2024-09-23 11:55 ` Eli Zaretskii
2024-09-23 12:05 ` Tassilo Horn
2024-09-23 15:32 ` Eli Zaretskii
2024-09-21 7:28 ` Tassilo Horn
2024-09-21 9:27 ` Morgan Willcock
2024-09-21 11:04 ` Visuwesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plovmmox.fsf@ice9.digital \
--to=morgan@ice9.digital \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).