From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] New package: hyperdrive-org-transclusion Date: Mon, 23 Sep 2024 06:30:57 +0000 Message-ID: <87plou7ufy.fsf@posteo.net> References: <87ed5lzytw.fsf@ushin.org> <87a5fz8sii.fsf@posteo.net> <87frpqhqcp.fsf@ushin.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35929"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel Mailing List , Adam Porter , Paula Maas , Protesilaos Stavrou , Noboru Ota To: Joseph Turner Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 23 08:32:08 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ssccB-0009A5-3r for ged-emacs-devel@m.gmane-mx.org; Mon, 23 Sep 2024 08:32:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sscbJ-0002RD-Pd; Mon, 23 Sep 2024 02:31:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sscbH-0002Qx-7G for emacs-devel@gnu.org; Mon, 23 Sep 2024 02:31:11 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sscbC-0006RT-Ou for emacs-devel@gnu.org; Mon, 23 Sep 2024 02:31:10 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 0851E240027 for ; Mon, 23 Sep 2024 08:31:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1727073061; bh=OLJOCfAAeiECf2hrf+1JDPjeFD3tPrOd9vDNlyokzw4=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=geeXB6s7J2hBTjBdpPbdUrFSrUvK/Rnco1j6A3dwk67h5XdIr1n117/LXH80C9pI4 SuDhYzF3b31fqDjCIix9Hoze4ypaJJy24QC6XTLLHBuepDR3EtnUCckstjGafQW3Gi 6man8IRouaOPZXep3TW14ajafyYRUiWolnHjTwrLd1gfk777bgthbG8Y5kiGBoTptD 3V9lPcFJ0DlO6lXLMGVLkskqV2NlKi6XMLDiGCIci/0WR62tHtaWkL/9kPIbx6y9pj R9CyJGxLE4Pmu8uTjcHiAtPlnHuNdEHgRe7ASId+o7NfmlC6DsAHZ585bkTF1AxJDi 2xbjGr0Myi1VA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XBtRR0q1Qz6ty8; Mon, 23 Sep 2024 08:30:59 +0200 (CEST) In-Reply-To: <87frpqhqcp.fsf@ushin.org> (Joseph Turner's message of "Sun, 22 Sep 2024 22:49:10 -0700") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323943 Archived-At: Joseph Turner writes: > Philip Kaludercic writes: > >> Joseph Turner writes: >> >>> Hello all, >> >> Hey, sorry for the delay, >> >>> extends >>> org-transclusion by allowing content served over the hyper:// network to >>> be transcluded using hyperdrive.el. >> >> Code/content-wise, I cannot really comment on anything as it is based on >> multiple layers of API that I am not familiar with. That being said, >> the (display-fill-column-indicator-mode) in the .dir-locals.el file is >> very unusual and something I think you should avoid. Also, an >> .elpaignore file that would exclude some of the files that are only >> interesting to contributors and maintainers would be nice. > > Thank you for the review!! > > The (display-fill-column-indicator-mode) addition was something that we > settled on in the hyperdrive.el project last year as a way to remind > contributors to fill code before committing. I'm open to removing it. > Would you elaborate on the reasons to avoid it? The main reasons is that it involves an `eval' expression, which is inherently controversial, especially when enabling a visual minor mode. Have you considered using Git hooks to enforce the style guide? >>> + (hyperdrive-org-transclusion :url "https://git.sr.ht/~ushin/hyperdrive-org-transclusion" >>> + :readme "README.org" >> >> This file is automatically detected, we just choose to ignore README.md >> files by default. > > Good to know. I've removed that line in the attached patch. > >>> + :news "CHANGELOG.org") >> >> Fun fact: If you call the file NEWS.org, it will be automatically detected. > > Good to know. I'd like to leave CHANGELOG.org as it is for now. This is actually a fairly common file name, that it would be worth checking for it as well. > Thank you!! > > Joseph > > > From 931e466053437a727fea76005b368f436cbf80e9 Mon Sep 17 00:00:00 2001 > From: Joseph Turner > Date: Sun, 22 Sep 2024 22:46:57 -0700 > Subject: [PATCH] * elpa-packages (hyperdrive-org-transclusion): New package > > --- > elpa-packages | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/elpa-packages b/elpa-packages > index 0ea8b159a6..3ddbfec540 100644 > --- a/elpa-packages > +++ b/elpa-packages > @@ -402,6 +402,9 @@ > :release-branch "stable" > :doc "doc/hyperdrive.org") > > + (hyperdrive-org-transclusion :url "https://git.sr.ht/~ushin/hyperdrive-org-transclusion" > + :news "CHANGELOG.org") > + > (idle-highlight-mode :url "https://codeberg.org/ideasman42/emacs-idle-highlight-mode" > :ignored-files (".elisp-autofmt")) I'll go ahead an apply this change, as the local variable issue isn't something I'd consider to be "blocking". -- Philip Kaludercic on siskin