From: Philip Kaludercic <philipk@posteo.net>
To: Joseph Turner <joseph@ushin.org>
Cc: Emacs Devel Mailing List <emacs-devel@gnu.org>,
Adam Porter <adam@alphapapa.net>, Paula Maas <pmaas@ushin.org>,
Protesilaos Stavrou <public@protesilaos.com>,
Noboru Ota <me@nobiot.com>
Subject: Re: [NonGNU ELPA] New package: hyperdrive-org-transclusion
Date: Mon, 23 Sep 2024 06:30:57 +0000 [thread overview]
Message-ID: <87plou7ufy.fsf@posteo.net> (raw)
In-Reply-To: <87frpqhqcp.fsf@ushin.org> (Joseph Turner's message of "Sun, 22 Sep 2024 22:49:10 -0700")
Joseph Turner <joseph@ushin.org> writes:
> Philip Kaludercic <philipk@posteo.net> writes:
>
>> Joseph Turner <joseph@ushin.org> writes:
>>
>>> Hello all,
>>
>> Hey, sorry for the delay,
>>
>>> <https://git.sr.ht/~ushin/hyperdrive-org-transclusion> extends
>>> org-transclusion by allowing content served over the hyper:// network to
>>> be transcluded using hyperdrive.el.
>>
>> Code/content-wise, I cannot really comment on anything as it is based on
>> multiple layers of API that I am not familiar with. That being said,
>> the (display-fill-column-indicator-mode) in the .dir-locals.el file is
>> very unusual and something I think you should avoid. Also, an
>> .elpaignore file that would exclude some of the files that are only
>> interesting to contributors and maintainers would be nice.
>
> Thank you for the review!!
>
> The (display-fill-column-indicator-mode) addition was something that we
> settled on in the hyperdrive.el project last year as a way to remind
> contributors to fill code before committing. I'm open to removing it.
> Would you elaborate on the reasons to avoid it?
The main reasons is that it involves an `eval' expression, which is
inherently controversial, especially when enabling a visual minor mode.
Have you considered using Git hooks to enforce the style guide?
>>> + (hyperdrive-org-transclusion :url "https://git.sr.ht/~ushin/hyperdrive-org-transclusion"
>>> + :readme "README.org"
>>
>> This file is automatically detected, we just choose to ignore README.md
>> files by default.
>
> Good to know. I've removed that line in the attached patch.
>
>>> + :news "CHANGELOG.org")
>>
>> Fun fact: If you call the file NEWS.org, it will be automatically detected.
>
> Good to know. I'd like to leave CHANGELOG.org as it is for now.
This is actually a fairly common file name, that it would be worth
checking for it as well.
> Thank you!!
>
> Joseph
>
>
> From 931e466053437a727fea76005b368f436cbf80e9 Mon Sep 17 00:00:00 2001
> From: Joseph Turner <joseph@breatheoutbreathe.in>
> Date: Sun, 22 Sep 2024 22:46:57 -0700
> Subject: [PATCH] * elpa-packages (hyperdrive-org-transclusion): New package
>
> ---
> elpa-packages | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/elpa-packages b/elpa-packages
> index 0ea8b159a6..3ddbfec540 100644
> --- a/elpa-packages
> +++ b/elpa-packages
> @@ -402,6 +402,9 @@
> :release-branch "stable"
> :doc "doc/hyperdrive.org")
>
> + (hyperdrive-org-transclusion :url "https://git.sr.ht/~ushin/hyperdrive-org-transclusion"
> + :news "CHANGELOG.org")
> +
> (idle-highlight-mode :url "https://codeberg.org/ideasman42/emacs-idle-highlight-mode"
> :ignored-files (".elisp-autofmt"))
I'll go ahead an apply this change, as the local variable issue isn't
something I'd consider to be "blocking".
--
Philip Kaludercic on siskin
next prev parent reply other threads:[~2024-09-23 6:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-14 21:53 [NonGNU ELPA] New package: hyperdrive-org-transclusion Joseph Turner
2024-09-22 18:15 ` Philip Kaludercic
2024-09-23 5:49 ` Joseph Turner
2024-09-23 6:30 ` Philip Kaludercic [this message]
2024-09-25 2:16 ` Joseph Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plou7ufy.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=adam@alphapapa.net \
--cc=emacs-devel@gnu.org \
--cc=joseph@ushin.org \
--cc=me@nobiot.com \
--cc=pmaas@ushin.org \
--cc=public@protesilaos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).