From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] New package: hyperdrive-org-transclusion Date: Tue, 24 Sep 2024 19:16:49 -0700 Message-ID: <87plos7a0e.fsf@ushin.org> References: <87ed5lzytw.fsf@ushin.org> <87a5fz8sii.fsf@posteo.net> <87frpqhqcp.fsf@ushin.org> <87plou7ufy.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16312"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel Mailing List , Adam Porter , Paula Maas , Protesilaos Stavrou , Noboru Ota To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 25 04:23:29 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1stHgf-00045T-02 for ged-emacs-devel@m.gmane-mx.org; Wed, 25 Sep 2024 04:23:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stHg0-0002DA-UF; Tue, 24 Sep 2024 22:22:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stHaW-0001tR-8K for emacs-devel@gnu.org; Tue, 24 Sep 2024 22:17:09 -0400 Original-Received: from out-180.mta0.migadu.com ([91.218.175.180]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stHaQ-0000HT-El for emacs-devel@gnu.org; Tue, 24 Sep 2024 22:17:08 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ushin.org; s=key1; t=1727230614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/6DbevoXO++7mgCfixedXJjKzNLTJlQQYaIBgtTTCDA=; b=hrS2vK5wsbD54YbJFuzFBH8nzQ/X5ec2OWwLmjVaSN/w0Kv4pti1+SnY2tVmvocDgJ407T QJwXbrc/LtnHOiiQCSK19kASMfewid8pShk43Q9fwJhV0dkzPPXRy2gWd0HPdYfgRrZXoW vhTjiXCZSalClxhb2HcBa3/T628lLZsganaXkAKq6cC9NAyw4rbsRWSX8WM3oLxju5+JuL jsc3mhXxfYSla0T23yQeglr27lMzQwDfa7b7XsFc4u6c+T1bLE/jvc1URLdnaUYKwIMtOh l0pR4Q1tiVqb6dsEXuRYsrxJV0FIp3jJHfgJD8W2da0k5czhA1WkfGBcJCs1Dw== In-Reply-To: <87plou7ufy.fsf@posteo.net> (Philip Kaludercic's message of "Mon, 23 Sep 2024 06:30:57 +0000") X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=91.218.175.180; envelope-from=joseph@ushin.org; helo=out-180.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 24 Sep 2024 22:22:47 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324049 Archived-At: Philip Kaludercic writes: > Joseph Turner writes: > >> Philip Kaludercic writes: >> >>> Joseph Turner writes: >>> >>>> Hello all, >>> >>> Hey, sorry for the delay, >>> >>>> extends >>>> org-transclusion by allowing content served over the hyper:// network to >>>> be transcluded using hyperdrive.el. >>> >>> Code/content-wise, I cannot really comment on anything as it is based on >>> multiple layers of API that I am not familiar with. That being said, >>> the (display-fill-column-indicator-mode) in the .dir-locals.el file is >>> very unusual and something I think you should avoid. Also, an >>> .elpaignore file that would exclude some of the files that are only >>> interesting to contributors and maintainers would be nice. >> >> Thank you for the review!! >> >> The (display-fill-column-indicator-mode) addition was something that we >> settled on in the hyperdrive.el project last year as a way to remind >> contributors to fill code before committing. I'm open to removing it. >> Would you elaborate on the reasons to avoid it? > > The main reasons is that it involves an `eval' expression, which is > inherently controversial, especially when enabling a visual minor mode. > > Have you considered using Git hooks to enforce the style guide? I hadn't, thanks! I'd still like the option for some highly nested code to go beyond the 80 column limit, and I'm concerned that the Git hook approach would not give the programmer the discretion to break the rule. >>>> + (hyperdrive-org-transclusion :url "https://git.sr.ht/~ushin/hyperdrive-org-transclusion" >>>> + :readme "README.org" >>> >>> This file is automatically detected, we just choose to ignore README.md >>> files by default. >> >> Good to know. I've removed that line in the attached patch. >> >>>> + :news "CHANGELOG.org") >>> >>> Fun fact: If you call the file NEWS.org, it will be automatically detected. >> >> Good to know. I'd like to leave CHANGELOG.org as it is for now. > > This is actually a fairly common file name, that it would be worth > checking for it as well. Agreed. >> Thank you!! >> >> Joseph >> >> >> From 931e466053437a727fea76005b368f436cbf80e9 Mon Sep 17 00:00:00 2001 >> From: Joseph Turner >> Date: Sun, 22 Sep 2024 22:46:57 -0700 >> Subject: [PATCH] * elpa-packages (hyperdrive-org-transclusion): New package >> >> --- >> elpa-packages | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/elpa-packages b/elpa-packages >> index 0ea8b159a6..3ddbfec540 100644 >> --- a/elpa-packages >> +++ b/elpa-packages >> @@ -402,6 +402,9 @@ >> :release-branch "stable" >> :doc "doc/hyperdrive.org") >> >> + (hyperdrive-org-transclusion :url "https://git.sr.ht/~ushin/hyperdrive-org-transclusion" >> + :news "CHANGELOG.org") >> + >> (idle-highlight-mode :url "https://codeberg.org/ideasman42/emacs-idle-highlight-mode" >> :ignored-files (".elisp-autofmt")) > > I'll go ahead an apply this change, as the local variable issue isn't > something I'd consider to be "blocking". Thank you!! Joseph