From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Use vtable for eww-bookmarks Date: Wed, 06 Nov 2024 20:13:25 +0530 Message-ID: <87pln8v2wi.fsf@gmail.com> References: <86r07osgcj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12845"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , emacs-devel@gnu.org, jporterbugs@gmail.com To: =?utf-8?Q?Sebasti=C3=A1n_Mon=C3=ADa?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 06 15:44:23 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t8hGh-0003Bn-QW for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Nov 2024 15:44:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t8hFv-0004Uj-4I; Wed, 06 Nov 2024 09:43:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8hFt-0004UM-7r for emacs-devel@gnu.org; Wed, 06 Nov 2024 09:43:33 -0500 Original-Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t8hFr-0005bE-RT; Wed, 06 Nov 2024 09:43:32 -0500 Original-Received: by mail-oi1-x243.google.com with SMTP id 5614622812f47-3e606cba08eso3863759b6e.0; Wed, 06 Nov 2024 06:43:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730904210; x=1731509010; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t50mvcZkO+vJHFkHDfbHegmW68Cv9XCvRM0/SBUyrW8=; b=iaMazpQQ2Inpj5p1G7k3oCfBxmxwPw0K+rLuRmefly5g3gee1KpWRmCx4yP/fOv2pd RDnBniytlveoG9Wt83rl1ICFDv+4W3vne6lVj7FhsHVfcx9vfgh6OArJeF3F+H/XJmrx zigK/5AW9r2IDBSXpCCSx5QTUdygChlFLJlKYoYnNv2tIWLBNY1M4EWz/iYdvjffePLS gK7tN3YYer5iTZkwtdrnFjOWlNeKUJooKHe5Hi9DEyeNxUhpwfvaleCewzMMOnBY8u7c Ogb9Cba+eZyJlmUFJdQ9ajtDoZ7kRQfv3ipwlA5j6gYjkYzd5nuNM6wHBUaybfcN/lSe dRYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730904210; x=1731509010; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=t50mvcZkO+vJHFkHDfbHegmW68Cv9XCvRM0/SBUyrW8=; b=Yok84xr6ZuojFGj/wJi5IsRcrJLmiVFqWuRXUDukIuiSfOohV7wG2JOcR+JLVmoRRI X9S1uAWSi1fMUlG/59HFpL+MmV8c32hloRotAXXWLnfgrjINcLaJRkcFJ1oCEAeGX5Ac pDYxsD1nDGO88INaL2EBWtUeALSzZmg3cfH4MpMpcV3zLDyU8YVPfuQ8do+JZx7SnFkm T2u5WbMUX4DPFXB7QOikSdTtAwcjExJrh/j3JkXwmTbQ53VvVOeVSrYKSMPlaMSv7Kfe r9ipF0Y5oDfFA01KgcphGiZ1330dYDjQxW0IV7j95NQqV/iUUKvgDwuf05PQPgH5wFfM PRuw== X-Forwarded-Encrypted: i=1; AJvYcCURi9Y567KMx+4szVzEXHbFhXrgR/PNs2ikle8fjqNvX21Wa1Te72DypifuLT6EVeaNacNk47IywlvJ3g==@gnu.org X-Gm-Message-State: AOJu0YxcU15ZvkiYrD1rrBfJ39NrgAWiEnD17BC5n/XxFft9ChSHJ/JM ops3/Nmdej/hnvxSB6t9ltOO9CfQ9Po6o6SnjZQ4IM1UqU9z/6G2kDvn1ehIc38= X-Google-Smtp-Source: AGHT+IHsXdLS03TWuV5kbGLa6jm+3HG3K8SP4d6T4WTtm4GPvLSmgC/tGg4BGelwiV3krmS/H8Ejkw== X-Received: by 2002:a05:6808:30a9:b0:3e6:1473:19d6 with SMTP id 5614622812f47-3e6583bdbcemr28469992b6e.29.1730904209997; Wed, 06 Nov 2024 06:43:29 -0800 (PST) Original-Received: from localhost ([1.7.159.70]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7ee74cc2a59sm7113096a12.54.2024.11.06.06.43.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Nov 2024 06:43:29 -0800 (PST) In-Reply-To: (=?utf-8?Q?=22Sebasti=C3=A1?= =?utf-8?Q?n_Mon=C3=ADa=22's?= message of "Wed, 06 Nov 2024 08:36:00 -0500") Received-SPF: pass client-ip=2607:f8b0:4864:20::243; envelope-from=visuweshm@gmail.com; helo=mail-oi1-x243.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325178 Archived-At: [=E0=AE=AA=E0=AF=81=E0=AE=A4=E0=AE=A9=E0=AF=8D =E0=AE=A8=E0=AE=B5=E0=AE=AE= =E0=AF=8D=E0=AE=AA=E0=AE=B0=E0=AF=8D 06, 2024] Sebasti=C3=A1n Mon=C3=ADa wr= ote: > Eli Zaretskii writes: >>> From: Sebasti=C3=A1n Mon=C3=ADa >>> Cc: Jim Porter >>> Date: Tue, 05 Nov 2024 17:53:44 -0500 >>>=20 >>> The attached patch is a first attempt at bringing eww-bookmarks in line >>> with the previous switch of eww-buffer-list to vtable. >>>=20 >>> There are features of eww-bookmarks I had no idea about, like the >>> ability to re-arrange them by killing and yaking. Or navigating to the >>> next bookmark from an eww buffer or invoking the command via M-x. >> >> I didn't try that, but if it changes the UI and UX, we need to think >> hard whether we want to surprise users with such changes. What's the >> rationale and the motivation for this? > > We decided a few weeks ago that to support reverting, the existing > 'eww-list-buffers' command could be implemented using a "proper table" > mode. The old code worked by inserting text and adding some properties. > > After some conversation we picked vtable for this. The code was marged > recently. > > During that work I noticed 'eww-list-bookmarks' also used this artisanal > approach to building the table, and suggested it would be nice to > convert it to vtable, and make it consistent with the new buffer list. > This is the patch that follows on that suggestion. > > Regarding UI/UX changes, there isn't much of a difference on how the > table looks. The new one supports sorting though. Although I had to add > a binding to "undo sorting", to support an exising feature of > eww-bookmarks that lets you re-order the list. Can the -> bitmaps in the fringe be removed from the new listing? It is ugly (and quite misleading too). Or is there a new column that is hidden in the new listing that is not shown in the screenshot?