From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.devel Subject: Re: emacs-30 6bca138d60e: Fix latest test for dabbrev-expand Date: Mon, 02 Dec 2024 23:16:11 +0100 Message-ID: <87plm9ybmc.fsf@gmx.net> References: <173314163483.652988.2881826266893472321@vcs3.savannah.gnu.org> <20241202121355.3BF7D526A27@vcs3.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40899"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 02 23:17:02 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tIEj0-000AVA-Qf for ged-emacs-devel@m.gmane-mx.org; Mon, 02 Dec 2024 23:17:02 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIEiK-0004Yt-8s; Mon, 02 Dec 2024 17:16:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIEiH-0004Ye-1b for emacs-devel@gnu.org; Mon, 02 Dec 2024 17:16:17 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIEiF-0007w5-3t; Mon, 02 Dec 2024 17:16:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1733177772; x=1733782572; i=stephen.berman@gmx.net; bh=D/nB87oopj1nblZRoBJ2G1mJmZt871oRM+Sh8KEvmVU=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=RqUSWX4JGNsVmZcVvw70FHGGLZ3YT9xT0UrYMyRC4J+BZ2I62rwRsJ47G9Gj4ocs YpHAKOfEm9ou1/XCjy13zH+R/TG2emjjZlx77Q4BZWJ4/iwo4k5t7u6LrDAmhFqYM roeTQIFBAXAnaLn/P+Vx0Fc+MiYwWxh/zYwFsGBVBVGwgshWZG0eE9kF/he0L/iU+ U0gqT/KMLIHaQudSY0CsOpIpdTO25r/PfEQG8bLkV5b6FaMkQcY16gSK9CXaq4/mV 58tmg3gIUbPe+Atg6yObZ3GybfKOrU8UlVYAZcoDGVIlL23ZTyu2J7fp/cSb+iyXa zXkrbkrbHSpbmkD9sQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfssd ([94.134.94.179]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MmUHp-1u0bs23pnF-00jGNg; Mon, 02 Dec 2024 23:16:11 +0100 In-Reply-To: (Andrea Corallo's message of "Mon, 02 Dec 2024 15:45:23 -0500") X-Provags-ID: V03:K1:J9+reGWg/VizQV3ygEIa1wNn7eo0T3eq8poVFMXd8gq3a5MneUH r5WT7cht9kgnlcbEJl7syie6GwKKxNsfTWmnPCgzNjphzjsP4Dg4+WojjlogX7Y4+k48q75 He6BzFK+N3DtcmKavxIV+NmxRBfl4OTSJa5QwypgstzjYvIbBcRCMTSz3LfrPiUQW4xhvf/ UIK577GLU4WC9XJRL0nkA== UI-OutboundReport: notjunk:1;M01:P0:JSaaNlFJ5Eo=;MVxF3y0LnIdR7hZ3M/kDlDVOjvS zW35UUY+bYZ56j1PUEZJmA02TOcTtooZA/qN6KztvOhvptilElk+0yEMZoJmpaG7Q5GBEpULx L/MhRD03gM1x2NPUIIo6BgHiNal27FxgAjTNAK07EbLGAb4/+M+2/NtrhwPArpVmy9vRUNROg 5Pk0Wa7wPK84nPjKNiACG0tLA8xD5U2aVDMVXc7HDta/WBRYxE4OIul0BXbCh1J+hhQZkpYtj gw0nTpjoGeiKSJI7YpLh//WTZFbTiZThVaDS0Y0Dra8wg3eeRsTlwJg3MPRgfK0ez9jTJS8W0 hycwlqDMi9KZIOTbr97U8QbYmz8jWgZcpJAe1IoXrvB13ObcBsCyer420Hm/lyyUJFAb+hN5b FJAc8hswfJyaMfbZ7rJHgMoE58o3kstsSttkQE+dX/7yJGkNe8cnnNJ0jyrS+HSeVmvVR3yGC P8Ra1h0LV1wpU7OAckWhDL6AEi+o8WJP8c3G4V6FB8KF5U0IxP2P4cryYKpx6u86Vkr8HGK5w t4DBhpd03FLeYWaTrSMnaWUt/TA2xN4fubCk/rzaohplejhSofcjq0t+v5TIAE2WhHMr2fYl3 E3x9/P0nmRlzF6dxbgZY4Sojw5u8gMPdQpMe7KEiogEYeK6rQVKHgazT3x3HEcISW9WMq/ddB /yihO7RHvORLNdRx/XQ/dLZpggzmXbmrzrl2ECHwoca0QiRBuc/HbHHHbKWFTz/ZpQnnE4Itg /VmoLpig23DichOE8Ge0XGQKPzlimZx+m3c0Zod5s/Y9PFAmVxPuAHiDQ6dDveQA1pQ5pIBX Received-SPF: pass client-ip=212.227.17.21; envelope-from=stephen.berman@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325955 Archived-At: On Mon, 02 Dec 2024 15:45:23 -0500 Andrea Corallo wrote: > Stephen Berman via Mailing list for Emacs changes > writes: > >> branch: emacs-30 >> commit 6bca138d60e47d0fbab4faf8e83c5b9b319f260d >> Author: Stephen Berman >> Commit: Stephen Berman >> >> Fix latest test for dabbrev-expand >> >> * test/lisp/dabbrev-tests.el (dabbrev-expand-after-killing-buffer): >> Fix typo in a 'should' test, use part of return value of 'should-error' >> test, and remove mistaken and unfounded FIXME comment. > > Hello Stephen, > > this commit is introducing in my test-bed the following three failures > in emacs-30: dabbrev-expand-test-other-buffer-4, > dabbrev-expand-test-other-buffer-3, dabbrev-expand-after-killing-buffer. > Could you please have a look? > > Andrea How does your testbed run the tests? When I invoke `emacs-30 -batch -l ~/src/emacs/emacs-30/test/lisp/dabbrev-tests.el -f ert-run-tests-batch-and-exit' from the shell, all tests pass. Likewise, when I start emacs-30 -Q, then `M-x load-file ~/src/emacs/emacs-30/test/lisp/dabbrev-tests.el', then kill all non-hidden buffers except *scratch*, and then run `M-x ert', all tests pass. Since the batch run is also used by `make check', I've assumed that, since the tests succeed (at least for me) in this mode, they are valid regression tests. In contrast, when I start emacs -Q, visit ~/src/emacs/emacs-30/test/lisp/dabbrev-tests.el, evaluate the buffer and run `M-x ert', then I get five test failures: dabbrev-expand-test-other-buffer-{1,2,3,4} and dabbrev-expand-after-killing-buffer. The latter fails because dabbrev-expand finds an expansion in the test file buffer (but succeeds when there is no such buffer, as in the previous run starting with -Q). The four other tests fail possibly for the same reason; however, these four tests fail in this way since being introduced in commit 8113b5c562 (see https://lists.gnu.org/archive/html/bug-gnu-emacs/2024-10/msg01752.html), so it puzzles me that you only see just two of those failures and only after my latest commit. (However, I did get the same three failures you reported when I ran ert on the test file from commit bd8a6f70fb, i.e. the one prior to the above commit, but only after uncommenting the code lines that are commented out in that commit. Could it be that you accidentally tested using that previous commit with those code lines uncommented?) Steve Berman